Received-SPF: pass (google.com: domain of linux-kernel+bounces-170884-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c20b59a1-4aba-4c68-b2b0-5cb4a0281540@kontron.de>
Date: Tue, 7 May 2024 10:40:32 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation
 rounding
To: Adam Ford <aford173@gmail.com>,
 Marek Szyprowski <m.szyprowski@samsung.com>
Cc: dri-devel@lists.freedesktop.org, marex@denx.de, aford@beaconembedded.com,
 Inki Dae <inki.dae@samsung.com>, Jagan Teki <jagan@amarulasolutions.com>,
 Andrzej Hajda <andrzej.hajda@intel.com>,
 Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Marco Felsch <m.felsch@pengutronix.de>,
 Michael Tretter <m.tretter@pengutronix.de>, linux-kernel@vger.kernel.org
References: <20240211230931.188194-1-aford173@gmail.com>
 <CGME20240211230945eucas1p1863deb244ef4fdc68825ff01d082e270@eucas1p1.samsung.com>
 <20240211230931.188194-2-aford173@gmail.com>
 <6fcfe1bb-a1e9-4d7c-aff7-e572bcdf5d31@samsung.com>
 <CAHCN7xJRgW4Y3YML+tToPw1TgA3o158XCEUcb9p-S+nvDWgzRQ@mail.gmail.com>
Content-Language: en-US, de-DE
From: Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <CAHCN7xJRgW4Y3YML+tToPw1TgA3o158XCEUcb9p-S+nvDWgzRQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZE9iMEJESVpWT1dDQ0kzc1pjS1JyZEFNalpKdzdYSVVmUDFKR1NwZCtDZVYr?=
 =?utf-8?B?bjlBZ09vYmR1T0NkdFh5blVScjFaeERsNWNJNUp2c0xGMzFSYmVYMWliSVBs?=
 =?utf-8?B?TDVRaHkvQkJCaDIrT1JzalNuOHRzVnYxbytnWktjZlVDWklOcFh5WDd6a1dW?=
 =?utf-8?B?WjZrNStNV1FVUGRnZi91STRBREhzQkRWeDZMNjNDQU9xZ3FZTHZ4ZXFaYjli?=
 =?utf-8?B?WHNEQTU4UXlVNWJjckhJZEgxZEs1OGhFcXdwNGlBcUw0Q3RocXd0SEpUL0NV?=
 =?utf-8?B?Tkt5QWh6dENWZFB6OCtkcXh2SExXeS9xM05LNnRhWnIrQWVGbXY3YkVQSS9w?=
 =?utf-8?B?UGNGUW5PVmRRc2VtUThKYTU3NlFLbEk0RGtaamF3c0d0UUI0T01UUzhTcWE5?=
 =?utf-8?B?RVZzbmV3QitseVVselNmNkRnUWV6K0ZvVGJ2L0w1dUY1b29tSmhSRFV2c0J0?=
 =?utf-8?B?LzBVaGRpRldBUm9iZkhVYktDRnBLRmVSL05ON1E5MVNQd2w2ZWszQUpuUUd0?=
 =?utf-8?B?YS9ERUgyaFBKcERFVTM1YlNDNlJrSDh1TzRlTFd5dDBzUXdDSmc4eDlMZ3di?=
 =?utf-8?B?UEJiVnVuRU5MZXo3ZVNKTFpldCt0UHdCb3BQNGg3dmVtZTJhb2E4OEE1K0pk?=
 =?utf-8?B?dmd3T3FKS1J1Nk5FK2pseXdrcFRmQ09pVHNrN0pPb1gvNEZpNXVDWTRMRzlI?=
 =?utf-8?B?L2JKWU9LVXVoZU1HL28rVVdueTc1K1Zzd1YwVENXUkorQ0dyOXFwUitTYU9k?=
 =?utf-8?B?Rk5JWWtSUDl4cWJKOGZqUWorbnNrbFZFVktTTXhPbFZ3WE45SmFyMkRRejg0?=
 =?utf-8?B?cGlaUGFwOXNTSVcxT3pUKzUzSldWeTJIZ1h3TGFtejRDcTJLZTZaaDB6QkJ4?=
 =?utf-8?B?S1V2MnNBKzk2em5EcWVFTXRpZGZvWjZjM0kwN01HWFB4RzRKRVJpbnBSd1ll?=
 =?utf-8?B?RnVDRU50ZDJoNE1ORG1halVlRUpVTmM5WEdNeUhRWWtaTXVZbm5LckVnME11?=
 =?utf-8?B?U3JqMU41QWtSSkxPenYzVzB5S2hxcGREaTN4dldRaVN2ZUU5b3RrK0U3MThv?=
 =?utf-8?B?c2s5ampVaXJlRU9ST2tHeVhzd0UvVENlVzl5TG0xV2tVWm41MkJhbUFZWkNI?=
 =?utf-8?B?RFVuS1NMb1M1OStjTmw0cWN0RzMwVGxabEh4bFJRL2xKYk5aMXBiVXBqa2Iv?=
 =?utf-8?B?NjdPcVJlQ0k2RGdJSUsvcGI4R3lGTjRQdURRSFRQaTROL1BoNExDVkNHN0FU?=
 =?utf-8?B?cUJqaDl0Q2h6Y3BKUXBKNnNqNkEvcG5Md2lNZjVSWXFYSnkxTUFIUml4dTE4?=
 =?utf-8?B?U1lLS0VRclRPUHBFR3M4U00xMndwTDZuUFRwK3BsbWYxUEo5eDZRQmV3aUNO?=
 =?utf-8?B?cnNQNHdFSUZzVXZvc0c2bXQ2eVFSVnNtMi9ldlZxTlViWnJlR2hDUWptYmMr?=
 =?utf-8?B?OTZsNXkxU1FwVHFzaS95WmRTS0lHSy8rMjc4dTFDVWd3T1p5VlI3Qm5wem9U?=
 =?utf-8?B?SGNEWm5wWjFxN1hxejFHWkdIeHhhM0I1NWlVVUpoYUhXendUZzF0bmVpRnVU?=
 =?utf-8?B?MkZQOHFzOGttM2s2WkdoQXM4QjVMTUJmcmdWdjROdlpCYjdzcE5FcnZXMmdQ?=
 =?utf-8?B?MDQrVGFFM2dzQlczTDN2QmRqbDdZQWVoN0xrcEQ1ay9ZR29nQmRqTU9tb2Fp?=
 =?utf-8?B?SGlnSS8wUWwzeHdyV2tXdEQ5NEE4akI0QjVjL0x4a1BWS3VsU0pXTjJzNGRz?=
 =?utf-8?B?YWVmVWxkbEd5L3J5RERmckhpeXlrdmdHeUgyZWpzaGtqQ3NreEVyeUJvOGtj?=
 =?utf-8?B?dzNxb2pZYnNRcnhTQmwwb3JEZEFyOGh1OVVBblVHcG5MVy9acDNlTkwvVlNr?=
 =?utf-8?B?OFlSVWJaVjd6YXdoU1UrRENzenYyY0Y1Q3hEamJoYzBUNi92RE5LYnlGa3dr?=
 =?utf-8?B?K3JRcTFoeHQ0YlI5UFJHbURHRWVUZlFqSEJFWU42a0Zhd1Z6RUVEeXZPWmxs?=
 =?utf-8?B?R0pTNHIvakhGNjVzeGt2QVlJTjB6Q3NFbXk0Ny82MXA2OXlWaDJrMjVJcExi?=
 =?utf-8?B?LzljWDRsRUcyTGVrVUlVWWhFVmVFNm52Y0xRUGJVV0ZNSTNhdjNVWG1rejF0?=
 =?utf-8?B?NVRLLzB6cVdiNGU1c21TZGk5SGdTTkllclNaRUw5akFtdkdrRDVyWHZxNENh?=
 =?utf-8?Q?Peib/3HCwbJ1+dUPiyrhx2M=3D?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cadc207-90e2-408e-922c-08dc6e715e59
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 08:40:37.4101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gbidwtegzkDU/vEz3zqKtOB3JdoZ+yZs26qz5/MFezJHEhflp2qwjbSH3AjNX0bm0J28wSl0jzUCJeSdxVxqOxkACHoH8vGGluKz7xD4hYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB6433

On 25.04.24 22:30, Adam Ford wrote:
> On Thu, Apr 25, 2024 at 4:19 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>>
>> On 12.02.2024 00:09, Adam Ford wrote:
>>> When using video sync pulses, the HFP, HBP, and HSA are divided between
>>> the available lanes if there is more than one lane.  For certain
>>> timings and lane configurations, the HFP may not be evenly divisible.
>>> If the HFP is rounded down, it ends up being too small which can cause
>>> some monitors to not sync properly. In these instances, adjust htotal
>>> and hsync to round the HFP up, and recalculate the htotal.
>>>
>>> Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron BL i.MX8MM with HDMI monitor
>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>
>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> Thank you very much for testing!
> 
>>
>>> ---
>>> V2:  No changes
>>>
>>> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
>>> index 8476650c477c..52939211fe93 100644
>>> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
>>> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
>>> @@ -1606,6 +1606,27 @@ static int samsung_dsim_atomic_check(struct drm_bridge *bridge,
>>>               adjusted_mode->flags |= (DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC);
>>>       }
>>>
>>> +     /*
>>> +      * When using video sync pulses, the HFP, HBP, and HSA are divided between
>>> +      * the available lanes if there is more than one lane.  For certain
>>> +      * timings and lane configurations, the HFP may not be evenly divisible.
>>> +      * If the HFP is rounded down, it ends up being too small which can cause
>>> +      * some monitors to not sync properly. In these instances, adjust htotal
>>> +      * and hsync to round the HFP up, and recalculate the htotal. Through trial
>>> +      * and error, it appears that the HBP and HSA do not appearto need the same
>>> +      * correction that HFP does.
>>> +      */
>>> +     if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE && dsi->lanes > 1) {
> 
> Frieder  &  Marek S,
> 
> Marek V is proposing we eliminate the check against the flags and do
> it unconditionally.  If I send you both a different patch, would you
> be willing to try them on your platforms?  I don't want to risk
> breaking a board.
> I used the check above from the NXP downstream kernel, so it felt
> safe, but I am not as familiar with the different DSI modes, so I am
> not sure what the impact would be if this read:
> 
>  if (dsi->lanes > 1) {
> 
> Does anyone else have an opinion on this?

My test only covers hardware with the ADV7535 which sets
MIPI_DSI_MODE_VIDEO_SYNC_PULSE. Doing the test without the check for
this flag won't make any difference in this case and it's therefore not
worth repeating the test.