Received-SPF: pass (google.com: domain of linux-kernel+bounces-170897-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 7 May 2024 10:54:02 +0200
From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 2/4] kbuild: do not add $(srctree) or $(objtree) to
 header search paths
Message-ID: <ZjnsKnjNhXwh5uz1@buildd.core.avm.de>
References: <20240427145502.2804311-1-masahiroy@kernel.org>
 <20240427145502.2804311-3-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240427145502.2804311-3-masahiroy@kernel.org>

On Sat, Apr 27, 2024 at 11:55:00PM +0900, Masahiro Yamada wrote:
> scripts/Makefile.lib is included not only from scripts/Makefile.build
> but also from scripts/Makefile.{vmlinux,modfinal} for building generated
> C files.
> 
> In scripts/Makefile.{vmlinux,modfinal}, $(obj) and $(src) are empty.
> 
> Therefore, the header include paths:
> 
>     -I $(srctree)/$(src) -I $(objtree)/$(obj)
> 
> ... become meaningless code:
> 
>     -I $(srctree)/ -I $(objtree)/
> 
> Add these paths only when 'obj' and 'src' are defined.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202404170634.BlqTaYA0-lkp@intel.com/
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
> Changes in v2:
>  - New patch to address the build error reported by 0day bot

Reviewed-by: Nicolas Schier <n.schier@avm.de>