Received-SPF: pass (google.com: domain of linux-kernel+bounces-170926-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Zhao, Yan Y" <yan.y.zhao@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "seanjc@google.com" <seanjc@google.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"luto@kernel.org" <luto@kernel.org>, "peterz@infradead.org"
	<peterz@infradead.org>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"hpa@zytor.com" <hpa@zytor.com>, "corbet@lwn.net" <corbet@lwn.net>,
	"joro@8bytes.org" <joro@8bytes.org>, "will@kernel.org" <will@kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>, "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 3/5] x86/mm: Introduce and export interface
 arch_clean_nonsnoop_dma()
Thread-Topic: [PATCH 3/5] x86/mm: Introduce and export interface
 arch_clean_nonsnoop_dma()
Thread-Index: AQHaoEbP2GjyTtCjMk25/ApsokAYHLGLc5rg
Date: Tue, 7 May 2024 08:51:31 +0000
Message-ID: <BN9PR11MB527617EAB9BE91A730AC25A28CE42@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240507061802.20184-1-yan.y.zhao@intel.com>
 <20240507062044.20399-1-yan.y.zhao@intel.com>
In-Reply-To: <20240507062044.20399-1-yan.y.zhao@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1cipisVsgaOBs/exN1S+jatl/Mb1r21Oidx9xjaKm+i1m+uv7LYP4jYMzoT3?=
 =?us-ascii?Q?Y3U3r2h0RwIUcgxDvQn5vYjjpPbUX4X3e9Rtk9kSd6URNZV8o6CNCbDw86CK?=
 =?us-ascii?Q?U4B0ITt6kCNHNQuWSAR2yVgliWXCwa5Q6F/E9vFx7PSABQqgEUzVBzJq65mB?=
 =?us-ascii?Q?IH0DPoVSReeInwQS04sd4YH3WgOJ/TJXPEZsJXfEb93bu89pN18aTwU89kow?=
 =?us-ascii?Q?vFH+YyYN4HqVBOwI42RNhXn0OC05zTS94XVSZvFvJ5nDHhH2hLb2tmOJjj+E?=
 =?us-ascii?Q?v4+m1+R0qoq6bOV7S05b8j8KfvujBBwlDMQ9Tlx22Z8cXyaTNolBUypm2/Xq?=
 =?us-ascii?Q?IgOErMwYjmt/BZIOPGSpX6KyJQwp44HAJvffNvhJ/u6iBAzGBYR1uU4x591A?=
 =?us-ascii?Q?l6fQo94lT+qRaKvPz2uAOahHNLo9eshdGMJbITsbybTbUPRrpD7Lqpc9LDWd?=
 =?us-ascii?Q?eWfjU20hH0ayWTpXKvjH/l3nkWiALQz3ARRY1wGWGY/HC2GsQch8mIw8kDQc?=
 =?us-ascii?Q?2GvWQGVUcp6PLYz48rmjnI+0UPp3i/F2cp7Xe1zScGX1Ee07DGrbpR93FLkX?=
 =?us-ascii?Q?dd49wL0UV0xv3wKXFTxq2mtUIi8LKnLL9ebOqEvUClGKcQreysx9TG1MRGOw?=
 =?us-ascii?Q?Vvp0qQaYrrRCRc6j4yQIAlXGd0OvHh8jGxZTYut9AqrLLfJV3S9V7JGTcQKt?=
 =?us-ascii?Q?QmDg/u7L4EoEV98comos5n2dS8cogXqx2rgqWqBb8bGFJMs5ZrzPeRxGjS8S?=
 =?us-ascii?Q?QgFxwrk3khoH9YYtGJyw/E0qt08xKGuPPQKIsURih4BW0mph/X8HnGctl3/H?=
 =?us-ascii?Q?43KuBiLx8Jys3oNI2uYMxY0qwb6ZZRzkURLsyED+3nc9+6pYLpCLOJ3lOvel?=
 =?us-ascii?Q?S5EJ9LmHg321aqo303MxS5ohejfu74GoRp5paUsYBN80CnRcs3bZ0NMGSLYE?=
 =?us-ascii?Q?OSGVqF8TuXOBlahUY92JllG5Y1mSx2VHKPF35NsR7Dgj09zPO74GH/G3A9s6?=
 =?us-ascii?Q?SRYUM3G0dJqT/xx01bSuUrteq2l4k9PsBq/1s1l0RThHToL7t3zIHPKfqqTC?=
 =?us-ascii?Q?5l8ZnihMQyLe/fqjz/dsngURzdQi6WqNcD5eLV3GZRCZD/Gb1ZAPb6kO+y7j?=
 =?us-ascii?Q?fnL0YGvlPmp3lEKS/LR4R0R5Bg73vWh3iq2DYrC7GXnazk1bOUvm7KZXiUXl?=
 =?us-ascii?Q?N5sy2b3Ck14zgikThacIq1msumPVnPGtJGGh5TMUAQVJDRn4I8IHZyLDED61?=
 =?us-ascii?Q?NLhRHs8b8WWvD4D43RTPH9GzAI8HXoSYdgBmNzIv3sYYuzAF393yWXUWcmgG?=
 =?us-ascii?Q?NxAJF68XXQvZlxaVlw0a1BiD+KRIzhjtnJRyUxD9gFQpXwiMwoAfSWmTOidz?=
 =?us-ascii?Q?IGUmFo3811dqf2xodRE6DVwzpviNv88SR9NYDWhku0WQmeNN9GQc/ramWDON?=
 =?us-ascii?Q?YBPYnP/QfHWL29OeisuFx5UXK+DltWKY19VagZbiB/lXeaPFl1foVIwBKS7B?=
 =?us-ascii?Q?8n+IxSWjJsjzGqF0UpMnaqLrvs+C+PmGMsQFRzmVJAZVgz8Kk+9mendFG+Zj?=
 =?us-ascii?Q?OtFoDPCtpzwyb39oFQ80vvgO72NkTcQJwnG2WHwb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 546c340d-68ca-437e-1baa-08dc6e72e44d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2024 08:51:31.4742
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hvvaUkuqrgcJjKDUThqzrZGuliG42JTR8o9mHyu6MY9h8sfnVYD+YgJ33kidnCR89DwiPKGyXmM8vh/YYgI2Iw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7960
X-OriginatorOrg: intel.com

> From: Zhao, Yan Y <yan.y.zhao@intel.com>
> Sent: Tuesday, May 7, 2024 2:21 PM
>=20
> +
> +/*
> + * Flush a reserved page or !pfn_valid() PFN.
> + * Flush is not performed if the PFN is accessed in uncacheable type. i.=
e.
> + * - PAT type is UC/UC-/WC when PAT is enabled
> + * - MTRR type is UC/WC/WT/WP when PAT is not enabled.
> + *   (no need to do CLFLUSH though WT/WP is cacheable).
> + */

As long as a page is cacheable (being WB/WT/WP) the malicious
guest can always use non-coherent DMA to make cache/memory
inconsistent, hence clflush is still required after unmapping such
page from the IOMMU page table to avoid leaking the inconsistency
state back to the host.

> +
> +/**
> + * arch_clean_nonsnoop_dma - flush a cache range for non-coherent DMAs
> + *                           (DMAs that lack CPU cache snooping).
> + * @phys_addr:	physical address start
> + * @length:	number of bytes to flush
> + */
> +void arch_clean_nonsnoop_dma(phys_addr_t phys_addr, size_t length)
> +{
> +	unsigned long nrpages, pfn;
> +	unsigned long i;
> +
> +	pfn =3D PHYS_PFN(phys_addr);
> +	nrpages =3D PAGE_ALIGN((phys_addr & ~PAGE_MASK) + length) >>
> PAGE_SHIFT;
> +
> +	for (i =3D 0; i < nrpages; i++, pfn++)
> +		clflush_pfn(pfn);
> +}
> +EXPORT_SYMBOL_GPL(arch_clean_nonsnoop_dma);

this is not a good name. The code has nothing to do with nonsnoop
dma aspect. It's just a general helper accepting a physical pfn to flush
CPU cache, with nonsnoop dma as one potential caller usage.

It's clearer to be arch_flush_cache_phys().

and probably drm_clflush_pages() can be converted to use this
helper too.