Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp399849lqh; Tue, 7 May 2024 02:40:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXUS++4RPGBl4sBQpbKk9pZwYObhkBcb7ZhVyzm2/1HgIXJrE83kUA4rvJHEGqd1DMrZBfNG5nYtqF4EiZP15ZpMyypOg4gU/67eA93Fg== X-Google-Smtp-Source: AGHT+IFgMzmvrAZlIX0KnDYCpJReUJ/WJG7EUKksjk3VrgL4lra6N1iB5wrOqteTXqoiM8NV+Nra X-Received: by 2002:a17:902:da87:b0:1e2:1915:2479 with SMTP id j7-20020a170902da8700b001e219152479mr15781675plx.12.1715074801096; Tue, 07 May 2024 02:40:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715074801; cv=pass; d=google.com; s=arc-20160816; b=0zwpduOmYUwt/2DlvAtGWSZ9GwIpQKXty/6zVsiFmrF1wt7RuysL9EUnl8fsRGRW1u 2/J16hfHbkyN0edtMmQi0LemWpjNOSqcJw1TgWWrTl169Xwx89g9415Eb/XRtgGNpVcF Ld9AUd1poPKdKQlmRPo0ioDZIFxq22rOzGI5nPD3tucXw4GUkuRo7WgVa9+NJ0O2I1aX q0Y8vDY5BMqwqD3r7kU8/DJV/iWh/5V6+yjS2sEZvs01S/NpibQ5mjBXMqho4v0aVEs8 ywWJhgpxcCvtsazbDnS3CGGv7EJ7Ya2l/RKXDLkIjbTNEpR+qyk2MGMc7n3VIq2asBKu Z0xQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=uarDHQ+a07tcRKI28LofQYYCslRlvc1XjILv15IA6C8=; fh=Ji9BNxyQ5mT1+hnoFSNelN9L/UVu7jJ2wDCFWGX6lW0=; b=YCWxbZnEd6rCeUewSpwnz3umfD84pD3k94xcHLUhhMrChVo5HGcs+otjkLCDsQ0axH ZT1XxBzXqIGchxiYDPfZsM1Fk8wVFKQSgtGj0MsifWfZcY7LMnP/l6jJaXmRMi0ngq5W UJOvMBmXYPndi5Pl3MA5Ii2+wMIBHs8SDfXNMDnuehjzH5VZEfkvFykd1xovuBS2PUfq 9LbyalQwFmydq+kC3oyEJlKP0z0floiogmRMI+igzgP2NrF2oBTVeTWuAg7u1l1p5biP +IuPhz+JdN067YssCHu7hnXtR4aAwDDIcqLCXiIpqZ5YtwtD7itQ8p2cBWKVyiM0t34w ZbvA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=PziktTF1; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-170955-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170955-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id lq14-20020a170903144e00b001ec59e6f982si9985385plb.160.2024.05.07.02.40.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 02:40:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170955-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=PziktTF1; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-170955-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170955-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 915C4B23ECF for ; Tue, 7 May 2024 09:34:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C1D114D71E; Tue, 7 May 2024 09:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="PziktTF1" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 476345B1E0; Tue, 7 May 2024 09:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715074490; cv=none; b=F75cbIW8OD/CRvYw+6dM84BCdOQMakwZcUUf/BxhCqUL2Z4dd6qLKfgpMYrff3bUnImd8ha+wX+TXX2xbXBCpTokGqhknj48OySLQ7SdXrBbWfIBngQPYYaawt8AAuZxAxdq8cN35dIjDKw6Uj9ElgmXu3Q7pDR/AELq4oxE79s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715074490; c=relaxed/simple; bh=ohWuVrllZ49t4dkKQwrO5nd7MUNrk39VX+83CHV8kf4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kvskUdRX+RmvHNDeTrKyi8UtdaF7Gkkng3DV+krEUlJ7b05uswW605uGDz9hybnr0eppkadHvaLUlL62aoTPv4ffAJ0D5JukwZiDgtm6AGCjo1Kohug+2O/c5K12fHEdHA1V7Lz/wx8xEiZ2l/T1Wl7dz+zL7kwiXMleEdmEFR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=PziktTF1; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uarDHQ+a07tcRKI28LofQYYCslRlvc1XjILv15IA6C8=; b=PziktTF17Jc8u09/HMPR5DU/yy zsrmYUqA5oWzK7ZXjFEDfMSDi9mTS9r/VZuTc/Nmg6YvkyLNcaPCsO7RToY6boQVSm0Zr5665Op5d xQIGFlpmsEmgs4Vjo70G32RTwxNTDY7rQAznZ76/NlJOd7Jo09ese7Py2HSAEP3SYJxfnE5sQqSyw 1ENVU4Tv8sD0poPrbuBmD3yZmb/8UrWg0UMmHhuuAcOwX1dS8wa57sY4Jn5qZWMZDS8NrDiL5OP7T UfIRvmHYa8ILi911uHTFxX/uK3gcoqHaVb6eM+R1FcOZy42XV+llzS856N2PY6T/DBgNvlQ0dQmjw CCFuvLaA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46068) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s4HDe-0003VG-1C; Tue, 07 May 2024 10:34:42 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s4HDe-0000Da-Sh; Tue, 07 May 2024 10:34:42 +0100 Date: Tue, 7 May 2024 10:34:42 +0100 From: "Russell King (Oracle)" To: Marek Szyprowski Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd Subject: Re: [PATCH] clkdev: fix potential NULL pointer dereference Message-ID: References: <20240507064434.3213933-1-m.szyprowski@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507064434.3213933-1-m.szyprowski@samsung.com> Sender: Russell King (Oracle) On Tue, May 07, 2024 at 08:44:34AM +0200, Marek Szyprowski wrote: > dev_fmt argument is optional, so avoid dereferencing it unconditionally. > > Fixes: 4d11c62ca8d7 ("clkdev: report over-sized strings when creating clkdev entries") > Signed-off-by: Marek Szyprowski Please put this in the patch system so it can be merged along with the change that created the problem. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!