Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp407481lqh; Tue, 7 May 2024 02:55:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXl2oEK9KKJhgIo4tepRyn9knfFeZ38QDzyqodWlcrxaYX4sAWMcADHsAA6bLdJMRx+kN7wGIPeLsnX6IZSG3E3clBdguqeamr9Tv58vQ== X-Google-Smtp-Source: AGHT+IHgHpjfR74UudcD/banabXHkpxF3gY/+Tx8HXX6/YT2xM4EorX/4Swty5bzYlT3aqhX4dIm X-Received: by 2002:a17:903:11ce:b0:1e2:6b5d:5b18 with SMTP id q14-20020a17090311ce00b001e26b5d5b18mr14675890plh.51.1715075741473; Tue, 07 May 2024 02:55:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715075741; cv=pass; d=google.com; s=arc-20160816; b=n8Z1Nm1dsBTG2YR8XT7letPX0SE5uHYwuItnknLj3fnEfSdnD0PbPDmbTpIlZpSY55 aIf03GuCOjKEz/h/Cp08FV2apxFOrGXPzlgCVFFGudlDP0FOKhUbhdiwpWyWMP/siGA5 z2+ndBPOGVInjlQzrtcec7tuQ/f7Q2lWeKaM2jnMIuX1wIdtmbtFcRjaTCDbu76AoZRD d+XB2eMqp/oxCktt9xjpj5ecmQGcVCrYiATP8Lk+qeI/70Qj7bQoedoe1T6ZL7mTBAtv GOBERweXnr/URGlWFNS6ukomL2HYFyNVdnOAtID21+CP75jEkn7qBZgDBynRt8KWPyeW a8rg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; fh=u7aQT3rZkO7I4HilkZshr0G8m8SbG8Aa+ab8yYHJYG4=; b=Kat+0q7bv+2gzpUT0SDKbnZdiDegklvyTPugFJXwXK9WU2K6lPAfaK8UAWW1AJX1Eb fouizzi6vip6MhasQbqYGdnH0CYc6wy8irMrxAFYjz6X1DYAP922lfe3pMH0zIvzkSiL 3RuVQVXV68fWo9WhZtIc3bsJYpfcHHURudB89u+AL0FuCaZu/qrm26MX3L+7Yk3pEOJB COq6wYKBbViM61j9UvTsVOC3WidD2nyisfB8JQtyDq/L7yYFqGSa6uj0dU7WXesRCP1z 4AjaeFtL0iSu3pAqF5UehxATpqtANIrMqC99fiIlfdssRvIdUojUjoCuukZ4oby8+23N 2S/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Uryey6GD; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-170721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170721-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id f10-20020a170902f38a00b001ec888aaa0csi9704981ple.192.2024.05.07.02.55.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 02:55:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Uryey6GD; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-170721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170721-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C234EB214F8 for ; Tue, 7 May 2024 06:03:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 341E06F514; Tue, 7 May 2024 06:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Uryey6GD" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 479216EB64; Tue, 7 May 2024 06:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715061820; cv=none; b=iUqTEegnrONlooXn2Vi5PCbEid//aab2DGADS0WYFKiXe/3hj8Tn3vtu+oyVyy8PadH9r0C5BmjetYcMDEqLYo8BE+chK2Q2OKqCIkICk0dB3EwlA4pqXKwRCtKxraGbIOjsFJpSMtVCsGn9pVnQ4lBjTR8elcwzKGi9UmEejEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715061820; c=relaxed/simple; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LYCyutxXwAvw4K2b/qGNTAsD3wgcs+3dFHAY8bNqi5xz6xe989xX97QXPBPIXfbKzdCcjDzRL4yFpKtzd91/Gp2saNalZaAwN4j7QTNGhAmSCSAlNcHJyHY6xK0VzY7NEtX7RNVeJA2XGDoCiHlykxcbQYibMNxu5IgSLgrBXvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Uryey6GD; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=Uryey6GD11lPVH6uKp2mvVDXCU ebXu+gisRG/OtIzlS61flD5X11KVvB2XE1kWBdTr4S20z6fEWjVDA3r3EEKy0VWQpmtGPJzk0jviA eRfAIWi4sT6hwMTx0OFpPRC7wzkKhWIjOrfpNeuuyZBRYXPPNLIhmJvbPrEWI07ZAVnGiRFlfghbv ULoaSL5/QRw7Kv+6cFLC5cn0j5nJuYMTCM2KOCmw4JeUVworGeSAzOOFO/mfSJ5KFkJnBY65MbukD 4VTXK2d7v807eKrz+VuCDON3ui0nUlnrUx85R4jobCa+Z43jZRvR8n2PzWak4Kb60eMr+LSRjyX49 lZpOMyTg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4DvN-00000009lxv-2YkQ; Tue, 07 May 2024 06:03:37 +0000 Date: Mon, 6 May 2024 23:03:37 -0700 From: Christoph Hellwig To: Justin Stitt Cc: Jens Axboe , Nathan Chancellor , Bill Wendling , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v3] block/ioctl: prefer different overflow check Message-ID: References: <20240507-b4-sio-block-ioctl-v3-1-ba0c2b32275e@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507-b4-sio-block-ioctl-v3-1-ba0c2b32275e@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Looks good: Reviewed-by: Christoph Hellwig