Received-SPF: pass (google.com: domain of linux-kernel+bounces-171083-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: Jinjie Ruan <ruanjinjie@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq/irqdomain: Clean code for __irq_domain_create()
In-Reply-To: <887d424c-c6b5-e5c7-21d3-9b920272fbc3@huawei.com>
References: <20240430093353.1919862-1-ruanjinjie@huawei.com>
 <87pltyrf9l.ffs@tglx> <887d424c-c6b5-e5c7-21d3-9b920272fbc3@huawei.com>
Date: Tue, 07 May 2024 12:22:12 +0200
Message-ID: <878r0lrkff.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Tue, May 07 2024 at 09:22, Jinjie Ruan wrote:
> On 2024/5/7 2:01, Thomas Gleixner wrote:
>>> +out:
>>> +	domain->flags |= IRQ_DOMAIN_NAME_ALLOCATED;
>>> +	return 0;
>> 
>> This function is horrible. The only shared thing here is the
>> domain->flags manipulation. I'm not seeing how this is an improvement.
>
> Yes, the IRQ_DOMAIN_NAME_ALLOCATED flag is shared, the purpose of this
> change is to make the code that allocates the domain name in the
> __irq_domain_create() function look like it doesn't take up too much
> space, so it looks cleaner.

I'm failing to see the cleaner. All this does is shuffling code around
for no reason.

Thanks,

        tglx