Received-SPF: pass (google.com: domain of linux-kernel+bounces-171141-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 7 May 2024 13:50:36 +0300 (EEST)
To: Mika Westerberg <mika.westerberg@linux.intel.com>
cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, 
    Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, 
    Rob Herring <robh@kernel.org>, 
    =?ISO-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>, 
    Igor Mammedov <imammedo@redhat.com>, 
    Andy Shevchenko <andriy.shevchenko@intel.com>, 
    "Rafael J . Wysocki" <rafael@kernel.org>, 
    Jonathan Cameron <Jonathan.Cameron@huawei.com>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 7/8] PCI: Make minimum bridge window alignment reference
 more obvious
In-Reply-To: <20240507103656.GA4162345@black.fi.intel.com>
Message-ID: <11515b48-6cea-f71e-4ecc-d683ee46bc93@linux.intel.com>
References: <20240507102523.57320-1-ilpo.jarvinen@linux.intel.com> <20240507102523.57320-8-ilpo.jarvinen@linux.intel.com> <20240507103656.GA4162345@black.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-558912366-1715079036=:7551"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-558912366-1715079036=:7551
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Tue, 7 May 2024, Mika Westerberg wrote:

> On Tue, May 07, 2024 at 01:25:22PM +0300, Ilpo J=C3=A4rvinen wrote:
> > Calculations related to bridge window size contain literal 20 that is
> > the minimum alignment for a bridge window. Make the code more obvious
> > by converting the literal 20 to __ffs(SZ_1MB).
>=20
> I think that's SZ_1M not SZ_1MB :)

Of course, that's the only place which is not checked by the compiler so=20
it's the place where I type it wrong and forget to use backspace. :-)

> > Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
>=20
> Looks good, may be even add a #define for this but either way,

I considered that but I could not find a good name for the whole construct=
=20
(with the __ffs() I mean). Perhaps PCI_BRIDGE_WINDOW_LSB could be an=20
option but that feels somewhat clumsy to me.

--=20
 i.
--8323328-558912366-1715079036=:7551--