Received-SPF: pass (google.com: domain of linux-kernel+bounces-171164-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-443-g0dc955c2a-fm-20240507.001-g0dc955c2
Precedence: bulk
MIME-Version: 1.0
Message-Id: <39139c19-cf91-4e25-a52b-876d0880f5ed@app.fastmail.com>
In-Reply-To: 
 <58005595a05ef803b454b78d3ae9b8ee0675bd5d.1715076440.git.geert+renesas@glider.be>
References: 
 <58005595a05ef803b454b78d3ae9b8ee0675bd5d.1715076440.git.geert+renesas@glider.be>
Date: Tue, 07 May 2024 06:59:57 -0400
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
 "David Ober" <dober@lenovo.com>, "Wim Van Sebroeck" <wim@linux-watchdog.org>,
 "Guenter Roeck" <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: LENOVO_SE10_WDT should depend on X86 && DMI
Content-Type: text/plain

Thanks Geert,

On Tue, May 7, 2024, at 6:07 AM, Geert Uytterhoeven wrote:
> The Lenovo SE10 watchdog is only present on Lenovo ThinkEdge SE10
> platforms, which are based on Intel Atom SoCs, and its driver relies on
> DMI tables.  Hence add dependencies on X86 && DMI, to prevent asking the
> user about this driver when configuring a kernel without Intel Atom or
> DMI support.
>
> While at it, fix the odd indentation (spaces instead of TABs).
>
> Fixes: 1f6602c8ed1eccac ("watchdog: lenovo_se10_wdt: Watchdog driver 
> for Lenovo SE10 platform")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/watchdog/Kconfig | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 24dfecbb30157fff..f002e9627c076f1f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -255,14 +255,15 @@ config GPIO_WATCHDOG_ARCH_INITCALL
>  	  If in doubt, say N.
> 
>  config LENOVO_SE10_WDT
> -        tristate "Lenovo SE10 Watchdog"
> -        select WATCHDOG_CORE
> -        help
> -          If you say yes here you get support for the watchdog
> -          functionality for the Lenovo SE10 platform.
> -
> -          This driver can also be built as a module. If so, the module
> -          will be called lenovo-se10-wdt.
> +	tristate "Lenovo SE10 Watchdog"
> +	depends on (X86 && DMI) || COMPILE_TEST
> +	select WATCHDOG_CORE
> +	help
> +	  If you say yes here you get support for the watchdog
> +	  functionality for the Lenovo SE10 platform.
> +
> +	  This driver can also be built as a module. If so, the module
> +	  will be called lenovo-se10-wdt.
> 
>  config MENF21BMC_WATCHDOG
>  	tristate "MEN 14F021P00 BMC Watchdog"
> -- 
> 2.34.1

Looks good to me. And apologies on the spaces being wrong in the first place.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark