Received-SPF: pass (google.com: domain of linux-kernel+bounces-171185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b98d71e7-9b0f-4c8d-4c90-d1cc1eb730a2@huawei.com>
Date: Tue, 7 May 2024 19:17:35 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH -next] mm: memcg: use meaningful error code for return
 value
Content-Language: en-US
To: Matthew Wilcox <willy@infradead.org>
CC: <hannes@cmpxchg.org>, <mhocko@kernel.org>, <roman.gushchin@linux.dev>,
	<shakeel.butt@linux.dev>, <muchun.song@linux.dev>,
	<akpm@linux-foundation.org>, <cgroups@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
References: <20240506133643.1124102-1-xiujianfeng@huawei.com>
 <Zjjg60ZW-d7r-DS9@casper.infradead.org>
From: xiujianfeng <xiujianfeng@huawei.com>
In-Reply-To: <Zjjg60ZW-d7r-DS9@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 2024/5/6 21:53, Matthew Wilcox wrote:
> On Mon, May 06, 2024 at 01:36:43PM +0000, Xiu Jianfeng wrote:
>> alloc_mem_cgroup_per_node_info() returns 1 if failed, use -ENOMEM
>> instead, which is more meaningful.
> 
> This should probably be changed to return true/false instead of
> an int.
> 
OK, already sent v2.