Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp456749lqh; Tue, 7 May 2024 04:43:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUow2vTL3UWQwdGnv6knsr3ubFSL3o16rbvKZcWEXD6pqzuW2lbdCVkwfqTHYM6aU/VXXTjKMN0AqoyRGtdjn5fwUwx1m2hKjDB04udBg== X-Google-Smtp-Source: AGHT+IHiG8PMATEOTyY84woNq4Sx891qK5qaatsSMr3ZyL97rqh9Q3JtWqLZnKG6gpKSFqy8pEZU X-Received: by 2002:a05:6870:c0d4:b0:22e:f3cd:b69e with SMTP id e20-20020a056870c0d400b0022ef3cdb69emr14589769oad.54.1715082225889; Tue, 07 May 2024 04:43:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715082225; cv=pass; d=google.com; s=arc-20160816; b=e3cWNF8KFOEGPcb689KVZEab/EAS0CC5kafgvtUjmX14lChg5PYYmde0/aXcI5ePOp Fx2foDmyJ19hDzOFniTQZY05zt3aa/lc89kCC9G4gOCd1Fx4jbH1x/AYDxjzPvlsX7YL 3lTsbn+CsMSGYdvK7u54Wt27AOAU3kMWcv/zDMianMmDTYw3EQq2lW8htZyRi8Vkul/5 cmG9M37tBZFBP6nCtXFYcBXPfakYVTv8dDYUrb/1c5lfyQRxBTLOn+ZQ+4O+81QruSD8 0nTKn3RMahezNHtmp4QVecdKYNFJAJjVeNQZfDuGyV+ubPUzeSKs7HEljpXqIIkM1Njd JktA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=n8U5Uc/ahU44+LRrdcNd3RNaR49dcnf3S9OFWjvtOoY=; fh=W8K204swOIBxT2IoxJXHCy1PwuXDWBT+c9Ef+jFrLgY=; b=jYJPZ3hjuo4AR0llOlRtaMzgQ+YH48M7LvdUTAlPz3yeGSdbTmm8gWw0bRRW8Zhw71 xHVkQlck5WG2dn2cuVm/tgU3N+cJ0e46eqxj1ATdLr/LvvR0htAAHEzUcY1QadhVCQ9i GbLQ5xwkGPdWBTHi0p3MAkmijr9ThWtVJf/Y7HK9g/ULxKSaHkTtfEZsPYl2H2scsGfY WDr/27x4mn4ef6H/xkYQEnk2yyglYmhDWPMIfI3GV2noj+320rOXqPZ2rLUzjUetYbWE 5yPJgIUvBD0+NLtOBZTiPuyBdyBHPY+H2TYZdM3QnJTQrIWp5D//yfnWuy30zHrPJJHO ROTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=YJqu5DHm; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-kernel+bounces-171213-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171213-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s24-20020a639258000000b00622977187a7si5811260pgn.298.2024.05.07.04.43.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 04:43:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171213-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=YJqu5DHm; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-kernel+bounces-171213-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171213-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 82389287A98 for ; Tue, 7 May 2024 11:43:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D80C9156C76; Tue, 7 May 2024 11:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="YJqu5DHm" Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 359C715252F; Tue, 7 May 2024 11:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.4.11.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715082205; cv=none; b=LSG1rnuOHJWrkLzxEkBbeF6WTZXOKrIMvpWsOGygnGu5xviyWvZ/+En0sapc4HVviG5bjSEc0Pt7zB75IOCDzsFvaXMHTQEERRltvTq14iC0P/IJvrwCThQvs61RMBy4WW6OzoI5V3kdByKaAA5iyFf8MQmDufWZl/dHBgWBlDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715082205; c=relaxed/simple; bh=n8U5Uc/ahU44+LRrdcNd3RNaR49dcnf3S9OFWjvtOoY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZvmFkey6dhQtoig3tcMZClxZkzA3NCmLuUGwqaTGZGqXPcU+azmwSltS0fEouf407SEYsjuZXzA6zcFP0LjgCuZcQkAtqPb8jilJxybkP40ryeM52iv0vlFksLN1fdvstw0Vo680kSXWqptkWjpDiIjwp1s5kNBT3TdY7J0nrpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name; spf=none smtp.mailfrom=nbd.name; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b=YJqu5DHm; arc=none smtp.client-ip=46.4.11.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nbd.name DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n8U5Uc/ahU44+LRrdcNd3RNaR49dcnf3S9OFWjvtOoY=; b=YJqu5DHmoDQFv2SpdJ+AHK0JCa PK6XiFL+xqIZ2xm8Om2sajRj6UVCtyD58LD0kqJfwX429IL8FIP2ysZFT9sMBXA+QNK37DiWyXDum n9lfobOvUPZ5zQWt6i5Gx/fYcS9n64cIMBMCFFypzQC12ofAA3RaZACqsIRkrNshrQFI=; Received: from p54ae9c93.dip0.t-ipconnect.de ([84.174.156.147] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1s4JE0-00EKxy-1x; Tue, 07 May 2024 13:43:12 +0200 Message-ID: <4bcb2be8-d769-4972-be9b-c7798f50f207@nbd.name> Date: Tue, 7 May 2024 13:43:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXTERNAL] [PATCH net-next] net: add missing check for TCP fraglist GRO To: Suman Ghosh , "netdev@vger.kernel.org" , Eric Dumazet , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Willem de Bruijn Cc: "linux-kernel@vger.kernel.org" References: <20240507094114.67716-1-nbd@nbd.name> From: Felix Fietkau Content-Language: en-US Autocrypt: addr=nbd@nbd.name; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCeMncXpbbWNT2AtoAYICrKyX5R3iMAoMhw cL98efvrjdstUfTCP2pfetyN In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.05.24 13:33, Suman Ghosh wrote: >>---------------------------------------------------------------------- >>It turns out that the existing checks do not guarantee that the skb can be >>pulled up to the GRO offset. When using the usb r8152 network driver with >>GRO fraglist, the BUG() in __skb_pull is often triggered. >>Fix the crash by adding the missing check. >> >>Fixes: 8d95dc474f85 ("net: add code for TCP fraglist GRO") > [Suman] Since this is a fix, this should be pushed to "net". No, it is fixing a commit that was just pulled into -next. - Felix