Received-SPF: pass (google.com: domain of linux-kernel+bounces-171218-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240506140906.26034-1-tiwai@suse.de>
In-Reply-To: <20240506140906.26034-1-tiwai@suse.de>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 7 May 2024 13:44:51 +0200
Message-ID: <CAJZ5v0g0gaHQ1VxKgJYZTyEEd3foQXm315eWFoOM2U8mZpCQgQ@mail.gmail.com>
Subject: Re: [PATCH] ACPI: video: Add backlight=native quirk for Lenovo Slim 7 16ARH7
To: Takashi Iwai <tiwai@suse.de>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 6, 2024 at 4:08=E2=80=AFPM Takashi Iwai <tiwai@suse.de> wrote:
>
> Lenovo Slim 7 16ARH7 is a machine with switchable graphics between AMD
> and Nvidia, and the backlight can't be adjusted properly unless
> acpi_backlight=3Dnative is passed.  Although nvidia-wmi-backlight is
> present and loaded, this doesn't work as expected at all.
>
> For making it working as default, add the corresponding quirk entry
> with a DMI matching "LENOVO" "82UX".
>
> Link: https://bugzilla.suse.com/show_bug.cgi?id=3D1217750
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  drivers/acpi/video_detect.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 9fdcc620c652..2cc3821b2b16 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -497,6 +497,14 @@ static const struct dmi_system_id video_detect_dmi_t=
able[] =3D {
>                 DMI_MATCH(DMI_PRODUCT_NAME, "82BK"),
>                 },
>         },
> +       {
> +        .callback =3D video_detect_force_native,
> +        /* Lenovo Slim 7 16ARH7 */
> +        .matches =3D {
> +               DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +               DMI_MATCH(DMI_PRODUCT_NAME, "82UX"),
> +               },
> +       },
>         {
>          .callback =3D video_detect_force_native,
>          /* Lenovo ThinkPad X131e (3371 AMD version) */
> --

Applied as 6.10 material, thanks!