Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp475339lqh; Tue, 7 May 2024 05:18:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW9yFwPDJgEesFPSO5LF+66nKH0F4r1eZGsfgC1sNLuuaGtAyNEcVPfygVUP4N6TJnEG8Ghtk6bKWak+LgqVhL3fNyHqi2aSla6f6JRBg== X-Google-Smtp-Source: AGHT+IFYVxh+UBLVhQHYog91uepv9O5Pe5SXGcVh37xOYZxyD0br5kHQCmgc/LxhNkMwwXiDSvIf X-Received: by 2002:a17:902:ea0b:b0:1e4:31e9:83ba with SMTP id s11-20020a170902ea0b00b001e431e983bamr15270913plg.1.1715084324282; Tue, 07 May 2024 05:18:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715084324; cv=pass; d=google.com; s=arc-20160816; b=EK1WNzIvw0n2tBAWL0HYNuSpOyDqDQehdm8lJmTSsM1IsVeJ+yv/t0+/izE3+R9QB3 CimG5w+UgW0LjCliKaK6zP0mvOxUAKKTP9HiflrYPOKU1XMIWD6IGawgFvPIxKul+Gc/ xO7l508khOjoaK7g3kXLRYMXNW9ESWFm+qiZxSabDmz7OlrIsFiu/jDPDoTiGCo+RNHZ EC3MBZVl42wxaNs/FNermrn6STDKJiHZughKdsGNMOX76ooNbzrUDEcf7U/y0krJfpWy F5VvKCB/zNibbbIkQWOnK+9PAe4p/J3nTcULR+uwutVixfSYfVRJ4566+IquQz1M7qCL IyQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sQM7rZP+pwd6y8h6SxqC2oyGkTbPvL7xGJBN4HpKr/I=; fh=whn9FzAUpcQHAO/XwFto8bLvZ06m1nt89vGGqEVvpEQ=; b=IzWSz9EmRzzqQ+Crb/MtQjJSoEFex2fOnyeL7/P9LFwkKGxTSJERVdTKjmRt5WUYYW YSCq/nraajpfEajpli9hq4ePZyXJWaec2DUbXA2wVCUjklC5PswUSarT5n9FIM/77Pqj oUZtpM5SFBeB34+KHx2yP8dHYczdauNHVdx7oGWdHhUfNNPzwxSyQdGTbDWvUmCta3vf dL2CymYj/8w+JX3JeJN1TOXqHCVk/URFtXfdE9a6tvV/ZIcu0G8SIka7kIyFg8oKuc1V c+I4R+p4aFI+uz5sPotwwM+My0anz1OeJN5Iy5f3/o7//opVu6Rs9GLCqw89MsimfK7N qFXg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=H+RObFUe; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-171253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171253-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d12-20020a170902654c00b001ed6868e26asi7318317pln.398.2024.05.07.05.18.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 05:18:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=H+RObFUe; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-171253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171253-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5125A288C2C for ; Tue, 7 May 2024 12:18:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC088158A30; Tue, 7 May 2024 12:18:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="H+RObFUe" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546BD156F23; Tue, 7 May 2024 12:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715084302; cv=none; b=G2wE5GD2/8PVnCy+qUrY2gn8dLGwor5PKvmSAeruGy0fdP8PZCQXeZQieFg8fDyHwv2V+iMlbS9iV6mbxjcjO4E9vX90dz3j1Thf21u3sZdoSSUSsFDW9yQD2kGcoB/Ujp/jHtTS4yzTG247/AlhkGLwLGiYFDbFIfsImAqn0M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715084302; c=relaxed/simple; bh=XaLCNAECeluzjka4Oi85rIiDsTD/ZdajAgV3Z6+v+7k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KsjIcKB2mWGqYh/HY/jdHoEqpefn6MscHY/Lu/UBCLVIYro70vZnNp7+T1DuprfbvravDJpEcpfv3nbBI1cB44Ej6FO/jmizqGea8TUqKWvVwMTLBpRsp0IAL32GUFbkDp21VvTlNRPsN6IMfYxYtkkBryu34GDpS3JaPo0WWM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=H+RObFUe; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=sQM7rZP+pwd6y8h6SxqC2oyGkTbPvL7xGJBN4HpKr/I=; b=H+RObFUegfuZ2TdyPCJN3rgdVf LUzOCqnzI7JHPLWff6XuRq2XbRFosmQyErR3l5CR9BWv4yBUbPYku0tQEO871ENmYWt4F51D+lkVW DvXnuPEA9tNUByoG/kXU6mPav+iVuexgWqHtCt7e6C+AigcqHgbXrYBwhJC4tRTnWpCA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s4Jlr-00Eqp4-Ak; Tue, 07 May 2024 14:18:11 +0200 Date: Tue, 7 May 2024 14:18:11 +0200 From: Andrew Lunn To: Matthias Schiffer Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com Subject: Re: [PATCH net-next v2 2/2] net: phy: marvell: add support for MV88E6250 family internal PHYs Message-ID: References: <24d7a2f39e0c4c94466e8ad43228fdd798053f3a.1714643285.git.matthias.schiffer@ew.tq-group.com> <0695f699cd942e6e06da9d30daeedfd47785bc01.1714643285.git.matthias.schiffer@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0695f699cd942e6e06da9d30daeedfd47785bc01.1714643285.git.matthias.schiffer@ew.tq-group.com> On Thu, May 02, 2024 at 01:13:01PM +0200, Matthias Schiffer wrote: > The embedded PHYs of the 88E6250 family switches are very basic - they > do not even have an Extended Address / Page register. > > This adds support for the PHYs to the driver to set up PHY interrupts > and retrieve error stats. To deal with PHYs without a page register, > "simple" variants of all stat handling functions are introduced. > > The code should work with all 88E6250 family switches (6250/6220/6071/ > 6070/6020). The PHY ID 0x01410db0 was read from a 88E6020, under the > assumption that all switches of this family use the same ID. The spec > only lists the prefix 0x01410c00 and leaves the last 10 bits as reserved, > but that seems too unspecific to be useful, as it would cover several > existing PHY IDs already supported by the driver; therefore, the ID read > from the actual hardware is used. > > Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn Andrew