Received-SPF: pass (google.com: domain of linux-kernel+bounces-171360-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <dfc2d0b4-3ff4-424f-8bdd-3e9bdedba914@intel.com>
Date: Tue, 7 May 2024 15:13:02 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2] lib: Allow for the DIM library to be modular
To: Florian Fainelli <florian.fainelli@broadcom.com>
CC: <netdev@vger.kernel.org>, <kuba@kernel.org>, <jgg@nvidia.com>,
	<leonro@nvidia.com>, <horms@kernel.org>, Andrew Morton
	<akpm@linux-foundation.org>, Tal Gilboa <talgi@nvidia.com>, "open
 list:LIBRARY CODE" <linux-kernel@vger.kernel.org>
References: <20240506175040.410446-1-florian.fainelli@broadcom.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240506175040.410446-1-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUk1T1A3ejJZdkc0WXJPcHhjaGo0Zk1kaEFzQSt6VndiOXNOd210cTFrU2g1?=
 =?utf-8?B?d0NYREJqd2pKNW5vOUVsT2xqZ1Jjb3FMbXpGN1V2WmRHMjYrWGhSYkhQblFq?=
 =?utf-8?B?U1lwdXZxb1dlRmxDbmxBSUx0TTcvM2VHN2plN1BJaDNRc0JwVWFURU53bWlE?=
 =?utf-8?B?Y0JRamtzUHREaTh4cmovK09relZSR2pCVC8rY3lTeE9LdkJ4bE94SzNGaWE4?=
 =?utf-8?B?UHMzbFc0T3FudnFzUTB6K1ZXS1FVYjd0OENlYkRCaVd3UGlkZnBuTk1nYTY3?=
 =?utf-8?B?cXlyY2RoVWNBOTd5cEJYL2hMR1R5NVM5a1NsYm5BUzVoQ2NiejUwU3cwSWxB?=
 =?utf-8?B?T1NvdlBuNHFET0ZyUUwwMm9ORUdZUHlITU5FU0FMZlRPekppRCtSK2Izd2hN?=
 =?utf-8?B?RU9BZERVM1pYRWdtOTJDMEVLUUxJQ3ZNM3g4VTkvVUc5cFZPa1lyQVdyUmRG?=
 =?utf-8?B?NldnMi8reTY3NWxGR01MV1JMMERkZUhrS0F3bzJ5eWVXNUQ4TnpIbXVxSm1y?=
 =?utf-8?B?MW5sTGhYNjhCOUhvamVXTFVRWXJQN2JsaGNPU2N5K3IzZTBTcG0rK0JvYzZ0?=
 =?utf-8?B?TEtaY0pLd1JjYmtMSFROcUlqRHhOSFhKY2ZobWRMWWpvd2ZOaDlQYVNQNFBx?=
 =?utf-8?B?eFdHY0E1NW82dHNKd3Rkalp4SGk0d2FTODE4dndCdlZzUjdVYXFnYkp6QTlB?=
 =?utf-8?B?WktNcW9ES2R2eHJxR2VNdjVadVRzN2o1Nk4yUFJTcTZseVVXaENLNkNWNUVn?=
 =?utf-8?B?bE45akpzNzBUNUJkRlJaNGpJa1JkTjRIYlc5TUNGUW9TTEdmQVk3ZEROYUcx?=
 =?utf-8?B?M2lXUmUzOE1iZXlVMXVUZGhna25RTU02NklRQVpUTmF1MnIwWWlQWFhJRVEv?=
 =?utf-8?B?ZTVuWUpPU0JOa3NFT0hqaFJ3Umo0K1FQbUpMRzhXeS9VUytheUVUaEcvRW9W?=
 =?utf-8?B?WExtRTUrdFVaaXJBZ0d3Y3hmcUZjOGMyWDVDQTIvbUpSR21qN3ZFZ1NJeWN2?=
 =?utf-8?B?SjJEZ25MajE4MEJPbnR4MTdJaVdJVDRNaTZvemVmTWVLclFJQk9nSU1aYS9K?=
 =?utf-8?B?MWJMc3JNRi93U0lVcnlMN3REb1VNRXk2MTljcGRVeStESkdCTTJSZXdUYm9z?=
 =?utf-8?B?YlZSbGRRZzVVRE9vZmJPTkVwTVlIcW1QTldsNzdtYnorZ3loQ3NOWnNYV2RK?=
 =?utf-8?B?QzVFeTgzbDI5ZmxvWk1zQWp6MHBsVnFzaUNJUk01VzN1dVhuNHNkbStlVmtI?=
 =?utf-8?B?UDJyQjJNQmFQZmpTQ3V5QVN5RlYzQ1pDem5TRUhxdGhXVkRDa0N3UDMxcTJW?=
 =?utf-8?B?UERPdDVOMlptcnVkZ3h1Q0RLREdOM3BwL2duVFlKWUVFOTdBYTRNdDVDQXp0?=
 =?utf-8?B?Z3l3T0lvNTVBNTN2NFVwd09KV2svV0RXM0tJUWd6eWRwemRhTmZyQ1kzbEpT?=
 =?utf-8?B?OWhXVlg3a2NyVXRwWUdweVU3VCtSVXJXT0JldHJaSEVOaDl6SVJIejZJY2Fp?=
 =?utf-8?B?a1dYYzI0Tkh4bGI4dWRMdDNZYXpPeU5VQnNlOUdCK2tXTE9hYTlYS1RpMUk2?=
 =?utf-8?B?TmFMOC9ER1Jwa0VXK2ZYUU92WDVqbW9ES0lpcmJ5YUVreEFDNmNsOTJGTnV0?=
 =?utf-8?B?NFFDTGZGSlh6ak1GYURTS1RXaTJab0lUTXo3RGpuS0pzbUZMQmhTT213bmwx?=
 =?utf-8?B?WFNaYnNrSzJyS1c3eVUwcFpYei9jU0hIU2E1THBXMTh5VVJyWFlSWERmQWN4?=
 =?utf-8?B?M2wxOU1RUEF4enRiMVlDcGZURDRIWUtTN1ZMM0x1TFVLVy9rT1laOStZa1RK?=
 =?utf-8?B?cm9sb1VnQUNUWU1qRDZkcDdQdVAzeG4zZExsVHZHZGlaeXhkdDg4TnFVN29V?=
 =?utf-8?B?Q0R4NXQ2QlZWdHZyK2twdUVlak1KN1VlR3B1M0YrdGNXRE5rYllLM1RGemRC?=
 =?utf-8?B?YjByM3NMMkVKaHkwZXFabzNLT2RscFFWRnVQaU50NzhReEtCTG5HdFp6TkRv?=
 =?utf-8?B?NkQ0VVlVeE1TbEk5eWlMeWhOY0ZQcXJsRjdQdkE5ckpoZXkyRjhPQVdLdDFr?=
 =?utf-8?B?a3RGcHNLaTBRR0x0TnRscjVrdnVVU01DR3V4aTFiMHdQbS9xbDZHaTR5Tzlq?=
 =?utf-8?B?WVkrSlFySGZjRU1jSFFDdUtFejU0ZkhYOEhWN2J2MzVsMlhoK043M3ZIRDN1?=
 =?utf-8?B?ZEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cfd3bf6-e178-4018-e70d-08dc6e9779fe
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 13:13:24.8335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F7mDkP7hsZQnxpOMPzrgvnMgfxTLiB4l2Pr40fyiQL/m4I+uBQWXKY3lDj2TXLY5aA4qKLDRc1qzCcatooNlXyOtTkAPzKMZSQTuEMVSTIw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6659
X-OriginatorOrg: intel.com

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: Mon,  6 May 2024 10:50:40 -0700

> Allow the Dynamic Interrupt Moderation (DIM) library to be built as a
> module. This is particularly useful in an Android GKI (Google Kernel
> Image) configuration where everything is built as a module, including
> Ethernet controller drivers. Having to build DIMLIB into the kernel
> image with potentially no user is wasteful.

Some bloat-o-meter -c vmlinux.{before,after} would be good to have here.
The library is small, but I personally would like to see it modular.

> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
> Changes in v2:
> 
> - Added MODULE_DESCRIPTION()
> 
>  lib/Kconfig      | 2 +-
>  lib/dim/Makefile | 4 ++--
>  lib/dim/dim.c    | 3 +++
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 4557bb8a5256..d33a268bc256 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -628,7 +628,7 @@ config SIGNATURE
>  	  Implementation is done using GnuPG MPI library
>  
>  config DIMLIB
> -	bool
> +	tristate
>  	help
>  	  Dynamic Interrupt Moderation library.
>  	  Implements an algorithm for dynamically changing CQ moderation values
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index 1d6858a108cb..c4cc4026c451 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -2,6 +2,6 @@
>  # DIM Dynamic Interrupt Moderation library
>  #
>  
> -obj-$(CONFIG_DIMLIB) += dim.o
> +obj-$(CONFIG_DIMLIB) += dimlib.o

I guess you renamed it due to that there's already a module named 'dim'?

>  
> -dim-y := dim.o net_dim.o rdma_dim.o
> +dimlib-objs := dim.o net_dim.o rdma_dim.o
> diff --git a/lib/dim/dim.c b/lib/dim/dim.c
> index e89aaf07bde5..83b65ac74d73 100644
> --- a/lib/dim/dim.c
> +++ b/lib/dim/dim.c
> @@ -82,3 +82,6 @@ bool dim_calc_stats(struct dim_sample *start, struct dim_sample *end,
>  	return true;
>  }
>  EXPORT_SYMBOL(dim_calc_stats);
> +
> +MODULE_DESCRIPTION("Dynamic Interrupt Moderation (DIM) library");
> +MODULE_LICENSE("Dual BSD/GPL");

Thanks,
Olek