Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp529845lqh; Tue, 7 May 2024 06:47:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW1E0yg1lbc8+QK+NICDjQkFxR9WsSnmG06ziy+h64Wih8pmR1ore64cBKPJl9+zdll8xpdVhKKAaEoixUXwNR1KHVO76bdrJg9ElSJzA== X-Google-Smtp-Source: AGHT+IH4j+ybCjOeKn8On2duNkfgW1Ru61sKnJtxDQrdhxFLc5BCMiElzVYciT8QsR+DmtDutHbB X-Received: by 2002:aa7:d04d:0:b0:572:df77:c1bf with SMTP id n13-20020aa7d04d000000b00572df77c1bfmr6613505edo.3.1715089675998; Tue, 07 May 2024 06:47:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715089675; cv=pass; d=google.com; s=arc-20160816; b=jtioyTwkbEI13o4eG0z6D+AeDPEIsA0Hrnmq5VVhlxZ4zarrtg0OealCkdY3Q0nCFg 8/1H+gvzgcBjpmXcmv18+fOelRH9HIdEta0iIxM/oBFu6rRX0sl9dqSdverbEqilHWT8 LCT4dJeNggrd3dx5HfQ/YjsZsO6DkFuKmHzlVMJjRS+eY8Wv/iyG1S/0HYYTfD0TFMxg puI5O8Uu6QtNzpwcPaVYFus12ie8APDLeYkHPR0+nvyWxPJmeXgZIL0mHXGni8L27tdu kQoxkd74gDnT69khc4k4pp08axCT4MmuzX4pMlEWtR76BQhmWGVkzY7+7GdnSjI9A7C7 KW9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=KP5HKRW4kBbKaUQGr7WJW/KutC9oC2MC2S4+gvWBuKE=; fh=0116Uwf59v6iIJwbQU8VxEl5CdC4e5R9c0VfSz+zheM=; b=GZJ8PaUzcH3ISuc99qW4JOxP2njn+XjTKk7zRwJ95qNcLau8Zkt2g78N7InNGg7bde 1+BagKny24pv+BSoWJrc2zfThCfrAZBToITkzm4ODz1aqW/CGF9SvQ6QNh90OxiFc+6X pu5mKIlzXDdyBzXDswyu44PLsPkExDRW7BELsTLyNjWWOcb+nOyyIUOyiTC+VayUDl1w NQ8dq3KEK0kw15IeC/C1cg4HmrP4MrslH4uXEwVj5SodrcENZvg/Zc3ZEbbcPmp5SV9b AJpBE7EsbbRqCfZHBhrUBC6fc4SA9Z6hKmZRXAAXXc2l7jRO1oPN/Y3JYqprWXe5YPYd t2uA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="d/ZoamSZ"; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-171449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171449-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t16-20020aa7d710000000b00572ac193f65si5844638edq.540.2024.05.07.06.47.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:47:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="d/ZoamSZ"; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-171449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171449-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7D39C1F287A9 for ; Tue, 7 May 2024 13:41:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4412E15F30A; Tue, 7 May 2024 13:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="d/ZoamSZ" Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA1D15EFD0 for ; Tue, 7 May 2024 13:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715088887; cv=none; b=XwkF/SdZqxs/jRR7+DQTeu2EztL1fdhAS1wqpHyWNNmoye3v9Uuevpwsl4OvcGXQed/izZo/l8Q9F7miiFxsOKSIec0ZMF9WMxpFEINAXJhoUTm13IP2J94W5eO17GjkBiQP13ZlpUW5kELriZ2ZtRXa0azjgy/vbgNqbR/5B90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715088887; c=relaxed/simple; bh=bV3hZF+yWnUvLfolt0qL3m4QpmW8/sDlFRD//n8L/aY=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=RxGq3BG6eYru+//toFvUcu4iYAppoER5Szl0oJxMroedtRgLwW5IQwa2r5Nd8gBb7jaV+7oShzpSm9UCVmbwzjZpzaxXanoecrYF5VFxbG66gQ1Uf3CxIwa436lpJqxCduJChE4JTq/3N6BX5nuHZbFEsw1icCYRAYrnPy2dRKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=d/ZoamSZ; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7e186367651so4706339f.1 for ; Tue, 07 May 2024 06:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1715088885; x=1715693685; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KP5HKRW4kBbKaUQGr7WJW/KutC9oC2MC2S4+gvWBuKE=; b=d/ZoamSZxjkvWrrT1IMnPjBogp7aF4nGIKxTB+uXxJOsWbIZSeYZx7XBltN96MBlQk 8tB1owEP+Sq59e+aiay7+QEqKGYaRV7LMii6hgkaVGmXBl14rd4Tyc3gRzOazu22Z9oT m/iOa4Wm5Bc2SiavE0gfOi66WP++JsHD9ubhyN25XFE1pH+i8ZM9btDDBTsKFIxHse2i VNkHmz/hODE6fGbDTAesR+VQi3QZEPyvBPl+i02MCabTbS0xgxnKe6XLNyyciUeKZssB c862NBTqVEvNr7EgZkyxZ61vUZlPtZoe4dEh8w7KeuL3SesZBhQJSIMIfFBoRn5kHBuQ HQiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715088885; x=1715693685; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KP5HKRW4kBbKaUQGr7WJW/KutC9oC2MC2S4+gvWBuKE=; b=vxAsV0jep3VtoE4uKgFy14Z1sgNp5d5785UFLC9WtGzbxG9y+ZdVJZDdtwb+sAGElJ yeUgJjvxDU2uN7MqMg8DJDXx1u+ADQNeI5xBCp09AiVM5e8MyK+HHnez/1oxWX8stP0m rrB6Zmx176jddn+XhrhFPP6twYYskMdtAfwpGNtpEJMHkRA+FqeZoaCYZ3YMo00nlqRz FbovVLfxHVFr+Cq3DKjPGZHwStN+QIkKgyYOQv7JcbcMscZQBW+uZgnp/somItfLRjOs DQmVif2wY+q+T9NPBSQbAhGzI+OObXmA4OCfl3cxDWVcN3MLdQt+cD/XRxKIq/t8TiWH WEqw== X-Forwarded-Encrypted: i=1; AJvYcCUdAvN7mQwZLD0Bpww3SiEtmZc1K7SyTYIACu2V9NJWH5lEF6zlybmDohnb0Drk2Yp7n/7HopnwerF1lMT8kWlk4G0Tz7E9K1JrjYlN X-Gm-Message-State: AOJu0YyIT02R32RnS6K5Yuko6YsmOZ/vyVzUpcRdO90MQH1D6whsXB2e pnv6FuSBfEyPmnMJ/zU8wM0fdPVKNq3205q8wMFAir1uwYUdHQLPsTxfwtRrHWc= X-Received: by 2002:a6b:3f45:0:b0:7e1:8829:51f6 with SMTP id m66-20020a6b3f45000000b007e1882951f6mr974176ioa.1.1715088885335; Tue, 07 May 2024 06:34:45 -0700 (PDT) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id x6-20020a056638248600b0048859a02138sm2249450jat.86.2024.05.07.06.34.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:34:44 -0700 (PDT) From: Jens Axboe To: song@kernel.org, linan666@huaweicloud.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com In-Reply-To: <20240507023103.781816-1-linan666@huaweicloud.com> References: <20240507023103.781816-1-linan666@huaweicloud.com> Subject: Re: [PATCH] md: Revert "md: Fix overflow in is_mddev_idle" Message-Id: <171508888455.12290.2983821888497713665.b4-ty@kernel.dk> Date: Tue, 07 May 2024 07:34:44 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd On Tue, 07 May 2024 10:31:03 +0800, linan666@huaweicloud.com wrote: > This reverts commit 3f9f231236ce7e48780d8a4f1f8cb9fae2df1e4e. > > Using 64bit for 'sync_io' is unnecessary from the gendisk side. This > overflow will not cause any functional impact, except for a UBSAN > warning. Solving this overflow requires introducing additional > calculations and checks which are not necessary. So just keep using > 32bit for 'sync_io'. > > [...] Applied, thanks! [1/1] md: Revert "md: Fix overflow in is_mddev_idle" commit: 504fbcffea649cad69111e7597081dd8adc3b395 Best regards, -- Jens Axboe