Received-SPF: pass (google.com: domain of linux-kernel+bounces-171482-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f121b42b-bde5-4a40-a61b-5c8a97a25827@linux.ibm.com>
Date: Tue, 7 May 2024 15:53:32 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] s390/pkey: use kvfree_sensitive() to fix Coccinelle
 warning
To: Jules Irenge <jbi.octave@gmail.com>, svens@linux.ibm.com
Cc: borntraeger@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
        hca@linux.ibm.com, freude@linux.ibm.com, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <ZjkRlmoCtpsR-bBC@octinomon.home>
Content-Language: de-DE
From: Holger Dengler <dengler@linux.ibm.com>
In-Reply-To: <ZjkRlmoCtpsR-bBC@octinomon.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/05/2024 19:21, Jules Irenge wrote:
> Replace memzero_expliocit() and kfree() with kvfree_sensitive() to fix
> warnings reported by Coccinelle

Thanks Jules for pointing that out. But instead of using kvfree_sensitive() I would recommend kfree_sensitive() here. We're not on a performance critical path so kfree_sensitive() would be in my opinion the better choice, because we don't need to take care about the right size.

> WARNING opportunity for kfree_sensitive/kvfree_sensitive (line 1506)
> WARNING opportunity for kfree_sensitive/kvfree_sensitive (line 1643)
> WARNING opportunity for kfree_sensitive/kvfree_sensitive (line 1770)
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> Changes in v2:
>  - merges all patches that fixe same problem into one
> 
>  drivers/s390/crypto/pkey_api.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c
> index dccf664a3d95..e1dd7e0bdfd4 100644
> --- a/drivers/s390/crypto/pkey_api.c
> +++ b/drivers/s390/crypto/pkey_api.c
> @@ -1503,8 +1503,7 @@ static long pkey_unlocked_ioctl(struct file *filp, unsigned int cmd,
>  		rc = pkey_keyblob2pkey(kkey, ktp.keylen, ktp.protkey.protkey,
>  				       &ktp.protkey.len, &ktp.protkey.type);
>  		pr_debug("%s pkey_keyblob2pkey()=%d\n", __func__, rc);
> -		memzero_explicit(kkey, ktp.keylen);
> -		kfree(kkey);
> +		kvfree_sensitive(kkey, ktp.keylen);

kfree_sensitive(kkey);

>  		if (rc)
>  			break;
>  		if (copy_to_user(utp, &ktp, sizeof(ktp)))
> @@ -1640,8 +1639,7 @@ static long pkey_unlocked_ioctl(struct file *filp, unsigned int cmd,
>  					&ktp.protkey.type);
>  		pr_debug("%s pkey_keyblob2pkey2()=%d\n", __func__, rc);
>  		kfree(apqns);
> -		memzero_explicit(kkey, ktp.keylen);
> -		kfree(kkey);
> +		kvfree_sensitive(kkey, ktp.keylen);

kfree_sensitive(kkey);

>  		if (rc)
>  			break;
>  		if (copy_to_user(utp, &ktp, sizeof(ktp)))
> @@ -1767,8 +1765,7 @@ static long pkey_unlocked_ioctl(struct file *filp, unsigned int cmd,
>  					protkey, &protkeylen, &ktp.pkeytype);
>  		pr_debug("%s pkey_keyblob2pkey3()=%d\n", __func__, rc);
>  		kfree(apqns);
> -		memzero_explicit(kkey, ktp.keylen);
> -		kfree(kkey);
> +		kvfree_sensitive(kkey, ktp.keylen);

kfree_sensitive(kkey);

>  		if (rc) {
>  			kfree(protkey);
>  			break;

-- 
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@linux.ibm.com