Received-SPF: pass (google.com: domain of linux-kernel+bounces-171562-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a0a896fef1aca8958a190801ab5355e22373081d.camel@xry111.site>
Subject: Re: [PATCH 2/2] Loongarch:Support loongarch avec
From: Xi Ruoyao <xry111@xry111.site>
To: Tianyang Zhang <zhangtianyang@loongson.cn>, chenhuacai@kernel.org, 
	kernel@xen0n.name, tglx@linutronix.de, jiaxun.yang@flygoat.com, 
	gaoliang@loongson.cn, wangliupu@loongson.cn, lvjianmin@loongson.cn, 
	yijun@loongson.cn, mhocko@suse.com, akpm@linux-foundation.org, 
	dianders@chromium.org, maobibo@loongson.cn, zhaotianrui@loongson.cn, 
	nathan@kernel.org, yangtiezhu@loongson.cn, zhoubinbin@loongson.cn
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Date: Tue, 07 May 2024 22:20:42 +0800
In-Reply-To: <20240507125953.9117-1-zhangtianyang@loongson.cn>
References: <20240507125953.9117-1-zhangtianyang@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-05-07 at 20:59 +0800, Tianyang Zhang wrote:
> +static inline void loongarch_avec_ack_irq(struct irq_data *d)
> +{
> +}
> +
> +static inline void loongarch_avec_unmask_irq(struct irq_data *d)
> +{
> +}
> +
> +static inline void loongarch_avec_mask_irq(struct irq_data *d)
> +{
> +}

"inline" has no use here because these functions are only called via
function pointers, thus such calls cannot be inline-able.  I'd suggest
to remove "inline" for them.

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University