Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp559168lqh; Tue, 7 May 2024 07:27:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUxyAMY7FLxxSKzn617e1ke+J2d3AMO1/kf1uf8MCS+p2ssdfrSWrO/TnvOAhPk1NRCrPqjT8h6+K9liH3ArxbBVrF5+p1McGxuZzlJ7A== X-Google-Smtp-Source: AGHT+IE4Kypd7Q9LnfQVl+28QJ65yqiOaYQnFT/QjPxpb2yDeCXtTZfT5VQML0IpVN9CWn7kJuQN X-Received: by 2002:a17:90a:650a:b0:29d:dd93:5865 with SMTP id i10-20020a17090a650a00b0029ddd935865mr10212781pjj.46.1715092049677; Tue, 07 May 2024 07:27:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715092049; cv=pass; d=google.com; s=arc-20160816; b=1KNfjHF5Kh4PkVEIXyT7Docoh8309WU902Nl2N3xDESvS70EUGB+RoPZSeXverOLTD am2oAqLcqlTwsIErUOfaM9LzJKUS48Km+VuFyQ1+YaS+UDz6lNvvmA9yaZEXYprbSgfF BccOYyoqLnHAU0F7f2AzrWkr2EIhkJzI9jIxy2fs+O1KwiJ2k163U9q162Z+ky45+9Pd G1xzPgy8ReINPrLg0RgGStXyl3mJMEUMUOuDX1JjMtEtNIY8+E0Os0BZ4nzBQcDEgyae gI7KpKcpLSrIyWQS7mwH82/RmnAjS6N5zWWrrIW/x8Nw+DFkV/DWMBjvKw6GO5jo4QIW vVzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=a5mTNRe4LMZAhS4pUCYAVz2ek9U2ALsnFQIig+p2+qg=; fh=gRblsS+OU3Kghe8qKBxdtDSSViRUJdQqpM2O8o2cLRU=; b=OsWlgBDB2EYwxXXlcimtq+zw8de08eZRSkTxohR9DGxypsMxPXlH6V7VyPniKqgyZP SrJN74Nd+Gs+AkG8vbd+jB7RtenLTwH8UKXcNnu5eGf2humd4WVkOZFNCHyv3GBzVlcK tpknib3TsAmmReL64JY3tGqdSY+EZSxdOoEcU/vrxWU3BaAc24eH16JvOZ8+KWwnw4Be AjasmzX/AcA5kr6BDrqOTAB23m8bRVJfF7U5chuIMuPWj0Aw+iSJ7OxMBXpa0ln3uCCu LAqURUiE4KmrvuwZYCzbFcDTDF6/1um7WZqQNKi8ztj0hHPhw18j5GmgPSCk0/k+0qzO Qthw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="w4/5Kf26"; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171487-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id ip9-20020a17090b314900b002a004d25ad2si8848316pjb.89.2024.05.07.07.27.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 07:27:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="w4/5Kf26"; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171487-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 608B1B2452C for ; Tue, 7 May 2024 13:59:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59F4C15F316; Tue, 7 May 2024 13:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="w4/5Kf26" Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E6915EFD4 for ; Tue, 7 May 2024 13:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715090370; cv=none; b=YgSeJ1yiSBL3I1jnAOt1C6PnECVjUK3T7Tz6xy9znsL9bpWxqnqyrN6j8tGKFCLnEocZgvMr8LfVy50M4KmM55wn7Sn+RIqZRaLqbNXqwKNSMFO92HkvyLGqJL+pFDJthFNiAV/ZFEnNKtKHW/s0D1+iuo/Etl073Jh3C6gl524= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715090370; c=relaxed/simple; bh=H+0Ypsw0j6unIQYeRMtbsRKdx9TEn+kSRDNj91ZjtV8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lTYL0lLF3HX7bTGUEPvlc8yOe+X/ZSxrLNwBx5aOqDpOupbLP9Rzts+0EhfNIqSmOREgenP+aQg2MnImduq2LvTYkAbRcXjrmOXMqXzI7SI8Zm51JrKfC0WcbOAMkH4rKfJDY8D+OmkpJR1dKjfLJXXhwS1oLFPGDoRO5IMWKvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=w4/5Kf26; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Tue, 7 May 2024 06:59:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715090365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5mTNRe4LMZAhS4pUCYAVz2ek9U2ALsnFQIig+p2+qg=; b=w4/5Kf26tT3UzHWq+DJj0YASUMNXid3U6M0LUF9SBZrWflJ55cZCRHCoWEHBN0Qz6Ct9At KGvidyYUNrvpt0c62rXi60jUGHfXEMJjSuPJ8Hm0kOB5fYaJngokaybEzcsqeA23Q37sEg lXMueCQqzHk8AyLgwkGV2eOPM3nqZ0Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Xiu Jianfeng Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool Message-ID: <2bvwvb2w2z7hpoagdeus6gpuwmx26xber7tgkp7rxrq4uuttzm@bnl4x2rve3zu> References: <20240507132324.1158510-1-xiujianfeng@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507132324.1158510-1-xiujianfeng@huawei.com> X-Migadu-Flow: FLOW_OUT On Tue, May 07, 2024 at 01:23:24PM +0000, Xiu Jianfeng wrote: > alloc_mem_cgroup_per_node_info() returns int that doesn't map to any > errno error code. The only existing caller doesn't really need an error > code so change the the function to return bool (true on success) because > this is slightly less confusing and more consistent with the other code. > > Signed-off-by: Xiu Jianfeng > Acked-by: Michal Hocko Acked-by: Shakeel Butt