Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp564741lqh; Tue, 7 May 2024 07:35:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCULmFzDtH17ueoPuD5mHU2zYi6Z+tIUEeFJYojYZc8H1Cj2J5eTyq6si0aMFA7bM9W/mIi8r+9WLeG8YuLusGNYiS1XnBIDM//hAFp1eA== X-Google-Smtp-Source: AGHT+IGUKoZtn/A3ELaCKn4Ec1cMSXqB1AivDjON926bmkqvcV3ETGcSJu8MHgOzwCvENX/2S095 X-Received: by 2002:a05:620a:3911:b0:792:a8d2:83ce with SMTP id qr17-20020a05620a391100b00792a8d283cemr2520543qkn.17.1715092530617; Tue, 07 May 2024 07:35:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715092530; cv=pass; d=google.com; s=arc-20160816; b=0opgaifnQtcd8BVYnvB3u8V3phWQvPMh9BlcOsqFmiI3Sd7M3ZtdBfaB3oiRXEoizi v6IjKf4Ql1RGPCP2dj1TjxA8JzSGtw4FTR6HUDSicgaX3RHHg9NMXOm/GCiUdu9B0gYD foY4Kbnk3DGOGo4eK3GKHzK9eXbrqlWGev0/vXkCFV3KUKc9W8iqHtxJrDq9ImCfVz0I YIav+3S41kXxpdf+SZpx/hBMBBq0qpjWWlSsmZedIVWpl6s+VwILDdKVrCQoRwJcCP14 YkVcv4IHxBIRqbDptqFRA9hH+VMG9T+1dewunGdVQE7lcl+02Z4mSRo2I1X9sG7S14BX 2c1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=dNZPvkzaUH7dBKfK+scVHoxbinJWENU+1HImiKWCwFA=; fh=r7LdV5HZt9SkAJ5lvI9AIWwhp3k4yQcD1Zgc2fv5Kt0=; b=Y+Gq2sXlniDL1Q3g/jmyNvlGwC+3+uv0OC2Oi/gj54n4Y8tXDbmAtidZZbMmxNMwsp rVW/qQcPoTAZT3Ck7QvKmD8Fk3ZXJbmH1tjqaT3VD4A/Iy2t1W4YvmYyfMnhPwHRrMXV 01wiehXKrt+rC116iFDy3bnsyxeS8FjAT4d9Yl//5Ibjt+v5R4FRN09XF6fkLgRE1nzZ LIDo3Hhv1VeRCrMbsEmm+lzZS3IANLoE2ibp1UQC8RRmH5pw+jYT0/Kdwu/l3qSfs2Bm r7PoutPKlLz57nF8dJnoWHYtjntvDNJGbkgmI4Y8bxcpb+bp72Jb0On20gODMi6GUyuV ta3Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aPqSizRO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-171588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id c32-20020a05620a26a000b007905cecaac2si12874716qkp.211.2024.05.07.07.35.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 07:35:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aPqSizRO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-171588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 457961C219D8 for ; Tue, 7 May 2024 14:35:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E35115FD19; Tue, 7 May 2024 14:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aPqSizRO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 958D615FCF6; Tue, 7 May 2024 14:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715092505; cv=none; b=MyeCcAEXkYzovtVSVp1K+Mph0Xa3bdf6UZqIU/01fQGgGVBumbjkE8PmLu+v7gwIAuHXRdI/NtIIX3FQhF2+upftDVoxaXWvldjy8BUJYDZz9YD5pKkCyH8idJNxea/+ZyHV7ztEhQ4uH15oSEOqXQeR5Hi2S4fO24Z068BO3Uw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715092505; c=relaxed/simple; bh=N0nCKnQCByT3IK3m7wyeGknqiLgIC3cuB/Cu7ARwNXk=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=jJ3JR07A05PNrLUCHiF58jib12QSKCKE4AJ8FxtkRj6FC/gwVBwhRPZ5BnBLemXmiFLnBZJtJ5LEj2NafM9O+zUA0pqhdWWO+tFN4V7lffCuazdkwAePzlsGlr9A/bHupiiIDMUFfJ6ipoTZib8gZzy8oYqDsakUYzKDYZzumGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aPqSizRO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37C8DC4DDE2; Tue, 7 May 2024 14:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715092505; bh=N0nCKnQCByT3IK3m7wyeGknqiLgIC3cuB/Cu7ARwNXk=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=aPqSizROc6nkC1M30JjjYa4TqcuN2LVFmDCEX1yiBaD4A67donhVsuOX9Ts5WoG3v W7M1GDOTWsOl0Bufm3yPAxx/uyA+mDq9vY5n37fGNLecNUa6gaXx4VBEN7YCBbahCG Njp9f9QREQYHjfJmdBJw16zMIroiBGhcw7e8bg8ysTCzgsgqnILvLaAi9LnOvR6e+x 5aC0qnj4STAmYHg+/nHDJKCeOfrAvZNJCIfBluGe6zFo1PqLTpQliUBvK3T308ncrg wqERY3tSpi/Q5NktzUyTtltwJYK8JrQac3n8CNEbTXAtzWS9nd7i9Q3jVJxFImCOyL 7QpsuHopMIsDw== From: Mark Brown To: alsa-devel@alsa-project.org, Wolfram Sang Cc: Jaroslav Kysela , Liam Girdwood , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Takashi Iwai In-Reply-To: <20240430115438.29134-1-wsa+renesas@sang-engineering.com> References: <20240430115438.29134-1-wsa+renesas@sang-engineering.com> Subject: Re: [PATCH 0/4] ASoC: use 'time_left' instead of 'timeout' with wait_for_*() functions Message-Id: <171509250290.1985791.3642675927789530835.b4-ty@kernel.org> Date: Tue, 07 May 2024 23:35:02 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14-dev On Tue, 30 Apr 2024 13:54:33 +0200, Wolfram Sang wrote: > There is a confusing pattern in the kernel to use a variable named 'timeout' to > store the result of wait_for_*() functions causing patterns like: > > timeout = wait_for_completion_timeout(...) > if (!timeout) return -ETIMEDOUT; > > with all kinds of permutations. Use 'time_left' as a variable to make the code > obvious and self explaining. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/4] ASoC: codecs: wm8962: use 'time_left' variable with wait_for_completion_timeout() commit: cfcd957e63506273dc54f34b320172c8709244c7 [2/4] ASoC: codecs: wm8993: use 'time_left' variable with wait_for_completion_timeout() commit: 0800660d8c59539b628f5a6646bb63091d58152f [3/4] ASoC: codecs: wm8994: use 'time_left' variable with wait_for_completion_timeout() commit: 19c70b4668306632d3cbbecdf5fea98b528e873e [4/4] ASoC: codecs: wm8996: use 'time_left' variable with wait_for_completion_timeout() commit: 4e1f953a4a447b5e001655b453505c4c15904c61 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark