Received-SPF: pass (google.com: domain of linux-kernel+bounces-171591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 7 May 2024 23:36:41 +0900
From: Mark Brown <broonie@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Charles Wang <charles.goodix@gmail.com>, hadess@hadess.net,
	Richard Hughes <hughsient@gmail.com>, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH] Input: goodix-berlin - Add sysfs interface for reading
 and writing touch IC registers
Message-ID: <Zjo8eTQQS1LvzFgZ@finisterre.sirena.org.uk>
References: <20240506114752.47204-1-charles.goodix@gmail.com>
 <6362e889-7df2-4c61-8ad5-bfe199e451ec@redhat.com>
 <ZjmOUp725QTHrfcT@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="lPiblj3fTQ4wDvEh"
Content-Disposition: inline
In-Reply-To: <ZjmOUp725QTHrfcT@google.com>


--lPiblj3fTQ4wDvEh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 06, 2024 at 07:13:38PM -0700, Dmitry Torokhov wrote:
> On Mon, May 06, 2024 at 02:03:13PM +0200, Hans de Goede wrote:

> > If raw register access is seen as a good solution, then I think this
> > should use regmap + some generic helpers (to be written) to export
> > regmap r/w access to userspace.

> I think the less code we have in kernel the better, especially if in
> cases where firmware flashing is not essential for device to work (i.e.
> it the controller has a flash memory). That said IIRC Mark felt very
> strongly about allowing regmap writes from userspace... but maybe he
> softened the stance or we could have this functionality opt-in?

I think unmediated raw register access is a terrible idea, you can't
safely write a driver if userspace can just go in and randomly write to
registers with no coordination with the running driver and for some
devices the kernel needs to ensure that any writes don't damage or
destabalise the system.  If a driver provides an interface that looks
like raw register accesses that's of course fine (I mean, a lot of
firmware formats basically boil down to register write sequences which
is clearly fine) but it should be the driver doing that and it should be
looking at what's going on and ensure that it's joined up with the needs
of the rest of the system.

--lPiblj3fTQ4wDvEh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY6PHgACgkQJNaLcl1U
h9D1eAf8CiFrx1FTof5H3G+5IPZ86vGYxnBqYnt4ClHpxIe7bCBCQTi2o0/+2eOr
dbx61ihnlezPAkp+0cFqM7/Kzxruc9I0cEP6jp4LtOP6sDJgTz9Zj0zRht2i6A5b
j+BOo/2UHk+Q7nhde9m/7tjL6MkwsHpvg+ydWB679H/PnBo8hm75lgjq3gy+3gGd
EOMryKmKcnF/bPEk24QpI1BNf3mdbJ63Avcj0LCvack3yeaEoXPKJ89xN1SqLdAe
LMzF9V0YqKi3H8llb0Jfccvta9feqUQ/k/XI2mq2j4nr2/M7UBh/ckThwHUZRT18
nB7fKVugWFClUR8n/kKIp2fRdxsG9A==
=4jXB
-----END PGP SIGNATURE-----

--lPiblj3fTQ4wDvEh--