Received-SPF: pass (google.com: domain of linux-kernel+bounces-171606-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <208d227f-dfed-45d9-ab26-848fc12e22a1@amd.com>
Date: Tue, 7 May 2024 09:45:40 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 02/11] cpufreq: amd-pstate: show CPPC debug message if
 CPPC is not supported
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1715065568.git.perry.yuan@amd.com>
 <4b4a1a6b30a2dc6c95e550c62b230bc3788af415.1715065568.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <4b4a1a6b30a2dc6c95e550c62b230bc3788af415.1715065568.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eW92RlloSEtCYWZDT1JjWldnMjVTamRmWUhiUnpNdHByTGJIZysyckEzUVpY?=
 =?utf-8?B?T3VveWVJTE8rUVlXMHBXcTM0RWVYWGhQaWN5ZW93UUN0cXFRUnFLTW1nL2o3?=
 =?utf-8?B?enkyTzlROVJMM3V0ZU04aUR6bWVkUlhBOHh0Y0JUY0R6SEYzcWJnSEFkYytR?=
 =?utf-8?B?cWdPdDBxVWN0K3FWaXpmUzlrekE2YklJbVczNE5BRUhieUVpT0hmVHZDQ2Fy?=
 =?utf-8?B?RWphVXNNWFJKYnhCS0hyVkFwTHYzem5va1YrTk9vcUN6M0Qxc1BHdm1FNk9D?=
 =?utf-8?B?b0UyYjdzWG1kbWh1eDlscEhza0djTVdIa21meEpxTldzemJzVGI0OFZLa2Mx?=
 =?utf-8?B?cnpJV2tmL1dwRE1ZUk8vZTRKQTREaTJrVnhWUjBpSkt3YkpmckVIS0FYa1cy?=
 =?utf-8?B?eEtndFZ5d1NSQWxpa09sZnpTNS8rb3N1WnUxd0RBMURkTlRwMllQUUlYbUhF?=
 =?utf-8?B?REVmOUs4cmFkVVBVcFRIV0FvazZmckRNVUROT3l6eURqQnBZU1FDdUsvQ1NT?=
 =?utf-8?B?QXZjaTJKcmx1RTBTQXRyYUxKNnY5M1NXcHhCT0FMNnA0L3VIOUU1RW5oMVA0?=
 =?utf-8?B?eGhvQ3hTMk4yZXYzQ2VGdm9EbThHOS8zRnpNS0IyTENaRzVQd3lEOG5zQ1FL?=
 =?utf-8?B?SEYxOTZ5MFRvY2RhdkZOTXZ5VUZ2aVhhWXk5Z3B0WmgrNWNDK2ZOc3F5Q2VE?=
 =?utf-8?B?a0lOK0ZicVN1d0RWcXZTRSt5K1JhYXc1dUljMnBGSlQ2NWVrQjAwNmxpZHJn?=
 =?utf-8?B?ZlhDdHFvZ0xFVGhOc2I4MTlHUTlrM3Z1SWUvQ096V3dkcDVyUERJajZNMTBZ?=
 =?utf-8?B?NFcwZUJrYXlPbVI1NHhCRk9oY2RVNlFlMWhSamlQYUtnMy9nN2Y3RUJhTmN4?=
 =?utf-8?B?NWVoR0NjQUhpTWYvYUJoSFFhNUVqL3hZZ1ZlN0hTcEVwNmsrU3pIcEowQkMw?=
 =?utf-8?B?amo1Z0N6bnNsZTRjVTBpMlJtVDZRenlrbXBFYXJndDh5S3pkblNtb3RZOTND?=
 =?utf-8?B?Z1R5bGRpYmgwbXN5WXJha29DQlZHNE91SW9EazlnZVdSUDFTNS91TzdReFBR?=
 =?utf-8?B?TlhaUS8rbXRyN2p0UXpXUjFFdzJkaVVja3hjVVp5Yy9lck45WElQNThkaWhS?=
 =?utf-8?B?Mm1QaFFtc3h6QkJqcDNBNlFxRnJlOXlPZGhEVTlDNHNNVzF6dXNsMDRFd2VU?=
 =?utf-8?B?ajdCT01JdFR0QnNOR01yNjdYNS9Cd084cGlVdTF4NUxNRWRxK3NBMkhNa1dr?=
 =?utf-8?B?c2JhSHB5YnQ0OHI3ekpEM2VIYkdZeXhMMlVSVnpacndMNWxiSkdnUWtOckxh?=
 =?utf-8?B?RDA2aTJJdjhBZS9MUzlIRS8yTnV2U3EvVTBhZWFPQ2RSbTQyREF4bUIxVjZK?=
 =?utf-8?B?UEtsMGdUQk5NMjdwN1AwZk9mZTdtOVhhaG5uRFk0RDV6R2lLdUxGMlBWQ2RL?=
 =?utf-8?B?UnkzYS9FSHo4ak5JWjdZWlI4WU5oc0cvMDBBQ2JFR3lFaVlMZWJOR1ptVXlR?=
 =?utf-8?B?NHQ0SHV0TklhQlZjcU1NcDJQcHdlSkFLZTJaN2FMb0RmNlZJR2VQVHI1dHlw?=
 =?utf-8?B?QnR3ek5VK0NOU2dwSWV3ckN0ZGw5Y2J1WEdXbElkN0o2eGhVN1RCUHByM0lP?=
 =?utf-8?B?TDlPRFFNbWxxc2tsQ1ovZWVqbFlaWSs4MzNBdk4zTUEyRitmTFhQajNuUWhI?=
 =?utf-8?B?Yi9rVVNTWERwM0xDa2hsSDhDeDdOL0dxcGMwckxuMlZhZzBiWlo2ZHFLdWFO?=
 =?utf-8?B?eVZ3OU54VVhEdGVYSmdGZkhLZy8xNXZmY1VqcXZ2V0VrUTBmcVlURDZ2bU1y?=
 =?utf-8?B?eGRpUytRWlNiVUhjMGE1WjZkSG5nR3RxZjBiOXMwbVFxSkNOMi9rUXRwc3F1?=
 =?utf-8?B?Q3FvdzVHdzlyN0dINHZaSFdZai9pSHI1VFhCRUZ5QklyZUxpWVFEVFlyUnZX?=
 =?utf-8?B?cmNSQ3FKWFhTckNtMjk4ajdzWXZPTGh5d09kYTU2S0lacWNia005Tk1pWnhD?=
 =?utf-8?B?Y3A4ZWxQbmNLaWhZTi9tT1NCU3JyS2x3WWtXR3c2SjdOQkpERjZFdzZiSnBC?=
 =?utf-8?B?N1QrT0Z2a2JERnlPYkZtaDlmMGJ2MitNUG1vZXFCTTVlcmhZMThzYW1ra1VN?=
 =?utf-8?Q?FbgVBOhd6WfFnTVayKvaIqsZ8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca5b1e73-02f7-44cb-ed2d-08dc6ea45ee9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 14:45:42.7466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MEDSOZFaWBwZ/OJGJMqLoMtVoQr6fsxIlne2rtYXHj9fj/XhC3A6DXT/FQXU4HAG5SvSoG0VxAlQYTLXjg7UNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5602

On 5/7/2024 02:15, Perry Yuan wrote:
> Add CPU ID checking in case the driver attempt to load on systems where
> CPPC functionality is unavailable. And the warning message will not
> be showed if CPPC is not supported.

shown

> 
> It will also print debug message if the CPU has no CPPC support that
> helps to debug the driver loading failure issue.
> 

You should add a "Reported-by:" here for Paul too.

> Closes: https://lore.kernel.org/linux-pm/CYYPR12MB8655D32EA18574C9497E888A9C122@CYYPR12MB8655.namprd12.prod.outlook.com/T/#t
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index be7f2d3c86b6..cb766c061c86 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1687,6 +1687,20 @@ static int __init amd_pstate_set_driver(int mode_idx)
>   	return -EINVAL;
>   }
>   
> +/**
> + * CPPC function is not supported for family ID 17H with model_ID ranging from 0x10 to 0x2F.
> + * show the debug message that helps to check if the CPU has CPPC support for loading issue.
> + */
> +static bool amd_cppc_supported(void)
> +{
> +	if ((boot_cpu_data.x86 == 0x17) && (boot_cpu_data.x86_model < 0x30)) {
> +		pr_debug_once("CPPC feature is not supported by the processor\n");
> +		return false;
> +	}
> +
> +	return true;
> +}
> +
>   static int __init amd_pstate_init(void)
>   {
>   	struct device *dev_root;
> @@ -1695,6 +1709,11 @@ static int __init amd_pstate_init(void)
>   	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
>   		return -ENODEV;
>   
> +	/* show debug message only if CPPC is not supported */
> +	if (!amd_cppc_supported())
> +		return -EOPNOTSUPP;
> +
> +	/* show warning message when BIOS broken or ACPI disabled */
>   	if (!acpi_cpc_valid()) {
>   		pr_warn_once("the _CPC object is not present in SBIOS or ACPI disabled\n");
>   		return -ENODEV;