Received-SPF: pass (google.com: domain of linux-kernel+bounces-171622-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Zi Yan <ziy@nvidia.com>
To: Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org,
 maskray@google.com, ryan.roberts@arm.com, david@redhat.com,
 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com,
 zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com,
 libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com,
 peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk
 loop
Date: Tue, 07 May 2024 10:51:29 -0400
Message-ID: <0B21BF2F-26D1-44EA-B5C5-D0D490BB90CC@nvidia.com>
In-Reply-To: <20240501042700.83974-2-ioworker0@gmail.com>
References: <20240501042700.83974-1-ioworker0@gmail.com>
 <20240501042700.83974-2-ioworker0@gmail.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_A0A1FB65-AD45-4F9A-8447-4042CC159308_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Sjy/0jXCmP2JjBgD86W8lj5QpkdJ7gq0OjfTVu600DRmjTqezG6haZKxgAFn?=
 =?us-ascii?Q?ppSWn15PyKFJL/1jovSgkhimgb6/sRwNWPH4+x/94XqHab7Cy0vOrZlXwRsa?=
 =?us-ascii?Q?7UpA87aGsvux8p382Kp/2lQgTxZuIBL6df/p/6/QNpGCnrTgfiaNZUAW38IJ?=
 =?us-ascii?Q?YwqStdqLQwuNDESlwa7PI1od6H4HVAdcX9nqiR8cJHXkbkDfk7T6FpMEGwQO?=
 =?us-ascii?Q?hy1LVYFSbTb30ihBwELA3aiV3DfSzW1OXVA9W/lry9TLGK3yFwElZdK+qQGi?=
 =?us-ascii?Q?SfX/shIXs/mjbXjyjb5rOL7NoooY+QI2Zn+wVBXM5BJswIKO/49rStlrFn2x?=
 =?us-ascii?Q?OIo/rogJ1ZM1acq+eEExOIbeguoftQqxkAeNabsvoqZQb0WdAyL3Cz35JwKI?=
 =?us-ascii?Q?vqIEulxv2UsgjOyhpxyM1q6o6eo8rZvS7xVbX4S/fJ3MeeUDxI1nPaf9YvHt?=
 =?us-ascii?Q?30D7W+fMITpnFrQz2Lnn4PoOsL0+6SyVvd6GgxVdDRZtuT8S5hdRsDxdauDz?=
 =?us-ascii?Q?d2OzX/2TEw8dOdQOcQqBFprpu95B679FLkB7T2XdlUkARVjEvVf325DzXQRY?=
 =?us-ascii?Q?gfaqm/LtN14EGyb+dRz6J+6a20XpXVbO00KHujeygkjNhGW7SigQgQ9lb4kZ?=
 =?us-ascii?Q?xclumUp8jwnGxpNYWkdtnGf5IcFK3sQwm8KGSuWFcEqfQZQ/fI7mHKA09b0A?=
 =?us-ascii?Q?RTBP9wWjQ1iVWBLYNvKJxhIRfzqN7OwRGpe2ay/ezYj73xPHldZzA5ZYPzO6?=
 =?us-ascii?Q?NCQ//6MunppQ4T+Jt/TDoYKqBgbBIUjYf8jh87goWUmFwEE7V1kYoNy7YsJq?=
 =?us-ascii?Q?WjFFQ7MpXYDMbESQ60THfJbaJaJnCTONv5tELbqp4HZdNNCbTL1jW4fXR2jh?=
 =?us-ascii?Q?h+u5dwv0kaq/aR86HWUZg0uKmWjM6eQiXh1kPQOxSq0spaJzQcMWGWVAokHb?=
 =?us-ascii?Q?fy5FUdDMs8ww49gaSm3aQi3U3D6TXmexReg9H3p9hh1W/A73qUkN9hBHCPm2?=
 =?us-ascii?Q?BWq7qaEEAc6scCksTNAWvxGgDEbIcncGyNKcWGedNBM3gLfGcqZHMKxLW6aM?=
 =?us-ascii?Q?9/FVBrTXMrB41dQ6xDfEt0vPQKMJ3KOyIZx+x2t8sZ3IfpsLm7lIGPBVt2Lz?=
 =?us-ascii?Q?VUlXBRv4VfUBJsv/XTB6ZulMKmlp3D5XyD7BBcaOuCyf9oy9pLy7SoPvYmaS?=
 =?us-ascii?Q?HmcSLce8kfjuHgjAEXWAF/x2b/D90qVtCJ8qvFo4XbK3zZyitVscp07Kspxg?=
 =?us-ascii?Q?bfZWiJmj+fOqSFPaa9vWj/Ejipo3G2lp2P5czDwhZaQmNO+1VtURLJ8V5v6J?=
 =?us-ascii?Q?As7KKX/sUARjMrupfLwESEeIO2x+uwvzubircOauo98IPSRYrjXI5hVD7bwF?=
 =?us-ascii?Q?/nD8CjqjpX1VCwQtJAFatYxWKlaml2oh3plh0ce7gMhqT0x6oHDw0dzs8w/G?=
 =?us-ascii?Q?jnmQ0507EDGlG6htxPWUqrRZkqHQmpUnIUTO2B1xuDK1GgN4fyiyWddjiGme?=
 =?us-ascii?Q?BuZV8dquh4F56Kp3xyympk27j7iOiXFnniOZuOorZ9M3kAV4Z3SizD+va/wl?=
 =?us-ascii?Q?Bz8wqfDETt8TXebDqGk=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9af197db-c97b-4dba-0e25-08dc6ea5313c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 14:51:35.5767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xawy53zp7pFhzC9csRIgUIKxa7k7oF1XFthEsh9WNC3xhwqzVTPgYGIWDABHEHPh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6234

--=_MailMate_A0A1FB65-AD45-4F9A-8447-4042CC159308_=
Content-Type: text/plain

On 1 May 2024, at 0:26, Lance Yang wrote:

> Introduce the labels walk_done and walk_done_err as exit points to
> eliminate duplicated exit code in the pagewalk loop.
>
> Signed-off-by: Lance Yang <ioworker0@gmail.com>
> ---
>  mm/rmap.c | 40 +++++++++++++++-------------------------
>  1 file changed, 15 insertions(+), 25 deletions(-)

LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi

--=_MailMate_A0A1FB65-AD45-4F9A-8447-4042CC159308_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmY6P/EPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUFWsP/Rl2zj6PQrWU4/if54JimRNR1CHucw5jn+DH
958/a6qQzXc7j8VQ4izwgLrAItbX2NlKAW6YQT5T52JfWQM34wXk4a/S4O8mszu/
D77Dc6q/BIEAM7HM/o1WnsXNB8KFnSds7JWGDp2+pHHnKClh9G7hQIbCDga1EImQ
rhM0VOJaPsL8Uj4pBYG/nXuS8e2sKC/tiLMnCjHlpFLjJ7mcw1TiKjPiNqtpcZXt
c4bqueAr+ukYvOxjZm9fVPFjKJtfrjkJj6ar2RHDWd4rWmq1ZseYi//uPGGFdPUC
JPfduBbn10PWlsUJbMCYFzkXJp+LUuEvKf+ylRXfRBzi7FlVi4Jf/M++6YxvJyRD
57bcj6U2IBuIieFkyz9TqhdRU9WqY5PVQjUpMRDYTjhcXfP3V5OjA+gDbK5Pv5GP
WWpt7m6qKY0PglyxqZTaYHtgKXHr8qvu792SquRvk6vSG3UIyZCpgbf73kxfOzIk
VzEY/mmwtaQKtuSPoywuxaOCaWFrXaUBOX7N482ye3fwWBkdbORD1w4FSsl5/14o
j5xZGqFTSYjbNRlgEuqSfa9hsXpVOXn7k+1G5Fq1YhOeukevTT0pHhB26JUr698p
g+3lSW099pTw16i80nzxVlezM/GfibQ9bz0EQevwGQ9RZI7oFphug3AD2PTAakdH
x9ddMm0v
=8D0h
-----END PGP SIGNATURE-----

--=_MailMate_A0A1FB65-AD45-4F9A-8447-4042CC159308_=--