Received-SPF: pass (google.com: domain of linux-kernel+bounces-171623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 7 May 2024 23:52:28 +0900
From: Mark Brown <broonie@kernel.org>
To: "Liao, Chang" <liaochang1@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>, catalin.marinas@arm.com,
	will@kernel.org, maz@kernel.org, oliver.upton@linux.dev,
	james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com,
	tglx@linutronix.de, ardb@kernel.org, anshuman.khandual@arm.com,
	miguel.luis@oracle.com, joey.gouly@arm.com, ryan.roberts@arm.com,
	jeremy.linton@arm.com, ericchancf@google.com,
	kristina.martsenko@arm.com, robh@kernel.org,
	scott@os.amperecomputing.com, songshuaishuai@tinylab.org,
	shijie@os.amperecomputing.com, akpm@linux-foundation.org,
	bhe@redhat.com, horms@kernel.org, mhiramat@kernel.org,
	rmk+kernel@armlinux.org.uk, shahuang@redhat.com,
	takakura@valinux.co.jp, dianders@chromium.org, swboyd@chromium.org,
	sumit.garg@linaro.org, frederic@kernel.org, reijiw@google.com,
	akihiko.odaki@daynix.com, ruanjinjie@huawei.com,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	kvmarm@lists.linux.dev
Subject: Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate
 versions of MSR ALLINT
Message-ID: <ZjpALOdSgu-qhshR@finisterre.sirena.org.uk>
References: <20240415064758.3250209-1-liaochang1@huawei.com>
 <20240415064758.3250209-2-liaochang1@huawei.com>
 <ZjUKMWPknEhLYoK8@FVFF77S0Q05N>
 <Zjjz-tzLRC2nH51A@finisterre.sirena.org.uk>
 <cde4d448-dc9d-eaad-4a2d-a6d34bda4449@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="l+aZ4APLeGcXdXqx"
Content-Disposition: inline
In-Reply-To: <cde4d448-dc9d-eaad-4a2d-a6d34bda4449@huawei.com>


--l+aZ4APLeGcXdXqx
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 07, 2024 at 03:41:08PM +0800, Liao, Chang wrote:
> =E5=9C=A8 2024/5/6 23:15, Mark Brown =E5=86=99=E9=81=93:
> > On Fri, May 03, 2024 at 05:00:49PM +0100, Mark Rutland wrote:

> >> +#define set_pstate_allint(x)           asm volatile(SET_PSTATE_ALLINT=
(x))

> > Hrm, those helpers are not ideally discoverable, partly due to the
> > system register description for ALLINT not providing any references to
> > this being a general scheme (which is fixable there) and partly due to

> Based on the Arm ISA reference manual, the instruction accessing the ALLI=
NT
> field of PSTATE uses the following encoding:

I'm not saying the suggestion is wrong, I'm saying that between the ARM
and the way the code is written the helpers aren't as discoverable as
they should be, like I say from a code point of view that's mainly
because...

>                     op0  op1   CRn    CRm    op2
> MSR ALLINT, #<imm>  0b00 0b001 0b0100 0b000x 0b000

=2E..we only have the encoding for the MSR and don't mention the letters
'msr' anywhere.  We should improve that to say what we're encoding in
the code (in general I'd say that's true for any __emit_inst(), not just
these ones).

--l+aZ4APLeGcXdXqx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY6QCcACgkQJNaLcl1U
h9BivQf/QjNOMgHqmu7UcLWTGZ4Cdsxv0NPRW008VrPJCXISVIc/pWczJCP9gm1S
DZVr2Mp961MBiWixhmEKzLXogx29ALEBhBL5ImpgAfipQA64gzcbD2+S8F3JGTUb
V/PJF53nqhJd9w9YDs9TukxVmstjG6TYGMi28fdCOOsjd4QfMxq1MIHXmobPqm5u
eyt1WHI1eqX5+/y3AIytni/LoyzglsvZ9V15GnBVTAFlMykf+aeWX0wWxTmydEXS
OxulKo1wpSxKQDd9f9oNCiPLY0m0ZRqXRunt0/4ICmy2nvV0VVZ4Vsi41W4KA9AN
4ORObDb31r07sFNa8JRKkjBgtYKA9g==
=OEcE
-----END PGP SIGNATURE-----

--l+aZ4APLeGcXdXqx--