Received-SPF: pass (google.com: domain of linux-kernel+bounces-171644-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <e095cc78-3a95-4a65-b379-efc8a37608da@amd.com>
Date: Tue, 7 May 2024 10:01:36 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 05/11] Documentation: PM: amd-pstate: add debugging
 section for driver loading failure
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
 rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com, Borislav.Petkov@amd.com
References: <cover.1715065568.git.perry.yuan@amd.com>
 <ecc1c5a061859f9b9532e54f2b64d1cb5fd593c4.1715065568.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
In-Reply-To: <ecc1c5a061859f9b9532e54f2b64d1cb5fd593c4.1715065568.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUJrMUUwbWcwUWpXbng5SjlMNHNUby92UXhVM3phZ1RoUkZkM1FZT010QVVu?=
 =?utf-8?B?cFgycGNaakZzUVNQcmFtVXhaR0hnTDlta0NacEoxUTZub2RYd0NCZm01M3My?=
 =?utf-8?B?d29FQlRpMnBmTDdJMG1ERnJ5ekFReDUzZnV2ZjRwNytIS3pnTkIwdFdQL20z?=
 =?utf-8?B?K3M3dWU1QTU2Sjc3OG8zYkN4cnEycW16ZTgyOEEzWGtaYzVhdWRUZTZqZytR?=
 =?utf-8?B?MUViM29VSk1hRGQrckZzYXF0UUlpS1RIZ25PMVdIZHBUM3hLQ1N4Y3NvQVBM?=
 =?utf-8?B?eHErRksxNDhBREVKSVA4YUZ2WWxCSU9mbFVOM1p5RTFJcnQxaElSVmdSU2x0?=
 =?utf-8?B?dlJhdHEzZ0JyajBnQVBkL1RwNS9vWGhZQkJuWGlKcndDQVpSTmY2eTg5NUh5?=
 =?utf-8?B?L3pTdnAzQjBZeXc0c1V0MTJsTkFOeGxvOXAxekpsb1pVVFkvUmZIeWNwMGd6?=
 =?utf-8?B?MzZKV1lYUkFrSS85UzYzZ2VkdmJiL1ZYakNSZ1M3dE02dHY2Qy9TSjhaZnJz?=
 =?utf-8?B?a0VDaHh5czNUdlFHclVuOHBRVmNQc21YSzR5Z0ZENkhxRUUxS3RtaDRUMkJU?=
 =?utf-8?B?YzJWR2lrcEFpWklCc0M3dHF0cGVMUGlnQjhYenlLYlBuUzVXR0VPS2VCS0Fz?=
 =?utf-8?B?a1RsTUlFTUN1bTl6amFaRFlXWXpySjREVjZiY01jcHdVV2FKSVBrSTZrY2lo?=
 =?utf-8?B?YzlUMGMrSlh1b3c3enZDS1IyMHhHM3VsVnI4QjVmOEo5bGZ1cGNESzBReUxv?=
 =?utf-8?B?c2pXVGNoUHF1SXA3SDVINHFZSHlpNUM3RkhEYjhlTjlHSS9GcVdQYi9WaW9G?=
 =?utf-8?B?bUIwRVRBck05R3JNQkdxaFNFY2lIeURUUy9rVU5KSXpYNk1KRjVaTWlTbFJh?=
 =?utf-8?B?TEJjN09CZFhqSDBiM2IrT2N4LzBET3kwaDJQWldsVTlYMlNSelFFVTY0cEY3?=
 =?utf-8?B?NVU0THg5U1BZSVVHY2o5ZjNkK1RwaEZFQW9KdDR3b0VzRW9zQ3hQYkgvYitl?=
 =?utf-8?B?WTZmVDVpOHBFQWhyL0w4T3VzaDF6RVhzanExWGR1ZlBiVG8wcklZZ29XNzBS?=
 =?utf-8?B?NW55RXA2RXFhYmoyUDkrN0VGOFc2ZVVIdTQ0ejEyRTlLelRJVEFJN05aN2ZX?=
 =?utf-8?B?ckRpL3ZESFFVT1Q4cE1CRTQ2NkFKWDlZZm9WanNpd2plYXF0dVcrY1YzRjVT?=
 =?utf-8?B?Vm90WTV1cnhlamV6T3pFUzZzckkxVUZYaEUxcHVGQzJZSHF6TzRhWHhWc2JO?=
 =?utf-8?B?L21SRGxTVTkva2hqSGRod0ppSGVWeFFyUTlNZXRvNlplOHcyZ2o1d1B2VXh4?=
 =?utf-8?B?VjU4NXBmTjJRNXRJMkVOMVpsWVhOdE5GZDFxWTBweWd3NGYvNWJWdlVmT1Qy?=
 =?utf-8?B?akpucUlIdzFMekUzSm5Zd2JqSjE0VkVmZ04xVk4xN085a1NQOUdyWVlxbFpU?=
 =?utf-8?B?N2NIMzdsUE1hTUJWUFpSOElTeTRDSnVPN1RwdVFrR2lxODlyNW5hK3RFVDBW?=
 =?utf-8?B?dzZpbFNhekNRdXgybmxDVjJVcUFDNS9tRnRYUGZkbFd2YnlvTEdUOUpjdVl3?=
 =?utf-8?B?dXNERTd0WU5vRFpJR0YzSlJXelhmbU5xNnovTTBzTGE0SWhVcy8rcUxoSVNB?=
 =?utf-8?B?bDRnbi83eHhrK002WEIwcHI5ejBKTlRZVXM2eWtyV2lxSWtpaDNHbExoc0kr?=
 =?utf-8?B?MTY4UExybGRWNXV1QXkxbXhWcXM5VnZ6c1dpZWZsMGtVeDQwc2dqemRkUUcy?=
 =?utf-8?B?S0ZMQ2FFT1d5dHcxcnpYcklKVXBZY2ZhZ1Y0cHlHQmJDTDJzSFE2a29uUmF1?=
 =?utf-8?B?NFNLekMySzJnbVdHQ3YvYzFwVmhVVk4vWWtLT3cxL1d2OUpKbmRtdjFvaGsz?=
 =?utf-8?B?eGJSRkRYM2o3TnNySFFoU2Z5ODAzOE05Q256bEZlTDMrYXNtMmsrS0lKRlls?=
 =?utf-8?B?YkRpcE5NTk9FTHB1eFFOcXJ6M05mME81ZmNQbzJveWZReGRSSWZnSUlwTFB4?=
 =?utf-8?B?QzE4aktIaFRlWlA2aDZ6VnhPakhzV0R6cElaL3hhaGVVK1VYdE1zYVNvM1VZ?=
 =?utf-8?B?dHBvZGNFMk1OZnpqalFROVNRbVBIRTJrNmhjcDJpQ3dwSjJYWkhjRnY2c2t6?=
 =?utf-8?Q?loJQ3fP8tT3RNlNM2VlV0sf65?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b09d4ae-0dbc-4bd5-54fb-08dc6ea698ec
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:01:39.0885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AX2MxjR2ldOYTffMp6MgkrsuIt2tv4sXhbn/AexzRF8oPj0r4+85kHWg4QIrtQt2v5xRZfG5+aN1/c1X+5oINg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6246

On 5/7/2024 02:15, Perry Yuan wrote:
> To address issues with the loading of the amd-pstate driver on certain platforms,
> It needs to enable dynamic debugging to capture debug messages during the driver
> loading process. By adding "amd_pstate.dyndbg=+p cppc_acpi.dyndbg=+p  loglevel=4 debug
> amd_pstate=active" to the kernel command line, driver debug logging is enabled.

Here's an attempt at rewording this paragraph to consider.

For debugging issues reported by users with amd-pstate dynamic debugging 
output is often needed to aid in root cause.  amd-pstate does use a 
variety of CPPC functions that also provide dynamic debugging output.

Add documentation showing how to use dynamic debug for both.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 2695feec1baa..230e236796f7 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -476,6 +476,19 @@ operations for the new ``amd-pstate`` module with this tool. ::
>   Diagnostics and Tuning
>   =======================
>   
> +Debugging AMD P-State Driver Loading Issues
> +------------------------------------------
> +
> +On some platforms, there may be issues with the loading of the amd-pstate driver.
> +To capture debug messages for issue analysis, users can add below parameter,
> +"amd_pstate.dyndbg=+p cppc_acpi.dyndbg=+p  loglevel=4 debug amd_pstate=active"

Two things:

1. AFAICT you shouldn't need to set the loglevel, this should only 
affect console right?  Most users will share a kernel ring buffer or 
journal.

2. I don't think the debugging suggestion documentation should include 
explicitly setting the mode to active mode.  Active mode is the kernel 
default already.  Users or their distro may have set the mode to a 
different mode by default and this may change things unintentionally for 
them.

> +to the kernel command line. This will enable dynamic debugging and allow better
> +analysis and troubleshooting of the driver loading process.
> +
> +Please note that adding this parameter will only enable debug logging during the
> +driver loading phase and may affect system behavior. Use this option with caution
> +and only for debugging purposes.
> +
>   Trace Events
>   --------------
>