Received-SPF: pass (google.com: domain of linux-kernel+bounces-171648-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9f901f10-24f6-4d81-9bee-2f8126251a86@amd.com>
Date: Tue, 7 May 2024 10:03:26 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 07/11] cpufreq: amd-pstate: switch boot_cpu_has() to
 cpu_feature_enabled()
To: Perry Yuan <perry.yuan@amd.com>
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
 rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com, Borislav.Petkov@amd.com
References: <cover.1715065568.git.perry.yuan@amd.com>
 <39ce335d80306e7e9ed9e169994348e1f65e1679.1715065568.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <39ce335d80306e7e9ed9e169994348e1f65e1679.1715065568.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MDZlMkNKbUhkODUrdWN6MlB2K1QyeHJCa25yT3EvZmtQOWZTV05aMThoYlA0?=
 =?utf-8?B?d1ZpQkRwUjRTMXRETjFKQlZCcDZLb2xQQmdrNHFNOUhRVmlkc3dtZURETEhJ?=
 =?utf-8?B?dUtFZTcyM01FVnJkdHd2V0ZmcUNTT1EyWGhxaVpNTkRlam1hWm5iTEhpRXlr?=
 =?utf-8?B?YjJZRWdTdXRHZG93Q21YMVhrUmdzZE5GODZXb1M4NldxcjU5OFRvU3d4RmY2?=
 =?utf-8?B?aVNwY2d3N3dORzAvbWN6UUhlVUhSTXl6Y04xeWxXU3lMYzRmZkhpeWY1QWs3?=
 =?utf-8?B?Snoxdk51SjFaUUxkZ0gvNG1pMGhUQlBqd3R5NjR0eEtNV08rdzY2QTVRMnFm?=
 =?utf-8?B?bWtXa0RKb2lLcmRDZ3hSaWFNenNOb1FsK3d2WWFyeEo4cHgzcE1sQnhJWG1R?=
 =?utf-8?B?WHEwN0F5WVlMdTJGcVNBUkVqNlRZL1lDV2VwT2puNDBvRHdEclhzdlpUTjZW?=
 =?utf-8?B?YThRakZBckdaeHBTOEJPOEwvNVJjbnFidWJMdlhrS1JzNy9sN2drL0V2RkQ5?=
 =?utf-8?B?elJHMmU0dFo2V2VESUdhRWp1Nk9TTmtzV3E1b2svSWduditRd1Vqa2VMRGxw?=
 =?utf-8?B?dklESGJBL250bkt6NGN2Q1Vwd3R2Ri9MeFhpVHp5aWQwMldBZ1gzbjhFZWxR?=
 =?utf-8?B?Wi8zT2RWb0t0ejVEVUxxTlpUZDBLOU1La2Q1bFJ4WjlHRFJnR0lOOXloNXdt?=
 =?utf-8?B?YzRRRENiNk5jUGdWVWlNclRkdCtwZ0F1QlovSnJvWXcxdjRVNHpCTit6Z2xT?=
 =?utf-8?B?V1dHUDdLaDB5VlkzMUtheGdROElZZksxZkZZa0l1RjJZYTl5c050ZW0rNFNB?=
 =?utf-8?B?RmNNUnhIaGlLRTk0MmNwa0d3Y0tqb2JCaE1sUUh3ZWVnOWdDOENaY2phdGxL?=
 =?utf-8?B?L0RGRU5adVc5VVZZelBtd3BrQ2t6VTdMWGNxUUxTQXVGSmZVbUlVN3RMb3hU?=
 =?utf-8?B?akd3S1NxbUozTDRtWXJDVWNKUlBuZjYzbEVFOGdLVmUrWVI1M252dUFQWEhF?=
 =?utf-8?B?RFFSNitZT2oyU002R2NDZFlsTkdQbVNNbTZvc0ttdWw0TzRtRzFGQTE4VWFF?=
 =?utf-8?B?alZKb3RRVFZnWDE3TnRwcG9qbHlwZ0lXTnRiaVB0T1F5N0FLcHlBMWNteGtC?=
 =?utf-8?B?SUF4cG4ybkUrV3RTaHhiZVFnN0hvdzJ4WUk0ekwwMHVTMzlJd1pMblRtaElH?=
 =?utf-8?B?WmgrUnArWEY5R09Xc3RrRmc1VjNTUFFvQ3VkeWpLeUpqUVBBZmtva3pDNzFG?=
 =?utf-8?B?MHhKTTliSWQwc0g1WGNhOHFZTHk2aUVweGJOSEJKcEZpNTcvOFc3N2FMV05D?=
 =?utf-8?B?Z3JFN2l6UFR5Sm81OUFxdUdCQThPby9CN09nSzRpRlB0TERyUE4za3VQYk9i?=
 =?utf-8?B?NjRDMG5Ba0RlNWFxcy9EVFRDY0wzaTl3ajIwckJCSkxmc3VrUHVndFpGb2Zw?=
 =?utf-8?B?MUgvZ2tjckpBcnNMTElIYklEWUg2VFJzQVdIcjBvR2kxSHFKb0RudFcwRkd0?=
 =?utf-8?B?ZXBVWFp0WEsyemErSWNzRlE4UVZKSXlLWkROZmtxUEtOdi9VTk5scmxwM0Zs?=
 =?utf-8?B?d01xVXpEN3E0YUFoVlQvQ1A0elFIWUI0RVU2Y1hVUlhPczJ1K002N3duMC8v?=
 =?utf-8?B?dFA2aVJMTVZrTjkwOFdKUXJHRjYwVlgrZERFNDJKWjFLbjAxUndGQy9LSTlL?=
 =?utf-8?B?and5bGhGbkNMOG1PeHV3aW1Ga1crK0pncGErdGtTOTBINzhxZmdYVGJBOVZi?=
 =?utf-8?B?eVF1amY0aUtkYThkVG9PQ2xBdEczdjM3eTdrQmh1NmtIQVlxMWlQdm80UFZJ?=
 =?utf-8?B?SEw2alpPWitFZlkya25kOGFNbHd1WHk4VEE2YXR5MGRjaGNNZEZzMVg3NGZK?=
 =?utf-8?B?Q0VCMTY5WUVtZ0NtUlB5UG5aR1llZys0ZlFKQzcxSnNoNm5tV1ZCc09YK3Nr?=
 =?utf-8?B?QmxpVzVQWjhnblY0RDFrV0UwNjZUQlAyRjVXTWptSHovaTQ1Q1RoVklzU1JQ?=
 =?utf-8?B?REQrN0RRWjYyVmtuUEtxMlJaVkViaU5tdmdtYVVPbTByOVZySWl2VVpaQXFH?=
 =?utf-8?B?aVd0ZjVHMjIxaFdWa2RtQWlDOFRzTEQ0TWZuVDJaR0NKd2I4Y3h3NEZmY0I2?=
 =?utf-8?Q?2G4f2oZHz9fbis4Kc46CpBsce?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1710bfd-a565-4e19-a9f6-08dc6ea6dad4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:03:29.7441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G8vHhE8VmWoTP4PV9cPHgJlt+0mhHqiBEEY/oOQ8e5lyZey1P7IDWa+zcV8lBvzuZCZgZ5kQU4kkwd//FGaSMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6200

On 5/7/2024 02:15, Perry Yuan wrote:
> replace the usage of the deprecated boot_cpu_has() function with

One nit.

Capitalize the "R" in replace.

> the modern cpu_feature_enabled() function. The switch to cpu_feature_enabled()
> ensures compatibility with the latest CPU feature detection mechanisms and
> improves code maintainability.
> 
> Suggested-by: Borislav Petkov (AMD) <bp@alien8.de>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

Acked-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index e94b55a7bb59..7145248b38ec 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -124,7 +124,7 @@ static int __init dmi_matched_7k62_bios_bug(const struct dmi_system_id *dmi)
>   	 * broken BIOS lack of nominal_freq and lowest_freq capabilities
>   	 * definition in ACPI tables
>   	 */
> -	if (boot_cpu_has(X86_FEATURE_ZEN2)) {
> +	if (cpu_feature_enabled(X86_FEATURE_ZEN2)) {
>   		quirks = dmi->driver_data;
>   		pr_info("Overriding nominal and lowest frequencies for %s\n", dmi->ident);
>   		return 1;
> @@ -166,7 +166,7 @@ static s16 amd_pstate_get_epp(struct amd_cpudata *cpudata, u64 cppc_req_cached)
>   	u64 epp;
>   	int ret;
>   
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		if (!cppc_req_cached) {
>   			epp = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ,
>   					&cppc_req_cached);
> @@ -219,7 +219,7 @@ static int amd_pstate_set_epp(struct amd_cpudata *cpudata, u32 epp)
>   	int ret;
>   	struct cppc_perf_ctrls perf_ctrls;
>   
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		u64 value = READ_ONCE(cpudata->cppc_req_cached);
>   
>   		value &= ~GENMASK_ULL(31, 24);
> @@ -705,7 +705,7 @@ static int amd_pstate_get_highest_perf(int cpu, u32 *highest_perf)
>   {
>   	int ret;
>   
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		u64 cap1;
>   
>   		ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1);
> @@ -941,7 +941,7 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>   	/* It will be updated by governor */
>   	policy->cur = policy->cpuinfo.min_freq;
>   
> -	if (boot_cpu_has(X86_FEATURE_CPPC))
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC))
>   		policy->fast_switch_possible = true;
>   
>   	ret = freq_qos_add_request(&policy->constraints, &cpudata->req[0],
> @@ -1174,7 +1174,7 @@ static int amd_pstate_change_mode_without_dvr_change(int mode)
>   
>   	cppc_state = mode;
>   
> -	if (boot_cpu_has(X86_FEATURE_CPPC) || cppc_state == AMD_PSTATE_ACTIVE)
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC) || cppc_state == AMD_PSTATE_ACTIVE)
>   		return 0;
>   
>   	for_each_present_cpu(cpu) {
> @@ -1404,7 +1404,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   	else
>   		policy->policy = CPUFREQ_POLICY_POWERSAVE;
>   
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		ret = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, &value);
>   		if (ret)
>   			return ret;
> @@ -1487,7 +1487,7 @@ static void amd_pstate_epp_update_limit(struct cpufreq_policy *policy)
>   		epp = 0;
>   
>   	/* Set initial EPP value */
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		value &= ~GENMASK_ULL(31, 24);
>   		value |= (u64)epp << 24;
>   	}
> @@ -1526,7 +1526,7 @@ static void amd_pstate_epp_reenable(struct amd_cpudata *cpudata)
>   	value = READ_ONCE(cpudata->cppc_req_cached);
>   	max_perf = READ_ONCE(cpudata->highest_perf);
>   
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value);
>   	} else {
>   		perf_ctrls.max_perf = max_perf;
> @@ -1560,7 +1560,7 @@ static void amd_pstate_epp_offline(struct cpufreq_policy *policy)
>   	value = READ_ONCE(cpudata->cppc_req_cached);
>   
>   	mutex_lock(&amd_pstate_limits_lock);
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		cpudata->epp_policy = CPUFREQ_POLICY_UNKNOWN;
>   
>   		/* Set max perf same as min perf */
> @@ -1748,7 +1748,7 @@ static int __init amd_pstate_init(void)
>   		 */
>   		if (amd_pstate_acpi_pm_profile_undefined() ||
>   		    amd_pstate_acpi_pm_profile_server() ||
> -		    !boot_cpu_has(X86_FEATURE_CPPC)) {
> +		    !cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   			pr_info("driver load is disabled, boot with specific mode to enable this\n");
>   			return -ENODEV;
>   		}
> @@ -1767,7 +1767,7 @@ static int __init amd_pstate_init(void)
>   	}
>   
>   	/* capability check */
> -	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +	if (cpu_feature_enabled(X86_FEATURE_CPPC)) {
>   		pr_debug("AMD CPPC MSR based functionality is supported\n");
>   		if (cppc_state != AMD_PSTATE_ACTIVE)
>   			current_pstate_driver->adjust_perf = amd_pstate_adjust_perf;