Received-SPF: pass (google.com: domain of linux-kernel+bounces-171665-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 7 May 2024 12:11:39 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: linux-perf-users@vger.kernel.org, atrajeev@linux.vnet.ibm.com,
	irogers@google.com, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] perf maps/symbols: Various assert fixes
Message-ID: <ZjpEqyR74rl92jhb@x1>
References: <20240507141210.195939-1-james.clark@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240507141210.195939-1-james.clark@arm.com>

On Tue, May 07, 2024 at 03:12:04PM +0100, James Clark wrote:
> A few different asserts are hit when running perf report on minimal
> Arm systems when kcore is used, or the .debug/ info can't be loaded or
> /boot isn't mounted etc.
> 
> These result in some less common paths being hit for resolving symbols
> and things are done in an order that breaks some assumptions. I'm not
> sure if we could do something to make the tests pick this up, but maybe
> not easily if it would involve mocking the filesystem or even a specific
> kernel. I tried a few different variations of --kcore and --vmlinux
> arguments but ultimately I could only reproduce these issues by running
> on specific kernels and root filesystems.

Please consider adding Fixes tags so that we can help the work of
backporters/stable?

- Arnaldo
 
> James Clark (4):
>   perf symbols: Remove map from list before updating addresses
>   perf maps: Re-use __maps__free_maps_by_name()
>   perf symbols: Update kcore map before merging in remaining symbols
>   perf symbols: Fix ownership of string in dso__load_vmlinux()
> 
>  tools/perf/util/maps.c   | 14 ++++++------
>  tools/perf/util/symbol.c | 49 ++++++++++++++++++++++++----------------
>  2 files changed, 36 insertions(+), 27 deletions(-)
> 
> -- 
> 2.34.1