Received-SPF: pass (google.com: domain of linux-kernel+bounces-171628-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240501042700.83974-1-ioworker0@gmail.com> <20240501042700.83974-2-ioworker0@gmail.com>
 <0B21BF2F-26D1-44EA-B5C5-D0D490BB90CC@nvidia.com>
In-Reply-To: <0B21BF2F-26D1-44EA-B5C5-D0D490BB90CC@nvidia.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Tue, 7 May 2024 22:53:43 +0800
Message-ID: <CAK1f24mmhd1FT_YBZ=N27pzDCmaL-NJPP50pdmp=CnVG1kNPng@mail.gmail.com>
Subject: Re: [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk loop
To: Zi Yan <ziy@nvidia.com>
Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, 
	maskray@google.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, 
	mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, 
	shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, 
	wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, 
	minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 7, 2024 at 10:51=E2=80=AFPM Zi Yan <ziy@nvidia.com> wrote:
>
> On 1 May 2024, at 0:26, Lance Yang wrote:
>
> > Introduce the labels walk_done and walk_done_err as exit points to
> > eliminate duplicated exit code in the pagewalk loop.
> >
> > Signed-off-by: Lance Yang <ioworker0@gmail.com>
> > ---
> >  mm/rmap.c | 40 +++++++++++++++-------------------------
> >  1 file changed, 15 insertions(+), 25 deletions(-)
>

Hey Zi,

> LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

Thanks for taking time to review!
Lance

> --
> Best Regards,
> Yan, Zi