Received: by 2002:ab2:7104:0:b0:1f7:f6c3:9cb1 with SMTP id z4csp10013lql; Tue, 7 May 2024 08:28:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWUSfp2ZaOF35WGbeGN+c6MYMnuKS/zSMslcCpVKMy1jQfnf9YXySHam/J7n/f3TY2/y6EuY4jCPU8cRHLmQlbBmCPdjc6S50cHoh74AQ== X-Google-Smtp-Source: AGHT+IE/v+QEVS0lpElx9IUPAXH24YJa9VOTWWMlSk1bcXhprMfUC3F+amt29mtv8qXDN9+Nfdcp X-Received: by 2002:a05:6512:2205:b0:51b:518e:5679 with SMTP id h5-20020a056512220500b0051b518e5679mr10184644lfu.18.1715095689646; Tue, 07 May 2024 08:28:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715095689; cv=pass; d=google.com; s=arc-20160816; b=t6zVrQ7ptvK0UDYs/3mIP8Fp8giEQuaI3/pHdYa1l1Wxz+0l63mywqLeYmvwyQkDrR fiBUioEPTdnbnPvdmW/6HF3Fp2jL885GeONXnGK2v7EfvhpYaa+gWfG+94gbXWmAu8L8 T+7QE+HrFP3p5GU5uMKJxIsxCKdnVvpEJCjeY5HBXtOMBYb/D5s7A1gPT/kYkReVfddq PN1k9r+ArHdefi0iC9TSY+e6h10apbfc+ssHdPXMdVcoE+8n8VP2hv447tsMk+Xh7iB8 cXuT5WCjLAloBk+r5XpOFst7ZKi8FJEJgAtVDeL/RyaNT1nci+L7VQXFS3bsPDXkzNiS 4npw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=FQYetRaj2G06vixmhegXHGRS3pEXWJu8nVuWoNZuM7w=; fh=aznqSYAhe5NzYgYLW/V7xbfSEyFesCegLqxoNj8hWd8=; b=zErU/or6A50Q5ouE7RrwpwzbwLbfX84roHVGQYn/1g5tjTA7eRXPRkkExeBcgalX+o 2rRD8G4L6Hv4OiOesf/Tgjmm1IyX9GC6hu2mO9GAyRujQ3fq9afIFwYqFRIvPEIr8nYv HoOso0UpNSuXwBPXTx5qLgIaiep2xBTaA/cvXdE5jRIqyAU6WLHVMkfovdddxCqJW01H dsh+RHl8K0o/gdN9ndnXWeqHq+sUSwydvGbd8HVEEml1Zd1oSQn2vTbJvVigt2KW1w+j PB+Z9+sJIb2zl1j4U71I2HmQjueZHsxzROVlDf0N235NC/E6/QsesgAWL2vXB++zypkV n50A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Wszb102x; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171695-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id kq18-20020a170906abd200b00a59a6026903si4105308ejb.341.2024.05.07.08.28.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 08:28:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Wszb102x; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171695-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5C3ED1F23684 for ; Tue, 7 May 2024 15:28:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02AFE15E1E2; Tue, 7 May 2024 15:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Wszb102x" Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0791161313 for ; Tue, 7 May 2024 15:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715095678; cv=none; b=EXBUg13j8rRLhU9bBNrgdo9Ri2+RgesoivD18pTJ090lWLO8609+8RdqlGEQdW6L7d5YR5wZ63DBH80WPe7PXu6lu9u6RqqJoygvJHBC5OpPgme4vvXdUY3CUtnla5fKmmXwtUdBaV9l5x/IQKy+COo+WC2Sm1ZIzU0WWqVfj74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715095678; c=relaxed/simple; bh=JWTCLRwTKdxklZuNp/Rib1ejNmFkuPCcRX13xVhfOUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WfpuJuQOLSDAhFSVCOHL8elfaCg95JyBnE8M8ZNkotkfbNKkrMw9IcCMTqbDxxWpfObTg/tSpRNgg3Rta68XppQ++CvQ2sianGzgTdDPa3BuNZq0tIci6OrhEo41P9VsQ1gr2j2FOnY4aX17ha6PeLIDqFs3waNrRsn1IYbqJuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Wszb102x; arc=none smtp.client-ip=95.215.58.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Tue, 7 May 2024 11:27:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715095674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FQYetRaj2G06vixmhegXHGRS3pEXWJu8nVuWoNZuM7w=; b=Wszb102xULBhRSoFDVFMM3bZC8z1Blu4ylS4VJLjcwEZikXgHEFMfRByHU6iAzpDejSFPJ xm/HQKXRQEkqpcoRP1tvBVjSXMlNFGUYYsVmFxA5lfULtLBYzuv1pOWaQXGshgqQFKMG8x FmA/ieRp1nfcXtCdT66rwrJnEeKoS1U= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Linus Torvalds Cc: linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] bcachefs fixes for 6.9 Message-ID: References: <3x4p5h5f4itasrdylf5cldow6anxie6ixop3o4iaqcucqi7ob4@7ewzp7azzj7i> <4u2imuisg3sxaomerwbss6p22vxyc2lk6esyn5asybytwgrhe3@tccxjeu5hqmq> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4u2imuisg3sxaomerwbss6p22vxyc2lk6esyn5asybytwgrhe3@tccxjeu5hqmq> X-Migadu-Flow: FLOW_OUT On Tue, May 07, 2024 at 11:10:44AM -0400, Kent Overstreet wrote: > On Tue, May 07, 2024 at 10:43:11AM -0400, Kent Overstreet wrote: > > Hi Linus, another stack of fixes for you. > > I have a report from a user that the sb-downgrade validation has an > issue, so that's been yanked. As a followup: the sb-downgrade patch was good, the user had at some point been running an unreleased version (which adds new accounting for amount of unstriped data in stripe buckets); and that version generated a faulty downgrade entry (because it has custom logic for generating the downgrade entry based on whether erasure coding is in use). But I'm still holding that patch for now while I come up with something for that user's filesystem - I'll probably add a flags parameter to that validation code so that we only fail to validate if we're writing out something new, like we already can for bkeys.