Received-SPF: pass (google.com: domain of linux-kernel+bounces-171699-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <615c756f-0f0d-4cc8-be5c-70806bd9843d@intel.com>
Date: Tue, 7 May 2024 17:30:55 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] netdevice: define and allocate &net_device
 _properly_
Content-Language: en-US
To: Alexander Lobakin <aleksander.lobakin@intel.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
CC: Kees Cook <keescook@chromium.org>, "Gustavo A. R. Silva"
	<gustavoars@kernel.org>, Simon Horman <horms@kernel.org>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
	<linux-hardening@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240507123937.15364-1-aleksander.lobakin@intel.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240507123937.15364-1-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkFYVHJMblo1cW1sNlcyUXMrUXJCd0hINjhXeUEzUlpPRVNlakRNeGNoams0?=
 =?utf-8?B?L2wrNVVNdjhWZi8vQWJsVHE5b2tJbkMzd3lVUzNhVHhRMTU5c3cvVS9oRHBj?=
 =?utf-8?B?YzhVV3pKK29JVU5YWTFmd0ZKN2dndjhRclFxbEJZUWZvOGlCdFY1TXZpYmxz?=
 =?utf-8?B?bDFyMkRHdXVSb0JqVytTSGpiNGFpN2RjTTlZczJpeEw1WUNka0VGV1VZSlhY?=
 =?utf-8?B?R1BjZWkyTUFUbW9sU2ZKbVRVZWorVlVrM255R2VBMjJBZzYrNkQyN3BEV3Uy?=
 =?utf-8?B?WTlaUlpnbmVncURHR0VyZHR3d0diRFFtVWRrZTdkNDdXeC9mdDJHQWNyT1JL?=
 =?utf-8?B?by9xcUxGNUtnbWRwdGtwVEgrd21VNWJ2a3lhK1ZjRDI3T3FyVmhiUmN6dVlZ?=
 =?utf-8?B?OGFFdlR6ZW5lL1V4ZDdDMXNlZjJhYjJkQ3R6K2RUQmU5cUprdU5FNWpDd2VN?=
 =?utf-8?B?YXR3dWFFM1poUGdRT25tMlE3MFlJOENVMHFkZlcvZU1jTElDYkduOU1sNGVR?=
 =?utf-8?B?NUorRXh1VUltMkhta2FqQ25jNVJpS0ljMnR6emhNb1ZqWTZkdnl3RExNaVV4?=
 =?utf-8?B?ZkY0L0QrVHUxYkMzOUJZeVozSEoxcDlQUVA1MWZGaVAvcms1MDBsMUR5R1gw?=
 =?utf-8?B?dXNqQ2FyVVN0dTAxOFBRbHc5a1c2cXc5UExIQkVDWVBFbDJSbDhjYzVLMXlB?=
 =?utf-8?B?SXBSQkJtUDI2ME91RTV4VWJ3NTU0WEdKc0ZQTWpLVWg3OXR1RENjeVVmRjdi?=
 =?utf-8?B?eXZVNXFSMDdmUmppaVZ5M2VZMTdsK0R0UmJkS1hWMlA1dUxOaVhTNWxYZ2Mr?=
 =?utf-8?B?ZTRrdXZEckFjNXRQNngwbE8yWWtJa2VLMDRKZFozb0lGaTR0OXJhSEM5M3Bo?=
 =?utf-8?B?S01aRzRqZzNGYUJScUJiS21NYlRaU2FXOHRUUnNpS2ZBSENseUVEbGNZOVc0?=
 =?utf-8?B?OUNGcG1XbTM2aWprdXVEUjlpeC9jVnMxQTdIWENoTHpBZWFWTEl4RWJneEVi?=
 =?utf-8?B?VGdMclZnQUdGUU9RV2VlQVBjaWVTRXFGQ1ExdWV3SGJYN2FaeXFrS2x2d0Vy?=
 =?utf-8?B?Y1dFY3BvbDRUdFhwbFRQWC96MFJxZHoxWklYUkxZYkhvRkhGZytqK0Q0MkFn?=
 =?utf-8?B?L0dra3FocEcwTnRPOEZ5R1p1bW5uVWRaSU5tNFZ2VXdqM3pMS0NDQTRDblpo?=
 =?utf-8?B?YlowMklsSmFHYzQwaEdVbUx0S3F4L3lPNkkxQ2lnMFkxWGNQcjZwNmxNSDVi?=
 =?utf-8?B?SFRkUG8wallaZ1YzUWwrMVBTaUJCem5HeVlNdXV1OUZpUUYvSDNOdGE2NEdL?=
 =?utf-8?B?TXd6QUJPcUZSS2ZVVTlsS01UQnVGNzV4WHgzWG5VK3UvNmIzZUxwdStzVXA4?=
 =?utf-8?B?L3NkbHRBQk55aWFFQmZxS3dGQ1pYYmIyeVQ3d1BsZldvR3ZJWUYya2dDbmZH?=
 =?utf-8?B?VmlMVGJqdWlNTWNWSDFwT090UWNNN1doaUVUUWZWbVNReDBEbW9mVXh0ZlJT?=
 =?utf-8?B?elJyL2JxT2w1ZkI0Q1RvQVJLc1lyOHBEdjU5cWdVS0R5cTJvMTFNeXBCK2pT?=
 =?utf-8?B?Qlk5Yk80Wmw4a01wVWRvcXJhRTc5SHlGbng4Qml2NjlOWUZhUU9LT3h0SDFs?=
 =?utf-8?B?aEMzU2NKeUF1MG1sZEFXdTd1b2VkUFZzZ1ZkWlVwQkhFQW54ZG1xbXdRbGxD?=
 =?utf-8?B?MkVXRWdoeXJHb2ptRGRNL1dmcWpZeU5Rak9ROEFTMmZ2d0Q0ZXNtdmkyaFJU?=
 =?utf-8?B?U3FmNW00TUs2Wkd0dmZWV2dNbjNVZlNVU0FBd0twU0Exd0g1VGhpUUtScVg4?=
 =?utf-8?B?YmNPVzI2M2s5L1hUelZzL0JHdXhyZ3RJQ3BsMXhNZzgrVXRNMDROUFc2TGVH?=
 =?utf-8?B?aFg4VWRHNG4yaDZHbitkOVVSTU95cTkwbzFIdERjU2g2c3dzS1orRFQwNWpm?=
 =?utf-8?B?elFUNkxvak45TEZrZGdIRkZGWFRGUWJDeDY1VDhWN3RPWnBzT0V4NnVUUkth?=
 =?utf-8?B?QUpqL25YV0svRVp6b2dKc21SZHZZL3Vxd0trNnh3eVZvVDVzdWpFKzhhZ2FC?=
 =?utf-8?B?dzJZRFF4eUFtak1FcElwOTRNMEFyRVUxZzFpcTJpeGl5a296RG40TDFJb1dK?=
 =?utf-8?B?WHZNUkhFbEpSdHZMcFRacjUwTGRwb2hveFlDdEZFY29qV0Q3eVlCQkJXaEpn?=
 =?utf-8?B?Ync9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e3045e7f-8fb2-431f-1e63-08dc6eaab5ed
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:31:05.6988
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ngv3piF5IXzTZg+tTya3cXR5Infh+F674demqHgoIBYii5OoWrLCGE543J5ZbqZyqicwnVEsvtvKUZ9PaksqxCUVIN9Ccurl1gFDW8rw9b0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5203
X-OriginatorOrg: intel.com

On 5/7/24 14:39, Alexander Lobakin wrote:
> In fact, this structure contains a flexible array at the end, but
> historically its size, alignment etc., is calculated manually.
> There are several instances of the structure embedded into other
> structures, but also there's ongoing effort to remove them and we
> could in the meantime declare &net_device properly.
> Declare the array explicitly, use struct_size() and store the array
> size inside the structure, so that __counted_by() can be applied.
> Don't use PTR_ALIGN(), as SLUB itself tries its best to ensure the
> allocated buffer is aligned to what the user expects.
> Also, change its alignment from %NETDEV_ALIGN to the cacheline size
> as per several suggestions on the netdev ML.
> 
> bloat-o-meter for vmlinux:
> 
> free_netdev                                  445     440      -5
> netdev_freemem                                24       -     -24
> alloc_netdev_mqs                            1481    1450     -31
> 
> On x86_64 with several NICs of different vendors, I was never able to
> get a &net_device pointer not aligned to the cacheline size after the
> change.
> 
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
>   include/linux/netdevice.h | 12 +++++++-----
>   net/core/dev.c            | 31 +++++++------------------------
>   net/core/net-sysfs.c      |  2 +-
>   3 files changed, 15 insertions(+), 30 deletions(-)
> 

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>