Received-SPF: pass (google.com: domain of linux-kernel+bounces-171645-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f1e9ed0d-f05b-439d-9a11-2242443b485a@amd.com>
Date: Tue, 7 May 2024 10:02:15 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 06/11] Documentation: PM: amd-pstate: add guide mode to
 the Operation mode
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1715065568.git.perry.yuan@amd.com>
 <651c35dfa654b4331e597647b38a21fef477083e.1715065568.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <651c35dfa654b4331e597647b38a21fef477083e.1715065568.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SzJGam83Q2xFams1aFoycW9MVDlpSUYyT3RaanNNQ2ZYMXRSYXlBS0ViVmVu?=
 =?utf-8?B?QzdYeXNXZ1RCbzgxOFNLL3NvWk1jbExZWk96TXZvK0JYUUR5ZHRTTDQvN1RL?=
 =?utf-8?B?NjlmMEJQZmNMRGY2TWhlQ01rVjBCdzlOd3padWdpd0ZtMG8xVVFUTEVLM2pV?=
 =?utf-8?B?QzRuWHJKQkxCK0NVUEcyK29uZGJLRDc3V0VFSHdsVXRhRkMyRTFLRmJDbFln?=
 =?utf-8?B?SllkcFc2N0VSczc5bG1OdS9iMUVnOGZnejJhNnlZS1d4OThRUEl5N2tSTU1S?=
 =?utf-8?B?YTNkRVR5ZUM1TmFHT2dUYWVsaTZSRmdDaUc1UXp0UmlQT3MySU1QYVZha3VZ?=
 =?utf-8?B?cVpwdkdSTEpBWlc3MTlYTVJxN0tqSkhmbnZ0TUxkdlVnUXdnQVRqaGJQQlg1?=
 =?utf-8?B?UDBYOE55bFF0L2w2dStYN0NFM0VDT3M1UytHVDl3WHZaN1FsUEt2V2NnbGM2?=
 =?utf-8?B?N1h2UVN5OFlpYU1Gb2tzVkg5cUxPUmR4a2ljNmpiSjhGLzBLejh1V1ZHM0tD?=
 =?utf-8?B?TzM2ZGxYN1lQanlGc3ZsaUEvK3g3SlBwdG1PRjNtckhySEFGMHFrN3JXYTNX?=
 =?utf-8?B?RndPREJNWGhzS1EzazNpOVZWZWF5a09WVFZCN21hdjJ2a3hNaDFKUHlHTVBF?=
 =?utf-8?B?YmE1UW4vZkVyYmhzbnF5Qml6eVJJSWhiUE5MNDIvWkw4QUxOampyRTdya01J?=
 =?utf-8?B?YW5KZ3ZxU283Z2k0K3k3S3NONVdYUk9WV2M2aFU1a3pZSjBFbkprN0VEcC9y?=
 =?utf-8?B?bVBXQjRFNWdydUM5OStRSHRDcnFSZ1BKN3JsN3NTOTlMOHZCS2Q4UmJ2YVhu?=
 =?utf-8?B?aC9namVLejJHM2JuUXQvZnE3RDFINjdaTDRwa05QMzduWGFiS05BTWJxczh2?=
 =?utf-8?B?bUw2a0VmeTFWeHRCSkdYN2ZGRWhTUFFjeU1lV1VzVGh0alp5dTZRQnVvVE9S?=
 =?utf-8?B?bGtYVExadjVXbnJNZnVNL1RFUEE4cXRBZUVrNmptaHJBQ3ZkT216RjYwR1Iv?=
 =?utf-8?B?cjlYbVdJZVRUQUZndlNBWkpOMnY1UVVyMk5MNzNrUHMwcGN1cUhERXkxMjgz?=
 =?utf-8?B?akZ5V3pjWTMyMm1ySkNhZFU4eWEzK2xIdnVEMC9aYldNb3c0SzlmSmRESUo3?=
 =?utf-8?B?U2tYSGFUMXlXY0JuK3ZLdTZ3RVQzRTM4RDdZa2hCZ0pjRHEveUxoSWQvaWh2?=
 =?utf-8?B?THB2bUdyYkhERGVIR0Q1V1B4ZWFLNFpCZlZSYnFUaTJudUhGQ0RHYWpsMVpS?=
 =?utf-8?B?M2NieEVqQll3RVR4UnRXK1hXR0s4cEdadUZ1YllDYkM4RjhZZzNJeTlZS21r?=
 =?utf-8?B?U1J3SUQzdjE5U3dpeFRWYVNSQjRqUEpsYmIyVlJzTkFtOWd0OFUyK1hvTmlF?=
 =?utf-8?B?YWtNWEdvdncyM0dSbGNmR3hrZkJZVXFyQUdoN2VQcTJBSithTlJoUWNRVDYv?=
 =?utf-8?B?MVh0UXQ3MmplM0FXTUVSRXlwUUFILzJHaSs1Q2VJY0J4SnROUXA2d1E4MjZn?=
 =?utf-8?B?bXUxVktwR0dralR5K1hqY2pKVERYMXVDalM4WG5VWGJpaFkydVhwNG8rVnBx?=
 =?utf-8?B?ckpWbDVBa05MOE9yQUJjUStlNktOM3hoOWUySlV2WnFRRDYvL1o1MUtXNDBk?=
 =?utf-8?B?RlJJMEoyOVhuN0VuR0lESENaL3JreHNZdWIvZFRLMi9nWC8yU3BHUlphakQx?=
 =?utf-8?B?eHRzeVhVNVUvQzNQZnhjT1I0WkV0R3g2UnBCWWlWVDJVVllIVUQwMnRjcDkz?=
 =?utf-8?B?YTRMN3F1OUdxWGRmZE5vbXhkc2dMVGFYdm9heXhGaUx4Si9SLzVhUnFwZjA1?=
 =?utf-8?B?K051RUZ0K3lqSUZ0di9WQ1lZaUVvbWZ2ODRDWEVVZnlERDJMTUN4VFBKSXNq?=
 =?utf-8?B?eEtWMWNSaVNhSTBIWVNYbGc5KzA2VDRyY1krMHBJU1l6VitEdkZFYVp0Vno2?=
 =?utf-8?B?MW9JS3pMZ0FqZFpvK2x0Mlo1eCtyWGwwczYwSDdpVVRRellyTDNiWFlqZEtj?=
 =?utf-8?B?Tnhya0M5WDgzbWVHUTJxaVNvak1vNjBYOFhiQzNrTzhKSEZ0ZTVGRmlPTi96?=
 =?utf-8?B?UWN0SFp6bWJsZW4vRUxBY0JPdEREWW04Z0I0YlZUeENnMHljOTVHY3BKcTVT?=
 =?utf-8?Q?3WUi+W8Gg5U4oyCyEv/siPCzU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56b5bf41-b403-470d-3f96-08dc6ea6b080
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:02:18.7711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ww0fHHfNgFGCs8AeK35khsqHDVvGPeLRTlKqh5RSK6OExOHFnhGsCA87qkWIAaOdTU5EMoH/Siw2dhYmp1upqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6246

One nit for next version.  The title should be "guided" mode not "guide" 
mode.

On 5/7/2024 02:15, Perry Yuan wrote:
> the guided mode is also supported, so the Operation mode should include
> that mode as well.
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 230e236796f7..9fc924930595 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -410,7 +410,7 @@ control its functionality at the system level.  They are located in the
>   ``/sys/devices/system/cpu/amd_pstate/`` directory and affect all CPUs.
>   
>   ``status``
> -	Operation mode of the driver: "active", "passive" or "disable".
> +	Operation mode of the driver: "active", "passive", "guided" or "disable".
>   
>   	"active"
>   		The driver is functional and in the ``active mode``