Received-SPF: pass (google.com: domain of linux-kernel+bounces-171707-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 7 May 2024 12:41:12 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: He Zhe <zhe.he@windriver.com>
Cc: namhyung@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	irogers@google.com, adrian.hunter@intel.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf bench: Fix trap divide error of perf bench
 internals inject-build-id
Message-ID: <ZjpLmBvW0LqZET3U@x1>
References: <20240507065026.2652929-1-zhe.he@windriver.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240507065026.2652929-1-zhe.he@windriver.com>

On Tue, May 07, 2024 at 02:50:26PM +0800, He Zhe wrote:
> perf bench internals inject-build-id suffers from the following error when
> only one DSO is collected.
> 
> perf bench internals inject-build-id -v
>   Collected 1 DSOs
> traps: internals-injec[2305] trap divide error
> ip:557566ba6394 sp:7ffd4de97fe0 error:0 in perf[557566b2a000+23d000]
>   Build-id injection benchmark
>   Iteration #1
> Floating point exception
> 
> This patch removes the unnecessary minus one from the divisor which also
> corrects the randomization range.

Thanks, applied to perf-tools-next, and added:

Fixes: 0bf02a0d80427f26 ("perf bench: Add build-id injection benchmark")

To make sure this ends up being picked by the stable guys and
backporters.

- Arnaldo
 
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
>  tools/perf/bench/inject-buildid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/bench/inject-buildid.c b/tools/perf/bench/inject-buildid.c
> index 49331743c743..a759eb2328be 100644
> --- a/tools/perf/bench/inject-buildid.c
> +++ b/tools/perf/bench/inject-buildid.c
> @@ -362,7 +362,7 @@ static int inject_build_id(struct bench_data *data, u64 *max_rss)
>  		return -1;
>  
>  	for (i = 0; i < nr_mmaps; i++) {
> -		int idx = rand() % (nr_dsos - 1);
> +		int idx = rand() % nr_dsos;
>  		struct bench_dso *dso = &dsos[idx];
>  		u64 timestamp = rand() % 1000000;
>  
> -- 
> 2.25.1
>