Received-SPF: pass (google.com: domain of linux-kernel+bounces-171722-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 7 May 2024 11:48:44 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, Andrii Nakryiko <andrii@kernel.org>,
        linux-fsdevel@vger.kernel.org, brauner@kernel.org,
        viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org,
        Suren Baghdasaryan <surenb@google.com>,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 5/5] selftests/bpf: a simple benchmark tool for
 /proc/<pid>/maps APIs
Message-ID: <cgpi2vaxveiytrtywsd4qynxnm3qqur3xlmbzcqqgoap6oxcjv@wjxukapfjowc>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Andrii Nakryiko <andrii.nakryiko@gmail.com>, Greg KH <gregkh@linuxfoundation.org>, 
	Andrii Nakryiko <andrii@kernel.org>, linux-fsdevel@vger.kernel.org, brauner@kernel.org, 
	viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, 
	bpf@vger.kernel.org, linux-mm@kvack.org, Suren Baghdasaryan <surenb@google.com>, 
	Matthew Wilcox <willy@infradead.org>
References: <20240504003006.3303334-1-andrii@kernel.org>
 <20240504003006.3303334-6-andrii@kernel.org>
 <2024050425-setting-enhance-3bcd@gregkh>
 <CAEf4BzbiTQk6pLPQj=p9d18YW4fgn9k2V=zk6nUYAOK975J=xg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAEf4BzbiTQk6pLPQj=p9d18YW4fgn9k2V=zk6nUYAOK975J=xg@mail.gmail.com>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ek8zZzhUVWY2SjhTWCtFdWw5VGVETGYyU0JuVXpuWSs0QklaYU5KMFlTb005?=
 =?utf-8?B?Z1dKZ2N5c1JraXg1OWlKSk9JSEpuTXNGZG5wbnRIL3hDMERKZlZOaEFuQXpU?=
 =?utf-8?B?OEsvK3kzL2RRc2hEZThJOXlSTVZhOXVQazAyOG00cml6emo5YkJ2N0ZpZkdz?=
 =?utf-8?B?MWVva21WcmxKQ3pjcER2UjNOL1BUVEwreE5EYUdzbWlYRE4yakZ0a3Y2bnBR?=
 =?utf-8?B?OXM5NHlXQ1BuYWVNVFdIS3BxS3QxYUFibkdYUnlidmZMWkdZT1FGTndEWnJO?=
 =?utf-8?B?WkJkdzkvYW1ZdTJiNlZ5TTJMcDhMcEhZcU5WRWxUYWxWOENIWUdWRjl3MmEv?=
 =?utf-8?B?dGgxNnFMTms1dTZUNVcxdzBnRUh2cFRxbEhNZkdXc1MzTTA0aXZ5OXVPWjZU?=
 =?utf-8?B?UVlYWG9QakVqVXBWd2cwZUNSZkRiN3c3c0xIcEE1UzhzdmVtQzZSY2Raczhk?=
 =?utf-8?B?UnczMDY4U2paRktTL25YYXh4QUxWSzByWFl5cmNsT29hcjRmanJNM3k4TVlm?=
 =?utf-8?B?aGVrcHJjbmNIaE44anlzVEpMUGY5ZVk4dnlaUTZ3SE5kQUloR010Y0dLK0RG?=
 =?utf-8?B?am1GRG9vQ3FGSXZvTTV4T2N4Z0kzRXNacW01eU1uTlZrNW5QdjRBQXp5c09S?=
 =?utf-8?B?Z0FZWXJrbFl4MURNUkdCNjZxbHpOaFNjT01nZ0dFanFYR1JPNEN5ekY2RnRt?=
 =?utf-8?B?bnBVUGg2dUFlUHoxRzlnK2t5Lzh3ZG1sZkJEdmdvZXFpUDgxSVBBdDFkd0ZV?=
 =?utf-8?B?T2krdFNoV3lkbkl2a0UvMmdZWjg1RHNRbm9ZWGFtTFJyV09ZdXJFN3ovd1lm?=
 =?utf-8?B?VWFxOHViM1FZVm1jcVAwTEx6SG5uUXlJaVAyYmpBcDg4OHpuNWNRV1NlTElm?=
 =?utf-8?B?cGpkcUIrbkM5bFVCUWVlS0F6RDFDRUtNWHRuMnl1Y3dtSnNaOXU4dDJrcFB2?=
 =?utf-8?B?WmFibFZiaU5EYW5kdkxQT3ZnZ1J1eGN3YVVvVjhmNUdGcDQyRWY1eDJPM1Bl?=
 =?utf-8?B?WXZCVUpXZVA5R0JGZ2ZkY2tZSXlYbnlSSy8yMDB0cTdMYTdjSi9TZGJpT20r?=
 =?utf-8?B?Qjl1M0kycEovMGJIKzg5N2wwUDhCY1NyeWFmSE9nQWFuRnBRTTlsSzlqNVNQ?=
 =?utf-8?B?UEZ2bnlsZE9TMDZQTGZjVjF1aXE5YVRBc2hoUlg2TERET3E1MnAxMEZZc2Zu?=
 =?utf-8?B?Sm10eExBcWUwcDQ5QTdTUThYQWljb3BOTm1mVUt3d2tLNVdHK2M4UzZqTE9D?=
 =?utf-8?B?Qk1aZTh2OUkxckIrL3J3UHpLT0NmZThCN28xWkprNVhnYjNnUlUxSGNnMWor?=
 =?utf-8?B?bXZITDFPSmZRUGZtMEswQ3Z4ZkYzZWxmYUpsOFJUMEpicDBnNmtYL1Z4R00r?=
 =?utf-8?B?WTYzbk1mZHZuRkpJWkg4RnFITTl2VkpBVTZiUW5VUG5JY0NJM0VBRHp6QzBj?=
 =?utf-8?B?Z0RmMVQwVi9DZHRTOWxYajI5T1hpWTdZVkR4Nk1JWkRBaGphRFJuRDhCNjI0?=
 =?utf-8?B?aWN0M2grM2FtUkFNTGl2ZTlFMXdLc3VFenZxdzNTOWoxcVQ1TEY4TnRYUGdz?=
 =?utf-8?B?NzVwVzJFUXNML0lPL0R2M2FCZTN3NEtZUTArWGlnSytxVk9FZitoVjNzeEZ5?=
 =?utf-8?B?UW5WZjFLTE5KNGhoaFpRcEF5MHlrczJjTXFrRjc0ZElFVVVQNk4rbEFGUHpU?=
 =?utf-8?B?bkdGYUk1VkNoSWRjb2JiaWdWQWU2K0tIZityYkdZd295STcyL01SMks0RFVI?=
 =?utf-8?B?dFV4RzVUanZuUUcrRkVsUlFGeVFaMDQ3MzNQWEFyTUJ2bzlUZ3VIeThqbTMr?=
 =?utf-8?B?Q3B4MFFXSmhORFZFUWtTeDk4NjVkNTZ2L3ZRZG40ekF2VU1FTUozSFo0cU8w?=
 =?utf-8?B?L3dCaXlPYW82cnpSUVI4YUplVUN5RWxsWVBWWnhoY3kydWt2NEdnbGYweVpr?=
 =?utf-8?B?Yi85R0plUjRlRnZXMlFydXBocXhNcWR5N0F0SDk4YkpRbXZQU1E4WEtwM1hi?=
 =?utf-8?B?T3hHUDRqK2FGMnhjai9sQ21qdEI3RE5ZdytEM0RTdUt1Wmk1QzBWNHhYUGdE?=
 =?utf-8?B?eXRvQnI1REJnVThMWlZCYlFoU214a1VyemFsWGVXZTAwVnRIODdJUTFXc1Y1?=
 =?utf-8?B?dkdGS0EzRzR1UTBrS0tIV0lPQ0VqRHpEWitiZzFveTNXcUh3a3MvaDJzWUxS?=
 =?utf-8?B?N2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	lhfufBFwNIYQQPkiv+noQe5wOULkNgNz7TWX0eIzgmCiwVnobCoj1dDL/RDM54vBG6hYF9TGv+V65QNoCQ8YnCYTheDZ1QFKZacP012nWUv7VqqIir86H6cSTyflNqYuuCtE57xbc/EQPRykAGn4XM49qe7mglvuBmRhxXHt2fX4hAUVif2DLVSz+e7yF7+Ya5MeZ9K3teSwqyBxyAMRiJz5lkwsXYHi3/2ny2yAj7P1D8jpp58osIakotxcAVqq++6lDirS57P/ORm+AoqX0ygDknsP0bEn3ihIdhxN1bOTqWBh9ZOs4uIxzpFiFQOac36pAtVses2nWWJyYp9aa7Kfidq8qkEDOKVX8m9fHNrO6izzbObUGcJbuZcRnmcbCaKsmsat2mu0wDA1mzqviG/GA7EGSiWsJtCUx9K8IiyVoEtNuTsCJJVp2RYOVq8VDkUCOz1+mFh+9GruellFFU43Tnzo2tKdY26w+Xc4sWgxdP8lDUt+XRLJfn2/mdDFU/24tbOi470pjwFaAWpMhWSsrmd3Fn52zrNjocOeBy0si9wHPQ60GJazbwjDvYNj8A6gVJSrqIu6dIIFUV/9nFOTWlKONblm3ZnWflfyI8A=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5acedd43-cecf-42a7-7965-08dc6ead2f1b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:48:48.0461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bGggUrZ91/rRY7LBMXNxqqN6d8MdyUahwI0NAtjxFhUnwPv1hVdWUS/HM9JZSVyj2keTKmK+ppTXH/SS/SUuEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4477
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-07_09,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=769
 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2405070110
X-Proofpoint-GUID: OgVLpUgyFtXr9rRsPimLNJFBmYYw7BpS
X-Proofpoint-ORIG-GUID: OgVLpUgyFtXr9rRsPimLNJFBmYYw7BpS

. Adding Suren & Willy to the Cc

* Andrii Nakryiko <andrii.nakryiko@gmail.com> [240504 18:14]:
> On Sat, May 4, 2024 at 8:32=E2=80=AFAM Greg KH <gregkh@linuxfoundation.or=
g> wrote:
> >
> > On Fri, May 03, 2024 at 05:30:06PM -0700, Andrii Nakryiko wrote:
> > > I also did an strace run of both cases. In text-based one the tool di=
d
> > > 68 read() syscalls, fetching up to 4KB of data in one go.
> >
> > Why not fetch more at once?
> >
>=20
> I didn't expect to be interrogated so much on the performance of the
> text parsing front, sorry. :) You can probably tune this, but where is
> the reasonable limit? 64KB? 256KB? 1MB? See below for some more
> production numbers.

The reason the file reads are limited to 4KB is because this file is
used for monitoring processes.  We have a significant number of
organisations polling this file so frequently that the mmap lock
contention becomes an issue. (reading a file is free, right?)  People
also tend to try to figure out why a process is slow by reading this
file - which amplifies the lock contention.

What happens today is that the lock is yielded after 4KB to allow time
for mmap writes to happen.  This also means your data may be
inconsistent from one 4KB block to the next (the write may be around
this boundary).

This new interface also takes the lock in do_procmap_query() and does
the 4kb blocks as well.  Extending this size means more time spent
blocking mmap writes, but a more consistent view of the world (less
"tearing" of the addresses).

We are working to reduce these issues by switching the /proc/<pid>/maps
file to use rcu lookup.  I would recommend we do not proceed with this
interface using the old method and instead, implement it using rcu from
the start - if it fits your use case (or we can make it fit your use
case).

At least, for most page faults, we can work around the lock contention
(since v6.6), but not all and not on all archs.

..

>=20
> > > In comparison,
> > > ioctl-based implementation had to do only 6 ioctl() calls to fetch al=
l
> > > relevant VMAs.
> > >
> > > It is projected that savings from processing big production applicati=
ons
> > > would only widen the gap in favor of binary-based querying ioctl API,=
 as
> > > bigger applications will tend to have even more non-executable VMA
> > > mappings relative to executable ones.
> >
> > Define "bigger applications" please.  Is this some "large database
> > company workload" type of thing, or something else?
>=20
> I don't have a definition. But I had in mind, as one example, an
> ads-serving service we use internally (it's a pretty large application
> by pretty much any metric you can come up with). I just randomly
> picked one of the production hosts, found one instance of that
> service, and looked at its /proc/<pid>/maps file. Hopefully it will
> satisfy your need for specifics.
>=20
> # cat /proc/1126243/maps | wc -c
> 1570178
> # cat /proc/1126243/maps | wc -l
> 28875
> # cat /proc/1126243/maps | grep ' ..x. ' | wc -l
> 7347

We have distributions increasing the map_count to an insane number to
allow games to work [1].  It is, unfortunately, only a matter of time until
this is regularly an issue as it is being normalised and allowed by an
increased number of distributions (fedora, arch, ubuntu).  So, despite
my email address, I am not talking about large database companies here.

Also, note that applications that use guard VMAs double the number for
the guards.  Fun stuff.

We are really doing a lot in the VMA area to reduce the mmap locking
contention and it seems you have a use case for a new interface that can
leverage these changes.

We have at least two talks around this area at LSF if you are attending.

Thanks,
Liam

[1] https://lore.kernel.org/linux-mm/8f6e2d69-b4df-45f3-aed4-5190966e2dea@v=
alvesoftware.com/