Received-SPF: pass (google.com: domain of linux-kernel+bounces-171690-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5fc36c91-1552-4929-8fac-c76b217e1c03@amd.com>
Date: Tue, 7 May 2024 10:23:30 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 10/11] cpufreq: amd-pstate: fix the highest frequency
 issue which limit performance
To: Perry Yuan <perry.yuan@amd.com>
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
 rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com, Borislav.Petkov@amd.com
References: <cover.1715065568.git.perry.yuan@amd.com>
 <c8feaf14acbe2e8288a5e8e927b8da479819bc71.1715065568.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <c8feaf14acbe2e8288a5e8e927b8da479819bc71.1715065568.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YnFrYk03M3o5ZWNTTXp0a1BDYkR4RS82QjhVcnlyS0ZPeTRsR3UyNSthK1VL?=
 =?utf-8?B?eUxzc0pjWGNrZ0lvYUE4MjVxczhaSHd6QWszUStGYnFtb051ME5PWXU2Wi9j?=
 =?utf-8?B?Q01WbkxEVkRPNEJxR2N5MHdvS0F0ayt2Z0hrK3dlbU9XSURmRmpGQkVaYVVT?=
 =?utf-8?B?RWRFUUxnRDk4Z0dpVkk0L3V4UFFkL01VWDh6TDNiMlpJdktUbUJDNlF1NW5D?=
 =?utf-8?B?MFk0bVVJaFpmZTdZbEtadXVOUGdLK3cwdEJ2cDVxVXhqMmx3T3duOVd5R01V?=
 =?utf-8?B?TE0vc3c3QVJiKzFPZ3krckZRbnYwRVd1Z2dKVzhOaklZUDgvMW93RnM0NXh0?=
 =?utf-8?B?bFVyOXVSWTFxMy9LWWozME45aGorY3k5UnY4Q3c0SFpGWHFwVFlFdzJta2JK?=
 =?utf-8?B?Nkd5SDdOeCtHamNvMWFuand2b21TUHJNUVFiaFBCT2h5cGpuNmlIaWhoSjA3?=
 =?utf-8?B?L0hSdzlRbUxHb1VWc2tSRk10czNHZWVNM1M5bFNzcy9rZjFhTWdjSFZPek5v?=
 =?utf-8?B?R04waFZKcndyTzRYN0k3WnVhQXpWZmpNTGRuNXRJd2pjbWxEcCtsR2dsdzl0?=
 =?utf-8?B?U1VOWnBaeG5CRDNrejh4blM0YlROMURxR1JNbXZGNS9KREkyR3JienFGUzhE?=
 =?utf-8?B?bGEwakR3UjZvWjlaKzJCUFEzQVBGNnFUMGlCV3JVNTdKd2ZaTlZkeUsza1NH?=
 =?utf-8?B?b3Y2c0VhV09UaWxYbzNHQldwclhMNEdGY0JiL200QU9JRjVFd283KzBZc2ZB?=
 =?utf-8?B?bFJ0bGhRNnkvbEk4RmhJZ0VFSjlTTSs0WVUzMXlpOHplOVhrVVFOcm9lYUFY?=
 =?utf-8?B?OG9NWVpaQ2N0ZUV1Z2gvQkpLNW5Oem42QjV1UERIcEFjUTNZcCtZRFhyT0N3?=
 =?utf-8?B?UXVBbm1YLzVUZDBhRnBFZ2NsVmhFS05wNzdvNzJUUkt1WmhITkd4eXNNNVdq?=
 =?utf-8?B?UVFUOW1pMjgvS3hSRzhzSDlSanl6T2tRSUszbldTaXFBR1VlY245cGJkbzY4?=
 =?utf-8?B?cnZuVmNWZWFCZ2hiNEhMNEM4OEhkMHpiWDhDVmE4eXNna3VHbGhEaEJlY3ZP?=
 =?utf-8?B?NWhGRE9IcXBkemw0dytKRVFxYmZsSHpYWnFGRmtjTHpKdDBtRnNpMzBHenBn?=
 =?utf-8?B?N2o2WTRpQ1hSTGwrWGFBQ09ac1BzQUlEUFdFTk9sWkpQSFlHSmcyQjl1UXgr?=
 =?utf-8?B?b3JzZjhiVEk5b2VVUzFkWEJEY255YlMzMnZLZkJTZjQ3M28vREF6RDV6Y0FZ?=
 =?utf-8?B?TUlKaXJ6cGRQTSsvREtjcVRjTjJlMzgwajFrZEczZ2hGQXV3ZWtIWnZ5N1hV?=
 =?utf-8?B?emRZUEIyY0c0VkJCNm03b0g5TzFQRXhXWWtkVG9DQk16dVNyYjhMZndPRmZ6?=
 =?utf-8?B?RFJCanlNckFkQ1BVZzlhMVZoNENkN3BIbFBQekh4SzNnSWxOSDJBWE55dmcv?=
 =?utf-8?B?R2pRTzdWR213YjZaa2EwcVRFdlJlM3BpUytnMlRtVzhsd1U5NXU3bUdrVmtq?=
 =?utf-8?B?dmxnaSsyZ0tlQVJ3VVY4bndUWDV6cG5sak42SVZyZkZHcm9EYlQxRjNNcGJD?=
 =?utf-8?B?NWYvamN0TnhBcys1dnZjell2RmZ5UlM2SWlRcVNSRWhjdjJMMGlXUmpZL2RN?=
 =?utf-8?B?ZG1pY2Q3YmRPdTIwQkczcGdXZ1Ezak9MVWFrYVNHM1kvUUhUZndzNk5RTGIv?=
 =?utf-8?B?QkY5ZVhWSEFrelJUbDh1eTgyUTZ3b1hLbkIzOVBPbUlEOEpqaUZNS1Vuc2xj?=
 =?utf-8?B?S1hZTXFRUkF2cCsxblI5WTNacG5oNjluT1BRUTg4VWkrMlpaczc5OCtnUHpC?=
 =?utf-8?B?R0FWd2hLMGd2YTJjSDNaNlBDSWUrNVdVNDIwaXdxUlh3MlAvajdEZ3M3NUxi?=
 =?utf-8?B?ZElWOU9ESTlhMEJuOVp6MFlld2RzaG5Yb1Q1YlZmQ2YrN0xJZzMrRnVxWFBk?=
 =?utf-8?B?VkJIVFZoQ3hTamR5ZE1ma0gyZUdSSHRhd0llQUQwb0JScUlzbDRNeTQ2U3ZS?=
 =?utf-8?B?UjJSRWpubWl0R1lTekFUMEFFa1R0RDFwM1hEam1sY1h2cWtCRVRzZHVYK0oy?=
 =?utf-8?B?TWNxQ3RCUUQ2SjYyY3ZmaU9jMk5PcWYxbUFpOWI5cktHRi8xZWtma3doUEdz?=
 =?utf-8?Q?kgDaJWaeActDwL+E59YM40Qf5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a78d553-9076-4afd-0279-08dc6ea9a91a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:23:34.6700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2NVVoBu0GH8uAUwT5j+1xYl1FdxWuG3uNtQkeLIJRGdJOXzsT9ZZUI7Ek4LYanLQ1zdFwMqvPCt6HK6hoijFIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6700

On 5/7/2024 02:15, Perry Yuan wrote:
> To address the performance drop issue, an optimization has been implemented.
> The incorrect highest performance value previously set by the low-level power
> firmware for AMD CPUs with Family ID 0x19 and Model ID ranging from 0x70 to 0x7F
> series has been identified as the cause.
> 
> To resolve this, a check has been implemented to accurately determine the CPU family
> and model ID. The correct highest performance value is now set and the performance
> drop caused by the incorrect highest performance value are eliminated.
> 
> Before the fix, the highest frequency was set to 4200MHz, now it is set
> to 4971MHz which is correct.
> 
> CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE    MAXMHZ   MINMHZ       MHZ
>    0    0      0    0 0:0:0:0          yes 4971.0000 400.0000  400.0000
>    1    0      0    0 0:0:0:0          yes 4971.0000 400.0000  400.0000
>    2    0      0    1 1:1:1:0          yes 4971.0000 400.0000 4865.8140
>    3    0      0    1 1:1:1:0          yes 4971.0000 400.0000  400.0000
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218759
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 7fe8a8fc6227..3ff381c4edf7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -348,6 +348,7 @@ static u32 amd_pstate_highest_perf_set(struct amd_cpudata *cpudata)
>   {
>   	u32 highest_perf;
>   	int core_type;
> +	struct cpuinfo_x86 *c = &cpu_data(0);
>   
>   	core_type = amd_pstate_get_cpu_type(cpudata->cpu);
>   	pr_debug("core_type %d found\n", core_type);
> @@ -355,6 +356,13 @@ static u32 amd_pstate_highest_perf_set(struct amd_cpudata *cpudata)
>   	switch (core_type) {
>   	case CPU_CORE_TYPE_NO_HETERO_SUP:
>   		highest_perf = CPPC_HIGHEST_PERF_DEFAULT;
> +		/*
> +		 * For AMD CPUs with Family ID 19H and Model ID range 0x70 to 0x7F,
> +		 * the highest performance level is set to 196.
> +		 * https://bugzilla.kernel.org/show_bug.cgi?id=218759
> +		 */
> +		if (c->x86 == 0x19 && (c->x86_model >= 0x70 && c->x86_model <= 0x7F))
> +			highest_perf = CPPC_HIGHEST_PERF_PERFORMANCE;

I agree this is the right type of change to make for the reported issue, 
but since it's actually a performance regression from 6.9, can you move 
this to the start of the series and add a Fixes tag and stable tag so we 
can get the regression fixed for 6.10 and 6.9.y?

This will of course mean you need to adjust patch 9 as well for such a 
change, but I think it's better this specific patch goes into 6.10 as a 
fix and the rest of the series can aim for 6.11.

>   		break;
>   	case CPU_CORE_TYPE_PERFORMANCE:
>   		highest_perf = CPPC_HIGHEST_PERF_PERFORMANCE;