Received: by 2002:ab2:7104:0:b0:1f7:f6c3:9cb1 with SMTP id z4csp53154lql; Tue, 7 May 2024 09:30:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWGARS4eKfx3Dg09IKDsW6pOIQgtmZ/Yr+3xUNfSbHXN7LMsnQDCuNZ3+n1cN3c+2RpR8vkr0Ex6GBeVD5gDh/N+wqFisfP4+XnDuEJEQ== X-Google-Smtp-Source: AGHT+IHWaztCkM4n7WO9iME5XAVmHyqo8ItaAt7oV6Rm4hGOzBoI5uqF7ox8tSYQAGXwPFu8ZJ7W X-Received: by 2002:a17:90a:b108:b0:2b2:6de2:cdc7 with SMTP id 98e67ed59e1d1-2b6165c1905mr89565a91.20.1715099440174; Tue, 07 May 2024 09:30:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715099440; cv=pass; d=google.com; s=arc-20160816; b=nv2qSmcg3HeE5BpAgQdNfjkumfaBKoS/zG7TkyCty2nH5lof6nbNYoWUjj5IOKQ4fg b3mXlZn4TCQJ8Z8Bz4oY1y65cq9zTfTbsIAVtWXp0Ly3irJ3IOMKeTrYOwrrN/n/wQIt z12BDQAy3R1SCyEc4aXFZUIoRY/qTQ+Nz7/z+zKxHh5fG5zDhwU1nYiNaqKfPn73Ml8P mhNxnz6XYtOJPL7pDJo/vGiReN5vl4GZ7uj7YGHL0nTWMO3r+quKX/0fSAsV3cbkAPjf Ij2IeN+k6LVGwGuT7lqHPYVT+aEd2glaeRzOOU1uQx6ye+0Yq+2+Fr4l9KJsiHHhnfFN RI9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=tgzIR0YD+S9uWGtbeF9+1URxHxfb+Er2kUk5GWowswQ=; fh=8jTBdTboRgXEV6LgnpY+3jkc910uslToVawfEsn12ms=; b=Sqzv5M7KNthTcf4k4tJQqIy+jsQNT4rDipFUin2Cng5GzKDfLWPua5MDnzkezXqcZA Oa6oWHGZIOM5PVQN6of/4YyJuYK56aCAFgTFaB72Zy/CpvSnbYK8Gbxjff/hpqsoc4y9 G9DiTeIVJkHsqnYmdXegG8/NZ+RcJ2Seyh2kPmxIYq2PqGK9JsY25PzhmHzNov8qhH/f XS9Fq/RwgQH/Fz4dIIFc+weNbkCB+FOIfiRe3f3+Hzy5YISv66wxpo6lJQS00j7/jUPK k63kzmKaeZk04UFeDGrSD6+hf+Rum0xTgCI0BRXtwnnanBm+4v0XJU+hX4uqZbrboV7u qojA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=GYgFcoZF; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171772-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171772-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ne23-20020a17090b375700b002b44e772e84si8640866pjb.99.2024.05.07.09.30.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 09:30:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171772-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=GYgFcoZF; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171772-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171772-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ADDE828F739 for ; Tue, 7 May 2024 16:09:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B74FD15FD19; Tue, 7 May 2024 16:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="GYgFcoZF" Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5415413CFBB for ; Tue, 7 May 2024 16:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715098191; cv=none; b=cumuQ5DKcq/a6FpjOeC+njvxE9fAf17kHDdB94tQhUtbHgOPlRa6TM0d0OizQYHCZbEMiU2m1thqAU3Q2kvqisXSPH8FekcNl9/7QodSGeRtEaLZKBd67fq+bYGNlgV+AT5W2E+jxxGa8qZClkdwO1rxUx3ISfu2QocZAFu3l9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715098191; c=relaxed/simple; bh=gz4Jf3ondj4y4dpkh3Y5gyLp2dfD3A5nAdCohPabPh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h5bko0wb2xlEB0yykhzZZ6JiewGQXNIdUlDasjcKIOb10y4OXxbvGnc4aRPTMrHNli2B6vW5eT9KiqjYomyuLbx6gSkTqDJ7ZxvfsSp1Yqslx0LgjB76Q49FoiD3LAecSlABoiE2foIPaKhy9HMhJ8oS7WQ2UU8HdzJ8ChzzN/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=GYgFcoZF; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Tue, 7 May 2024 09:09:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715098187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tgzIR0YD+S9uWGtbeF9+1URxHxfb+Er2kUk5GWowswQ=; b=GYgFcoZFHdDT9O8zbQNUuBjwrw3TYPWDPuV7kfu2wxM2XY5R/zlVAaa7+/VEnmVBOaXaOb Bd0uwhVVj08huf6sHJBxSAABdmpRTNwO1UiflcVyljF+6UECf8ZIY5GV0zvOtF8p1wxO/L WOxNDSZLD9HnbXit5a7NqNimo/JxiqA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Xiu Jianfeng Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool Message-ID: References: <20240507110832.1128370-1-xiujianfeng@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507110832.1128370-1-xiujianfeng@huawei.com> X-Migadu-Flow: FLOW_OUT On Tue, May 07, 2024 at 11:08:32AM +0000, Xiu Jianfeng wrote: > Currently alloc_mem_cgroup_per_node_info() returns 1 if failed, > make it return bool, false for failure and true for success. > > Signed-off-by: Xiu Jianfeng I actually liked the previous (ENOMEM) version slightly more, but this one works too. Reviewed-by: Roman Gushchin Thanks!