Received-SPF: pass (google.com: domain of linux-kernel+bounces-171863-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e4ad92b88556f0de05b6b7ae03da1e581d688ce5.camel@linaro.org>
Subject: Re: [PATCH] clkdev: fix potential NULL pointer dereference
From: =?ISO-8859-1?Q?Andr=E9?= Draszik <andre.draszik@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>, linux-clk@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Russell King <linux@armlinux.org.uk>, Michael Turquette
	 <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>
Date: Tue, 07 May 2024 17:42:45 +0100
In-Reply-To: <20240507064434.3213933-1-m.szyprowski@samsung.com>
References: 
	<CGME20240507064445eucas1p1bfc17da4f824ef46567774634482f12f@eucas1p1.samsung.com>
	 <20240507064434.3213933-1-m.szyprowski@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3-1 
Precedence: bulk
MIME-Version: 1.0

Hi Marek,

On Tue, 2024-05-07 at 08:44 +0200, Marek Szyprowski wrote:
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index ddacab7863d0..d2801ae70e34 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -194,10 +194,12 @@ vclkdev_alloc(struct clk_hw *hw, const char *con_id=
, const char *dev_fmt,
> =C2=A0	return &cla->cl;
> =C2=A0
> =C2=A0fail:
> -	fmt.fmt =3D dev_fmt;
> -	fmt.va =3D &ap_copy;
> -	pr_err("%pV:%s: %s ID is greater than %zu\n",
> -	=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &fmt, con_id, failure, max_size);
> +	if (dev_fmt) {
> +		fmt.fmt =3D dev_fmt;
> +		fmt.va =3D &ap_copy;
> +		pr_err("%pV:%s: %s ID is greater than %zu\n",
> +		=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &fmt, con_id, failure, max_size);
> +	}

It might be nice to still print the rest of the error, so it's easier to se=
e which
clock is causing trouble.

Cheers,
Andre'