Received-SPF: pass (google.com: domain of linux-kernel+bounces-171871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f44c76ac-3dc1-45d6-b435-e5b77b708d6e@cherry.de>
Date: Tue, 7 May 2024 18:48:46 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon
To: Heiko Stuebner <heiko@sntech.de>, robh@kernel.org, krzk+dt@kernel.org,
 conor+dt@kernel.org
Cc: andy.yan@rock-chips.com, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org, Heiko Stuebner <heiko.stuebner@cherry.de>
References: <20240506124632.3621378-1-heiko@sntech.de>
Content-Language: en-US
From: Quentin Schulz <quentin.schulz@cherry.de>
In-Reply-To: <20240506124632.3621378-1-heiko@sntech.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bkxQS2hJWkRjemo4MS95M3Vsd3Q2RGNza2J2UW5BS0wrRWZhMHRNa2h1WW5k?=
 =?utf-8?B?UXF0QUY0ck15Vk96dWZCSk50cTlmeU5ONHVwMWFRdTJsS1JqYVpXTmZDMm5X?=
 =?utf-8?B?L3FNQmZraGVFME5PN3FxbS9ldHBEUU12SjlrMlpZOUNSV3dpa2hPdU90MWFY?=
 =?utf-8?B?eHE0WnpiaHVuMkZtYlRxdXdGSjBmSUFMeWM4NEt5dlp6Q3QrM3lUeGV6QXIw?=
 =?utf-8?B?QStXUUFuN0NwbkU3UzRSSmNmL1lpZjducEdHVzVJdFhUd2lGbW42T2twb0dm?=
 =?utf-8?B?NEs4RVdFU3gyM24yL2tiZ0VtTUR3ek5ONCtWeVYyQ0VVNDZzLzJWbElBMkJR?=
 =?utf-8?B?bHNHVkNkM2NHZXlKdGhJTzdyRUM1Wk9MTVpFMzUzRlBib1RBMFkvZENDZ00x?=
 =?utf-8?B?bnpkZXhKRTV0NU1mZjlJNjhMZkowalBpSXRNUnR3VUh4Y1RMeEZGellqOFBR?=
 =?utf-8?B?ejRna2VnaldoNUR5WC9MZTVoMmFseE11TlRlNUFaRGJPME8wMEVmUGhVVndD?=
 =?utf-8?B?QWdhb3dpTnUxZHVveGxaVmFKV3d2eC9uSERpU1VWWDk2WjVnRk1XWXNLVGVW?=
 =?utf-8?B?aW9BQzdTbWdic1dqMXlRcVB2S1V1OEdYRGpKQjJhZDNwSEZjdFh3dytXMlh4?=
 =?utf-8?B?TFQ3KzVhbmM1YjV1WEZGcVhCVWU1blhvK2FmQ1ZpczlRVitCRW5WRFlhMURq?=
 =?utf-8?B?cUd6OHJFRVBKa2NEby9LZWp2S2NrdXJaTURLaWR6ZWlHRWdlN1pNOUNFQ3Ar?=
 =?utf-8?B?YURjNTRQV2JsVnVZaVM0M25UUXZsV1hIYXM5L1VwSnBCSktlL0lKc1VKUlRN?=
 =?utf-8?B?ZHpSQ0NIR3JrLzZpMjVPSUNMUi96djduRlFBKzlTb2hlMkx2bHVqaDRIeUJS?=
 =?utf-8?B?a2ZUZGlYNG5ZRXJLRG84dHpBUXR4U2J1czZhMmxwYldjc3d0WjEzRmxScE1N?=
 =?utf-8?B?S1pMYWt2WTdteXliYW5abXBZN1FKY0lUNjZBV0NnNVlXdEtDUmc5eEtxWm02?=
 =?utf-8?B?cVV5RDJNajdBMnVEdjY1Nm1HT21UY00zM0NXTVlqVUpVcENBQjJpelVHYTZ1?=
 =?utf-8?B?MmcxV1ZqM2RYanN1aWQ5ODdKTjdXTFdaUEViaER4YkxxRHZGd2toZnZnZjYz?=
 =?utf-8?B?ay9vbnVjSVNtTWlCMlZiQUlPVThwUmJMMVNHQ2hmM1NOMjlvczVHZU14UjNp?=
 =?utf-8?B?cm9WTGkxend2aFVaVDE4Szc3QlNHK0tVU3BPZW9lbHZsL3lNYnFWWkNKUTh3?=
 =?utf-8?B?ZCtVbFUyQTZEWlh6N01LSlJ0QStQbnJ4NFNkUk1KWFFsL3g2YlkvSmRwczFa?=
 =?utf-8?B?ckxDVGFFZUY0R01tWk5hbUFNTHZqRUJSSG9jUTM0UkFXY2RjYXlDaUZqNEk2?=
 =?utf-8?B?Mlk3VUdwTURnOWcycjVRWkpPN3pDVGhBYVNtVHVROTdxVytuU1N6MS9rT1Yx?=
 =?utf-8?B?N0NEcHk1aUZPZ09LN2UwSDhZMzQxQVY0TFpRWnJCUG9QaXltV2svMWZkWUtw?=
 =?utf-8?B?YTd4dmt1M3ZGcHVEdFR6VDg4TVljN0twZXI3eWlHYjdTTEhZbEdOOWd1Q05u?=
 =?utf-8?B?bHR4VjRCdm1aTVRuTklndXZzN0k2bnBIdjdrL2s2ejU4T29pSFkzb2hYUWNx?=
 =?utf-8?B?MkZiZUJvQnpKRjdzc0dVanNyQWY0WkdMZlZtNzZtZCszU2pUbVN2VEIrY3Nl?=
 =?utf-8?B?RzR6dFRCKzRYTDZmemFOVUtVQ0k1NWVxQWJvWVYzLzdsMHFrazRwK2pSdEJs?=
 =?utf-8?B?ZjhjZVkrdUsrNXgybjM0V3dHTEJYbkhZS3dYbTRNUHk0Qlp2SkNsV09ES1Jt?=
 =?utf-8?B?K0U0bis4eWpXVmhzWUFpWWdzaTBHUkIxTjFsRU1VU1RzZy9xUzh6aExUYTR6?=
 =?utf-8?B?UXR6N3puMkZPSWN5Nk5HeUxJa0l0SkRKSDBHMW1wTkQ1eXB1V1hQOGtHYXov?=
 =?utf-8?B?ZnBXaTVNR1B2T254VVpWYm5VMWhZTTE3d2xOMUtMOFRQbGJPYmN4UCsyMU9J?=
 =?utf-8?B?MUhzc0hCenpxbUVFeVpTZWJqdGx2RDBNNFFVV2JHT2x0VXNWQXd1RFNZcFRG?=
 =?utf-8?B?UEhUc0p1dTVxK0xOWGlSNTNxU2d4ZnJTSGZtNmEyeDFaTzVtUTNIcFl4K054?=
 =?utf-8?B?R2VHWWVSdGpWdkxrR1czSmJncEhOd1grY2xmUVY2U0piejlielZEcVNnaHRi?=
 =?utf-8?B?T3c9PQ==?=
X-OriginatorOrg: cherry.de
X-MS-Exchange-CrossTenant-Network-Message-Id: cf8baa57-1ec7-4abc-4b5d-08dc6eb59150
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB4842.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 16:48:48.7938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RfbkMbxQvCfEL/P5tZ7w7utd+KFtLqPLrS3GhUScenb4d8qHyXPwrVjvCmPYW+MBK35fY3nbYHeGplM5LfJfwOyBz2hbaJxTdG8+0Gc1lI8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8811

Hi Heiko,

On 5/6/24 2:46 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
>   Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 0b87c266760c6..0131c62893450 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -22,6 +22,7 @@ properties:
>                 - rockchip,rk3568-usb2phy-grf
>                 - rockchip,rk3588-bigcore0-grf
>                 - rockchip,rk3588-bigcore1-grf
> +              - rockchip,rk3588-dcphy-grf

There are two. While the TRM states:

"""
There are two MIPICDPHY_GRF modules in RK3588.They have different base 
address.
"""

(ignore the typo :) )

it states the same for the bigcore grf but we have two bindings for them 
in there... So not sure what to go for here? Similarly, pipe-grf has 
three instances but we define only one binding...

So who knows :)

That being said,
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin