Received-SPF: pass (google.com: domain of linux-kernel+bounces-171891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <edca87be-d8a7-4c62-b9c1-f9b3f5752595@nvidia.com>
Date: Tue, 7 May 2024 10:05:49 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] selftests/netfilter: return a value for several "int"
 functions
To: Felix Huettner <felix.huettner@mail.schwarz>
Cc: Shuah Khan <shuah@kernel.org>, Phil Sutter <phil@nwl.cc>,
 Pablo Neira Ayuso <pablo@netfilter.org>, Florian Westphal <fw@strlen.de>,
 Max Lamprecht <max.lamprecht@mail.schwarz>,
 Luca Czesla <luca.czesla@mail.schwarz>, Xin Long <lucien.xin@gmail.com>,
 "David S . Miller" <davem@davemloft.net>, Paul Moore <paul@paul-moore.com>,
 Richard Guy Briggs <rgb@redhat.com>,
 Boris Sukholitko <boris.sukholitko@broadcom.com>,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
References: <20240505214716.62304-1-jhubbard@nvidia.com>
 <20240505214716.62304-2-jhubbard@nvidia.com>
 <ZjjsGW314qCgpTKs@felix.runs.onstackit.cloud>
 <b20d43d6-8d01-480c-af1d-90c0acd35d5c@nvidia.com>
 <ZjnoFfkyREHWUPtq@felix.runs.onstackit.cloud>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <ZjnoFfkyREHWUPtq@felix.runs.onstackit.cloud>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bXlMWXI1Z1g3blgvanI5MDBLNHlCWDZXSTJxd3NxbEI2OTlmYVBOdW9yMHFi?=
 =?utf-8?B?WXJnK1VHakxtSXIvSkFlVVlhL2VXMG9icnl4anJwUm5yM0ZkYjFpZWFZVmds?=
 =?utf-8?B?M3hoUk4xYVo3Z0Y2dUF1MjhJOVV1djJXUkRFaWZzd3NZSHBLMmh5UE5LNW9H?=
 =?utf-8?B?WDVXWHBhVWZjUjBiSEpNN01nVWR6bHgrREU4TzVvTUpoczk2clFYTVAwWENu?=
 =?utf-8?B?V05Oa01TNE1waUhSc21yUDRHZnJaMGJUdnJYaFgwa1NydnR2UDlCUU5CZitZ?=
 =?utf-8?B?REZTcEdJTWNpR2VSUjQzcGJ6ZExjUmFwOUUwcVRORHpYeWlJWWZkVDlOOUFT?=
 =?utf-8?B?T3VBQWkydFRoSTJXSVpiOXd4YXZaUmlrc2ZnQWhPUzhkbEFSK3N1bjlnam9P?=
 =?utf-8?B?UUVuOFdack1xK2lNM3B6blg2ZWlKTnVpUFVFYmViYXd6OFN0RG1EcThYcnIw?=
 =?utf-8?B?VHFsS2Rqblh3QVArdGlqSVpEczhiWVR1N21VVWYwTWxRZSswRGFRT21uenJI?=
 =?utf-8?B?NmxnNEpEQWw3OHBTRkMxWkRiSzZ6bFJMOVBvV3ZvRzBqVHJLZzVEb2ZvU3VO?=
 =?utf-8?B?TjRQamNXck1sNzBaY095dmx4NnJ4RnpERzU2d1BHZzFPUUYzSXAyMTdldmlv?=
 =?utf-8?B?VWdtRXlFazJUZ3I2bnV3SkMyZmo0WktKNVptVGhaMjg2bDlxdDZVNXEyelVR?=
 =?utf-8?B?NllQSUtGVS9VQmt1UFBOTzJZbGthbWNCRHZzNi9YNXR5bVYveWdtUmd1Nzkr?=
 =?utf-8?B?S3MzWG10VzdDN25nQnp1V0Nlck9xbWlsQXVsZlI4MDQvTWZYS3FEV3BkY2k0?=
 =?utf-8?B?ZHNPUVNoK0tJSXdKMUozRWk2ZXE4eWZXY2tFbGRxRzNzc1JDb0laLzF3OUZM?=
 =?utf-8?B?R21PcUVsUEs3MDBHbURiZU0yQWFMOTlUeHp2Q2U4ODdGK2prY3YxTVhpWHVj?=
 =?utf-8?B?WWdZQUNSTjJmNVpRK1VuMlFJMkloK2YwUHdTOHJCKzF1TUdpVXdyOWZHWlEx?=
 =?utf-8?B?ZWhjMUFiQzdDNThLWUtMekJCNjdldTdsclVWQUlsYjJTK01GZlR6ZFh5dGJ4?=
 =?utf-8?B?V3JjUDQrSWwvSGYrQnB6R1pKeWhMWG5oNnFlelY4eW80SkhQdVhuYk4xNy9l?=
 =?utf-8?B?eTFkM2VwVUdDM08zZEhYVmI0ZXdmRSsxT083bGttbTkxei92RVhvU2R4WXVN?=
 =?utf-8?B?RFlNRlFxTHRLc1dDQXlrT0dpdkZGaTRaZ29vVkhPRVpLbFExOEs5akhmdjRT?=
 =?utf-8?B?bVFieUVJcWVvMk8xTSsrVjVxTWJEUHI2RkZhUzh5OUx4ckRNa1RxTDZMaXNL?=
 =?utf-8?B?ZEVaYU8vcUp2ejV6bVJseU9PTzdsVzlGUW1Bc0w5ZXBPb0FobG9qRjNmVnkx?=
 =?utf-8?B?cVF3TlBHNmtsT1lHbXhlc3QvREFQZXcwenYxbEMrYnh1L25JSW8xUng5OVMr?=
 =?utf-8?B?WWpRQ1Vnd0dTQTNCbU5QSWxDZXdkOFcyM1dDOVhHZlJtaVBBdUpUekx4ak1C?=
 =?utf-8?B?aWNJb044VjhMNUhSUXkvVXVicjFwR0pSNldvTWJUUE94WFA3b2s0dk9aNFl4?=
 =?utf-8?B?aWVUNWtvRnlYRTRTamZiZkkrNzZzMzNXdnhKdGlFK0tocHN6VTVqNXZJOWxi?=
 =?utf-8?B?Ty9paldPZVdVN21aOFNjK001aVlkcTc3RmNIVkRuMWxoWUZkYVQ5UGJNVnpN?=
 =?utf-8?B?OE5xU1ZCWUJoU0FNbmFIaXF0cVhiRHNlb3FZZVZNanE0a1A1U3NHVlk0dWc3?=
 =?utf-8?B?NFpsdExwZXdxTEN6OGhaOUYzUnZONE5HQzRlRTlmQUtuMHhYUHJFYWdzVXNW?=
 =?utf-8?B?MWJjbUR2L3g2VDlRbSs0ajZYTnpORUpFaVU2VHVxRkpMa3BsaG03UFc1VzFG?=
 =?utf-8?B?aWJVSjZGNkhkRGxLZmExTGxndnZkQzN4K2NCQmtCWXRvMmp1NmNTemRSV1pC?=
 =?utf-8?B?V2ZNKzBJZDRpOEVUckVwYjMyRjVYZUVYQWhGektxU2RYUmpqbzhJV0hxLzU4?=
 =?utf-8?B?ZHdwc096dzBlTFRiQXlteGxQMGxGb3Y1M2VPYVZQeXNWR1Uwc0Myd0VOdjlt?=
 =?utf-8?B?NG54NG5lYkJDclZzWlNHSTBmVzhta3BSNFVhYUlmRERTb1VEYnRPSW9od2d4?=
 =?utf-8?B?aVlMSTllOGNqRFJsRjcySTZGMmJrSlVwWFBBYnRZc1ZxUjFzdHkrMGozZjUr?=
 =?utf-8?B?VFE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62909de8-0adc-492e-6ad4-08dc6eb7f8c2
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4140.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 17:06:01.2469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vWOdXnDTtpHyThx/8a0kZFqQD056aqpa4jo+h+F136VdbZtrG3BH8Jicsm09eiN03enPo1yLckMSxYcJL2B1XQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7712

On 5/7/24 1:36 AM, Felix Huettner wrote:
>  >
>  > As long as we are looking at this, what do you think about
>  > this:
>  >
>  > diff --git a/tools/testing/selftests/netfilter/conntrack_dump_flush.c
>  > b/tools/testing/selftests/netfilter/conntrack_dump_flush.c
>  > index e9df4ae14e16..4a73afad4de4 100644
>  > --- a/tools/testing/selftests/netfilter/conntrack_dump_flush.c
>  > +++ b/tools/testing/selftests/netfilter/conntrack_dump_flush.c
>  > @@ -317,12 +317,12 @@ FIXTURE_SETUP(conntrack_dump_flush)
>  >         self->sock = mnl_socket_open(NETLINK_NETFILTER);
>  >         if (!self->sock) {
>  >                 perror("mnl_socket_open");
>  > -               exit(EXIT_FAILURE);
>  > +               SKIP(exit(EXIT_FAILURE), "mnl_socket_open() failed");
>  >         }
>  >
>  >         if (mnl_socket_bind(self->sock, 0, MNL_SOCKET_AUTOPID) < 0) {
>  >                 perror("mnl_socket_bind");
>  > -               exit(EXIT_FAILURE);
>  > +               SKIP(exit(EXIT_FAILURE), "mnl_socket_bind() failed");
>  >         }
>  >
>  >         ret = conntracK_count_zone(self->sock, TEST_ZONE_ID);
>  >
>  > ...which changes the above output, to:
>  >
>  > $  ./conntrack_dump_flush
>  > TAP version 13
>  > 1..3
>  > # Starting 3 tests from 1 test cases.
>  > #  RUN           conntrack_dump_flush.test_dump_by_zone ...
>  > mnl_socket_open: Protocol not supported
>  > #      SKIP      mnl_socket_open() failed
>  > #            OK  conntrack_dump_flush.test_dump_by_zone
>  > ok 1 conntrack_dump_flush.test_dump_by_zone # SKIP mnl_socket_open() 
> failed
>  > #  RUN           conntrack_dump_flush.test_flush_by_zone ...
>  > mnl_socket_open: Protocol not supported
>  > #      SKIP      mnl_socket_open() failed
>  > #            OK  conntrack_dump_flush.test_flush_by_zone
>  > ok 2 conntrack_dump_flush.test_flush_by_zone # SKIP mnl_socket_open() 
> failed
>  > #  RUN           conntrack_dump_flush.test_flush_by_zone_default ...
>  > mnl_socket_open: Protocol not supported
>  > #      SKIP      mnl_socket_open() failed
>  > #            OK  conntrack_dump_flush.test_flush_by_zone_default
>  > ok 3 conntrack_dump_flush.test_flush_by_zone_default # SKIP
>  > mnl_socket_open() failed
>  > # PASSED: 3 / 3 tests passed.
>  > # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:3 error:0
>  >
>  > ?
> 
> lgtm
> 

OK, I'll send that out, appreciate your looking at it.

thanks,
-- 
John Hubbard
NVIDIA