Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp24352lqo; Tue, 7 May 2024 11:01:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUWJl+ww5bMDSGnELsxn7SgEV9sscDjyJBgTbzkuVt5ttzeiObuRdM0+DAmYCCAtNRbwnY/XSZDzu7KZTnQ3DgvFi07yrYr2WnNo96bHA== X-Google-Smtp-Source: AGHT+IFxwAvlKAP+x89C+HVPZ9G4cC4NdnviKxX0dOYmKVWdutrcaxB9Xh6ZBvdQPiAyK6jD9XSw X-Received: by 2002:a05:6122:910:b0:4d3:3878:a523 with SMTP id 71dfb90a1353d-4df693548ffmr288688e0c.12.1715104868043; Tue, 07 May 2024 11:01:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715104868; cv=pass; d=google.com; s=arc-20160816; b=hLxhXRFDhVkUTgJAVBN/8QJNHif3n3Ka+IIrNrjDNZXxVvIO1avcNFau7iprlIb6iD vfRU69xMwYl+Iy3XSX0/QdYzbfbJG42uNV9H4cF5VQ/KgvtBjy0xsszAadVswRF1RgcX 61JKFrTCidEfUhHzNswmCBAI+kZx2w9Wb3ya85r1eSBjM6HBE1sFSQP/SHmtT5Gu4Cyo ga9W/9ZP1q1Rpe2IJjYA9tQ4E/yW6KxlmN0RbToiuFiCb2ky8cRJbxyqFgtzHGYl5urp JLCO8VV6mzmzwevCGVHpt++A8RtTMxW1ZvWeCdQlC5P/0aMqif67bQQ1C8dOJrynbtWr /hQg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3dZRrtiT6u2AQq8yaWtkXaA1FaAqAm5F7GJug5lWD1c=; fh=95u0Hj6bQ0jMMDdr47iKT8XSu9TeZzP95/EwpjniOP0=; b=kyASlpfGlmNvG6k38y2vDGUe+C5s4m41izukxCcvfCkqTILYa2IMr0hziViXRNozgN /MH1aTUUbNr/z2e10ABUJj6x2uWxR/jiyZTiv8zlktPcBCdgvYU7V4Ijbx4rNB7sbycs Ef1c4tXVBz5FFJFT2MTUlEdeqrKdibWtYj6qHbQOdvQ/Z98cfoCzWGD56LEv4b0Z2cl3 Zkekem5rm3+WD2fNGuIQzSUV3RViAS8uhuGa7ktLlHqkitHPPhjMWnRB8BK5X1/057k9 nfA/rFM6AhYJBmsEf54H/Agz7Xxb1/RJXscpHGG/sbweJWcvb7D57agWKMAK9ZwDdsAh 93Aw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=fF1pfyVR; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id el7-20020a056122278700b004df2339264csi2144929vkb.249.2024.05.07.11.01.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 11:01:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=fF1pfyVR; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-171942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2BDDA1C23BAE for ; Tue, 7 May 2024 18:01:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D468316D326; Tue, 7 May 2024 18:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fF1pfyVR" Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F4F10E6 for ; Tue, 7 May 2024 18:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715104850; cv=none; b=OaDpS4wQKdlodklS8NSp1Bzc4oY/CnnK8thc+jJ5GpRM1r/8pWQzEMuCmi34O1EQperl7D5aCLagrGOB3a8GbRU2fjaU7wPY4sk5NiVjJHe60qQUyhcUoXYysIq9NL8VUqnFy5RruTs1OLiCxcjx+1CAGHwWEovI1dKnqdvIXqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715104850; c=relaxed/simple; bh=xN1VWl6d7UWw/9znVR7KQPIH2t/Yorb7YaTWcrZ9B2U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QKhcPCd+4WfrxAhxgH5O8Vp9ARvWDqRsMoEG2esd8HNBD1VPvOCcQkgmThl2h5wsWopGFMK8AZguqvgRWqf7kfZ41oVz3ta7op7cKiSKy+FOEs43XTEF5t7GaYoRDsId4q/uTIl/qe+xqPTqMqx2IT1Sk7PuT3EBLYjb7B9Uxek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fF1pfyVR; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715104845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3dZRrtiT6u2AQq8yaWtkXaA1FaAqAm5F7GJug5lWD1c=; b=fF1pfyVRJsGtYEYWjlhft20hOLvQU81HyMeiblHpjRdS/UCf5xhyKb218MQmfB+XnCgCS7 jNvfMjSlFRYOz7Aqg5x/U5+JObktZdfdxFEFsVvQtRc4WGw4hrhwVObI7qaWdsyJQwol8e Kqz+jsP+03xpnZjnVSr8f5EX5RiauRs= From: Sui Jingfeng To: Andrzej Hajda Cc: Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sui Jingfeng Subject: [PATCH] drm/drm-bridge.c: Drop conditionals around of_node pointers Date: Wed, 8 May 2024 02:00:00 +0800 Message-Id: <20240507180001.1358816-1-sui.jingfeng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Having conditional around the of_node pointer of the drm_bridge structure is not necessary, since drm_bridge structure always has the of_node as its member. Let's drop the conditional to get a better looks, please also note that this is following the already accepted commitments. see commit d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers") for reference. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_bridge.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 30d66bee0ec6..a6dbe1751e88 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -352,13 +352,8 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge, bridge->encoder = NULL; list_del(&bridge->chain_node); -#ifdef CONFIG_OF DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n", bridge->of_node, encoder->name, ret); -#else - DRM_ERROR("failed to attach bridge to encoder %s: %d\n", - encoder->name, ret); -#endif return ret; } -- 2.34.1