To: Pavel Roskin <proski@gnu.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org,
       Jon Masters <jonathan@jonmasters.org>,
       Rusty Russell <rusty@rustcorp.com.au>,
       Giridhar Pemmasani <pgiri@yahoo.com>
Subject: Re: ndiswrapper and GPL-only symbols redux
From: Andi Kleen <andi@firstfloor.org>
References: <1201641765.18773.35.camel@dv> <20080129224529.4b8016c3@core>
	<1201651006.23553.8.camel@dv>
Date: Wed, 30 Jan 2008 04:24:50 +0100
In-Reply-To: <1201651006.23553.8.camel@dv> (Pavel Roskin's message of "Tue\, 29 Jan 2008 18\:56\:46 -0500")
Message-ID: <p73bq746lml.fsf@bingen.suse.de>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 864
Lines: 24

Pavel Roskin <proski@gnu.org> writes:
>
> static inline void add_taint_module(struct module *mod, unsigned flag)
> {
>         add_taint(flag);
>         mod->taints |= flag;
> }
>
> The module taint is set before the symbols are resolved.  Therefore, the
> GPL-only symbols won't be resolved.

I think using a separate taint flag that does not disable GPL symbols
for the ndiswrapper case would be a fair solution. After all the main
motivation for tainting ndiswrapper is to make it visible in oopses, but not 
prevent it from loading in the first place.

How about you submit an incremental patch to do that?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/