Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp32041lqo; Tue, 7 May 2024 11:12:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUCS1ErJnHmvXmwLiiUMex/VAjfKUANWeJsQT8HhhsT4SKVEi9acF6TYUPylwl4LKByPm3H18yBLyFhoYlWaL8/Ei8t8T/VrB0WiVX8SA== X-Google-Smtp-Source: AGHT+IHtDWu6qVIZLuzuPnclDkFwAXgE4aqSmEeUFE080GRsR5zzogTl5t3iW//oKLfExw9tinKV X-Received: by 2002:a05:6512:200f:b0:51d:3fe4:c3cc with SMTP id 2adb3069b0e04-5217b6a294amr185484e87.0.1715105561192; Tue, 07 May 2024 11:12:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715105561; cv=pass; d=google.com; s=arc-20160816; b=tLTO+bVIaEYS9uSlInOtoCWYsXJ3FCU/xgi8yARsTRKIspZBlFyuG9pBcS5cjPYW4/ yMCyYYcXp/R+3mz3jcIFm+VOS6Ab8No1HfatZ4bdzXgtSQK9blVq3EOF+OxVyHkT439D dnuT3DtH9ERv5/Hrtd9B6qGInvt2Qu7Zin0gp+mWsADrJSJBnpXASzxQzIZy+DNxawbF 4+GWCjNx9uK7VKeRw2V24ZHYI5tMtBQXkqp4B6zhfZCXrJMu28dFc5TZ7/1tZSGVaSXk Undv3P0RDZIvHaXOGGJr4+GEYksm06XKSSgBagn5ecOhqwORLBN6P5jNN/ZkVjC4nEZ2 vAAA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Qqx4uI5MuxvMoFa/uKWsflR/qixZ+MxFuS88SwtQUDs=; fh=gK7s+GgoTkmySAQ54mrtpBsCVUfABzR+XDljI3o7lgo=; b=XQDjzwmRmAxIB7JoBTjTlOlhJX2LJ+FBnhprj/fWM/Qykh4L0RnHXykyAhu3w837To rHZOqVJ9tKoFOm6wpFabPacnNu2qo3l46FNcq1UbpnB9e18pHHPN8wWE7CaV+18XwGqF H3MJ5MGx/NhgAOiQ/pUNYqVXgQRklZ5KmBEe4XjPpoVrvAVFyBFDGE0nPvv2ANNau/xM HIkfC8/JU8VRq39/lKwCknne7ip/eSALZzHbcSbNaxZceDn6fIbPRl04s7rmbnlw6Aza BXl/82kE9VHk6ZfBwsEIN3E8oGKL/0cOB1ZkG331QTfBkax8xadJKb45N5rDUK8VDkGs /nRg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QtMuGheV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-171966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171966-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cr19-20020a170906d55300b00a59f22c4d81si752047ejc.491.2024.05.07.11.12.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 11:12:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-171966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QtMuGheV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-171966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-171966-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 95E341F22249 for ; Tue, 7 May 2024 18:12:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 44C4416D32B; Tue, 7 May 2024 18:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QtMuGheV" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 637CC16C870; Tue, 7 May 2024 18:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715105437; cv=none; b=AfKSKOEpPAKJRxUn+06rxmuokj8KhBG99cyoY07tOz4mglvfY240LCu8Ce4bGnOdskfqw0HJhbFNXpLWlUsLt++l+Cjw+J86nf65z8PKqrejL217hB4HiLtW6c7jGZkL78aFh4/JKkJtx4Bn9kXvqvTOLXYndv7U2h7/dk46sj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715105437; c=relaxed/simple; bh=eUm67f/3NUamaigknr4i+sEXWIOWPMazdU/P6U0owYY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pAqp3DGrFJQ4YVGRpo0BwqxztKDaNrqk+7qP5WggoaYbsc39m7fI76wehVTzcNUIxH4MLYPAy0p5RjbeMiZncsVL5sso6aYT3v1EFX6bmaAF0TxekVfNWeZwrICxq8FVTYiQTo4QDmEKIq+Ua3M5fosbVWLQ+pBVtyB71rd5NCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QtMuGheV; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6425AC4AF18; Tue, 7 May 2024 18:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715105436; bh=eUm67f/3NUamaigknr4i+sEXWIOWPMazdU/P6U0owYY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QtMuGheVGCufYtD87Wzqn2FmhDEjJlvUDA/0Q33KfQrtxmw/phFK5SMLDA0AsxRwx wClB6sWlPqr18ll56lRuAKmK3fU01+m2q8WtltGHLg0iGwjYt5GG1OlK1WXq9IuLmy vwpDiOEZQnoPvtVZVmvUCCGzLRV/JqfSAhdOs3YO9PUGWPKH2BQdRg/LGentwr8FxZ 4p5VBEZ4KIiMn+GWenazQFbaEqvmj/LpIGbk/DYBkKsIb9KG43ATmZZbcH7turF6u1 shmv/ywGM/92aGpTtQ/vMTGvfItp1jKRv276nCLciTZOhbc8hRFIbBh3YYs+6gmlNy s1J4tZ/0NUU5w== Date: Tue, 7 May 2024 11:10:35 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Kees Cook , "Gustavo A. R. Silva" , Simon Horman , nex.sw.ncis.osdt.itp.upstreaming@intel.com, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] netdevice: define and allocate &net_device _properly_ Message-ID: <20240507111035.5fa9b1eb@kernel.org> In-Reply-To: <20240507123937.15364-1-aleksander.lobakin@intel.com> References: <20240507123937.15364-1-aleksander.lobakin@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 7 May 2024 14:39:37 +0200 Alexander Lobakin wrote: > There are several instances of the structure embedded into other > structures, but also there's ongoing effort to remove them and we > could in the meantime declare &net_device properly. Is there a reason you're reposting this before that effort is completed? The warnings this adds come from sparse and you think they should be ignored? TBH since Breno is doing the heavy lifting of changing the embedders it'd seem more fair to me if he got to send this at the end. Or at least, you know, got a mention or a CC.