Received-SPF: pass (google.com: domain of linux-kernel+bounces-171949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <8b396843-4505-415e-b989-14bb37245877@amd.com>
Date: Tue, 7 May 2024 12:25:07 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
 Avadhut.Naik@amd.com, John.Allen@amd.com
Subject: Re: [PATCH v2 09/16] x86/mce: Unify AMD THR handler with MCA Polling
To: Borislav Petkov <bp@alien8.de>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-10-yazen.ghannam@amd.com>
 <20240429134043.GPZi-jWzoVe3bJkyYX@fat_crate.local>
 <7b68f364-a324-4e2c-87be-19cdef4e3ad2@amd.com>
 <20240504145253.GFZjZLxf3lzAHGaHhh@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240504145253.GFZjZLxf3lzAHGaHhh@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?anA0c1liQmxYMjZPNmlsRWdwNkxKV2V1c3hQUjR5eCs0RnVQb21Nd1BIdnly?=
 =?utf-8?B?SEpDNXo1NkYrT0d6SXp3T1luVG1HZUh3czFnNEJpVlFLQWYrc0ZNbllrUHVB?=
 =?utf-8?B?K29Ia0hDUzJQTmVjeGhQbDhKWTNJNGNzK09PdEFUQ3BIV2RhWVNZYlVCM1VK?=
 =?utf-8?B?Z05zZXFXdU9pR1pMSTdrbEUzYXNkK3pHbi9BNkRPQmJ6NzNKVjZnUkN6RTFL?=
 =?utf-8?B?L2ZJNm5SM00rNTNFK3djWHY5VFhMWjc1ZkZ3OTBmVEgreTVVUnAzaGN4NlhL?=
 =?utf-8?B?QXBiSUhnR292bjRkc09QQkpzSk9zTGRMOWp2eFloNmtTcjJhcFBMVWNrMExo?=
 =?utf-8?B?SXFDOUxXamt3WnlvWklmb0p5bmNSNXZUN21wVU45MDVEaC8xRUlpVVUwemUz?=
 =?utf-8?B?YTZ3Ti9WV0J0MzRiQjdHK0dWRnlzenVTYkNrSVlrYWYzbmgvUHBjUm1UZytp?=
 =?utf-8?B?aE9DeTl5Q0VjaGJOUHo5MG1XYXh4dlJpQUpzQmU0alllblVoYnpLN3BCbEVm?=
 =?utf-8?B?WVZFbktCa1hxWTlYVXdjSmxtUXhTTWp6OEJWSUVDQlBXYnNZMDN5MVhnb1Zl?=
 =?utf-8?B?NUQzamEvUWNUY2s2alRlZ3Q1ek5obnN3clFZT2N6bThmUmx6SEIvb2crRFpW?=
 =?utf-8?B?Nk9wdGJMdUc2TW1PQU1wcE42VXlDQk1xb2IwSEtJOWtSVTFzRXFBbGlubTJn?=
 =?utf-8?B?NGsxWGdaSlRMNE1UZ3ZwaHNRdFRHNDEvaEhtRXVVbG54VmozcCtmc2svbTAv?=
 =?utf-8?B?Y0pwejRGOXFtYlFqM2FObk9zTzhFTjlSc2dCNnZnRXhvYTZtN3d2NUhmNUJU?=
 =?utf-8?B?bkNtblY4bXBNV0kyVS90ZnBrdTR2RUdBZXhIVnpONGxZdGtDOHBibDMvRExF?=
 =?utf-8?B?NkJlMENtQi83Z0JlbEU2azNrRUtSUlBUS1l2MFlGVjVyMnV2WVpHd0RuRlhB?=
 =?utf-8?B?RDRieGNwbG1nREV6VHJkUnRuc3p2UWxmMnlNdkFvVVk0UUlnR3IxcjFrRElR?=
 =?utf-8?B?S2FnSzFtRkQ4a0pjdnVxNndXK0wyaWNMT1RGekd0NWNTbHVWb2FnRGc4WWpi?=
 =?utf-8?B?VEJ0NGhFR0c4dGhuSE9XcS9IVWdwcm96SE9kWm5RWU0xL1BBcG0yNDNkWm5l?=
 =?utf-8?B?NnBFS3JiYkFhaUpLdS9TQ1F5T0t0bE5nc3BZcjRPVk9vZDFXUk02SC81S2ND?=
 =?utf-8?B?cHd4dkwwaXlkNUEwaTByZ0EzMWRvZGd5eWZMRHVab3RKSTkrYmk1aDRSRHJI?=
 =?utf-8?B?UFhMemJhUDY4cjNpZ0M0aTVJYlIybkZmU1A3ejI0alMxbHBMZWJqdDlrdlpa?=
 =?utf-8?B?OG4rQ25VMnFoanBEZXBJTUpwY0xZUWtBaXF4SEQ2QVh4aTA2d2ExcUdDNkQ0?=
 =?utf-8?B?b0xXeGtxM1pwVFlzMXNJUWpMc1lqVXYvTHdxQXc3NDJhRVUwNHlsNXZ2eU1B?=
 =?utf-8?B?ZnJPakZCL0IyYW9VVktzTTJrSjNzS3UrZ3lLRXpqWXR4ZEdyYmhaNEplYzgz?=
 =?utf-8?B?Yjc4MHFpZ0REbHlBYmdmRjBoT2ZDSHJaVWtuWlFIMlhHUm5GZ1FqWjNPWWhr?=
 =?utf-8?B?b0dlNVZlNlBzK3J3RWZyZ1lpN05oV09VRDdvVDBmNVFLRTBqZm9yUW5wT1JJ?=
 =?utf-8?B?SSs3RHpFeG14YTI5Zm9IUk5UTEpYTDV5QkFvS3lxajJRaXFneVB1a0VITXZE?=
 =?utf-8?B?R0FLT3pPNlVwUFIrOE04QXpOMDJ5SFVEWWVrcXVvOTNYaE1PanFnS2tLakJX?=
 =?utf-8?B?UkZDZDBpOS9mMGkvQVNlazJHUHVaTFRRL1lMRmZxei92dlI4djM4QUV3S1Na?=
 =?utf-8?B?NmdmQ1czM1FPbGJDWFJwOCtwdTRrMGIrcUc2MjVML2FqNSt6U01WaWJUcytr?=
 =?utf-8?B?cURldmNNblVTYU9UVW4yUUFHZDNqQzNEYnpnSUdpM2c1UzZjQkVTRStWMHl1?=
 =?utf-8?B?bTdnazVHVHNLZ3BLdkdOL3V3azl5bFBOaStmNFp4RVFJZUtscFlUZDRQK2Nq?=
 =?utf-8?B?czhBem5Kb1Q1REJuMU9sVmJsVnM0NHRlRGY1UlVjU1Z6SC9EN2l1SmdsUlJS?=
 =?utf-8?B?bGRFSjVhS2hjQVErZlJIWjk3SEovTTlhaHJxMkVtdkJYZXB6K3F2S1l6ckxU?=
 =?utf-8?Q?KpFAERaXG3lBJ681VoGUjUHcD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39b64da7-1814-40e7-0f37-08dc6ec0437e
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 18:05:22.6190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4NZ03WXLXqr/RHHBI+v3MxCuN5oCMGY+YRIYXswys+Sjc88XDJqczg/8jtBiBrI2AwHyzw4QJBzfHQb3sMzYHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8717

On 5/4/24 10:52 AM, Borislav Petkov wrote:
> On Mon, Apr 29, 2024 at 10:36:57AM -0400, Yazen Ghannam wrote:
>> Related to this, I've been thinking that banks with thresholding enabled
>> should be removed from the list of polling banks. This is done on Intel but
>> not on AMD.
>>
>> I wanted to give it more thought, because I think folks have come to expect
>> polling and thresholding to be independent on AMD.
> 
> Yes, this whole thing sounds weird.
> 
> On the one hand, you have a special interrupt for errors which have
> reached a threshold *just* *so* you don't have to poll. Because polling
> is ok but getting a a special interrupt is better and such notification
> systems always want to have a special interrupt and not have to poll.
> 
> On the other hand, you're marrying the two which sounds weird. Why?
> 
> What is wrong with getting thresholding interrupts?
> 

Nothing. This patch is not disabling the interrupt. The goal is to get
rid of duplicate code and have a single function that checks the MCA
banks.

This would be similar to intel_threshold_interrupt().

> Why can't we simply stop the polling and do THR only if available? That
> would save a lot of energy.
> 
> So why can't we program the THR to raise an interrupt on a single error
> and disable polling completely?
> 
> Because that would be a lot better as the hardware would be doing the
> work for us.
> 
> In any case, I'm missing the strategy here so no cleanups without
> a clear goal first please.
>

We could do that. In fact, there's a request to use the threshold that
is pre-programmed in the hardware. And we could use some of the current
kernel parameters for overrides, if needed.

Thanks,
Yazen