Received-SPF: pass (google.com: domain of linux-kernel+bounces-172118-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <CA+G9fYs1ZN2K=UHOjrwRR2JNE-M0nf9iW_Q-YPzVgmW+9daU4Q@mail.gmail.com>
 <CA+G9fYs1F=kO11-+DtAOsNwZGEd8mmojXEfXfg431JG=Spubcg@mail.gmail.com>
 <CAA8EJpoMwy2w3a9VF3ejGkcxFK905DCczZOdD4k-cd7ouKHYcA@mail.gmail.com>
 <CA+G9fYuGLz76C9F=onq6u2hk9_YYHhyjT+bvwXmeN8U6bhejNQ@mail.gmail.com>
 <CAA8EJpp5TO9CkwWCUy_OL5T4px9gTjmB-pKPr1dNPgudVc78Tg@mail.gmail.com> <c3013f57-0d0b-4e3c-9658-7cc989b77c73@app.fastmail.com>
In-Reply-To: <c3013f57-0d0b-4e3c-9658-7cc989b77c73@app.fastmail.com>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Tue, 7 May 2024 23:00:26 +0300
Message-ID: <CAA8EJpqqYrSLoLmhBLTG=dH2dxk=8Ab4PW35nt6b_Vfe5722Fg@mail.gmail.com>
Subject: Re: arm64: defconfig: gcc-8: failed: AttributeError: module
 'argparse' has no attribute 'BooleanOptionalAction'
To: Arnd Bergmann <arnd@arndb.de>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>, lkft-triage@lists.linaro.org, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	open list <linux-kernel@vger.kernel.org>, Anders Roxell <anders.roxell@linaro.org>, 
	Dan Carpenter <dan.carpenter@linaro.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, 7 May 2024 at 22:18, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, May 7, 2024, at 20:19, Dmitry Baryshkov wrote:
> > On Tue, 7 May 2024 at 21:06, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >> On Tue, 7 May 2024 at 20:58, Dmitry Baryshkov
> >> <dmitry.baryshkov@linaro.org> wrote:
> >> >
> >> > On Tue, 7 May 2024 at 16:13, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >> > >
> >> > > On Tue, 7 May 2024 at 17:13, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >> > > >
> >> > > > The arm and arm64 with gcc-8 builds failed on Linux next-20240507 tag
> >> > > > with gcc-8 due to following warnings / errors.
> >> > > >
> >> > > > arm64 and arm:
> >> > > >   defconfig - gcc-8 - failed
> >> > >
> >> > > Anders bisected this build problem and found the first bad commit:
> >> > >
> >> > > 07a2f8716c41 drm/msm/gen_header: allow skipping the validation
> >> > >
> >> > > Steps to reproduce:
> >> > > -----
> >> > > # tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8
> >> > > --kconfig defconfig
> >> >
> >> > What is the python version on that platform / system?
> >>
> >> # python --version
> >>  Python 3.7.3
> >
> > EOL.
> > I'll check what we can do, but please consider updating the platform.
>
> I don't think we can rely on everyone to have 3.9, 3.8
> is not EOL yet, and we do want to still test in distros with
> older compilers that may also come with old python.
>
> It should just work with a regular optional argument instead
> of the BooleanOptionalAction (without the --no-validate flag):
>
> https://docs.python.org/3/howto/argparse.html#introducing-optional-arguments
>
> > @@ -538,6 +538,9 @@ class Parser(object):
> >               self.variants.add(reg.domain)
> >
> >       def do_validate(self, schemafile):
> > +             if self.validate == False:
> > +                     return
> > +
> >               try:
> >                       from lxml import etree
>
> This bit may have to become 'if not self.validate',
> since the flag in this case is None rather than equal
> to False. This also improves readability.

Could you please send a patch?

-- 
With best wishes
Dmitry