Received-SPF: pass (google.com: domain of linux-kernel+bounces-172143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ea75801f-e56a-486d-85a4-85c57bce0c81@intel.com>
Date: Tue, 7 May 2024 13:26:34 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)
To: <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <48b595cc-5ffe-4507-bffd-335a60fdaab9@intel.com>
 <2016b830-64c7-43bd-8116-bdfd239221e3@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <2016b830-64c7-43bd-8116-bdfd239221e3@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkxvNFdBcUVEdkJHTEtPM1VrS3gxK2hCN2ZibjhRR1dKWEp6Y2trMlo1b0FG?=
 =?utf-8?B?bWxrdWduN05pcWJQNnd1d0EzRGRXY2tESVlRZ2NKYVY4eUpkRG90cDBadmYz?=
 =?utf-8?B?QXlBY3dhaVlOdFE1ZzNKYWpmWVlwQTNyZTltcXB0YU9VYXpJVStZbzJHa3Bx?=
 =?utf-8?B?WFMwM3Nma3d5aVFOeUJqVEtVNlU4cFRmVlFXblhXc05neE15NWVwcU5DVkxs?=
 =?utf-8?B?RWl5QmtMQjhBcFpIcWhJZEwrRGJJR2c1MzJYeUZHZE5MNTMxczZ3N2hQbG1P?=
 =?utf-8?B?b2tLWXlLd1RkKy8wanUvUXk5WmdqMjJheExkL2R0dnU2ZTgra0ovQm13L3ZN?=
 =?utf-8?B?WUNvR2xMQzdiTlpTQzdQM2NwVmZKQ1IyR1QzNld5SmE1S0lqVGc0eHlFakJ2?=
 =?utf-8?B?ZUsreWN3UFRRYWlsZmUrbXJTUk84OVVkMkF0OGdWdzB6Tm8rZFFDSld1aEFp?=
 =?utf-8?B?S2N0MTJTK3lOR1dzbnZOMElPeFliTzFYdVY2WWxYcXJKbmU1K3JoY1dWdFdu?=
 =?utf-8?B?Ri9DMGtxdUR5bGFoSDIrTXZQcitMb1NPOGdPVTVLWnRpblRrNHhGU1gxelVG?=
 =?utf-8?B?VGM3YjhkR1JFME9nSHoxTWpwdVh6TEtUeDFZRHNqWlFGNjU4dmVoOUVubFRh?=
 =?utf-8?B?NEJmVU9sR0JUdE1Pd3kxMHRpZ05NSDZ0cUFweTJBMTNMamZaL0VVak5yblVv?=
 =?utf-8?B?Nzkzd29uaVBUVmxSTFlSbUQxUUk4cmNVQ2w3V1A0WDQxVXQ4bkNnOWFMMTky?=
 =?utf-8?B?UTQ3dUtGd0Z1SjRhRm5pMmgxYm10ZUt6cHNKQlBWSStMZ1QvR1BxWWlzUTdJ?=
 =?utf-8?B?R3dhbWFvZkpnakdjamlucy91YjQwSHZjdVdMcVlPZEtHZGdjM2pLQVl1WVA1?=
 =?utf-8?B?MHlFalNCVUtYRTNiMlp1OHcrcDJ1UUhZK01mVWlRY3VTRjdyUm4zTlNlcmdy?=
 =?utf-8?B?ZS9yM0swR3ZCVllzNS9TU2NFdEtMOVBINDFCUnJ0Y0c5VkVwcmxCU1Jmc3NC?=
 =?utf-8?B?WGFEUUxReEEzQ3B2aDFOOTBMUFJYTERnSjZ1WE9QU0V1c3hpWnhUa0xOL3Rw?=
 =?utf-8?B?RkFyb1k1R1hOSlpGcmo5YWNSalNGMVl1Z1dsTUhqNEcyK2N6TVRIdXNFSEhD?=
 =?utf-8?B?MkVjVlIwV2J3UWl0cW5sd0wzOEgxU09sem4wWTNnVU95RXpoTGZ1YThGYzBO?=
 =?utf-8?B?MjMrMWxyZEFJcGw0Ym11WXNZRURlWVhyT0FJTFpZdURobXYrQ2xNZ1MxMzM4?=
 =?utf-8?B?bHl5TmV5WFVTb1ZNUUZoUFlBc0htS3J2YVVXdEJON2s1VjNGL2Y5c3FOL2Jm?=
 =?utf-8?B?NE9oMFh6UVpaMWxOVGFMR3V0RGozZS9uRXJJQUUrVDViS3gxeVlqZEMvNHBN?=
 =?utf-8?B?OE1NaVVtTHczY3JHanB2NzUxWUM3b1B5VGZJZWZaUVpPK3ltOTIwTHJzc2la?=
 =?utf-8?B?bnlyejh3WURMd3RPN1E0eXJIUUFXWHhoZUZHa0tidis5UEN5WkZQVEJDdERa?=
 =?utf-8?B?OFFlZmJ1UHFFRE9OSmRSeStHcFVWai82a3hiZXZhNHdQNzJVUnQ4WnArZDlL?=
 =?utf-8?B?TGdad09aR3RocjlvRG8wZis5S2pKVks0OHFUa3U1M3RSeGFnUXdTaDBOV2VB?=
 =?utf-8?B?VjVydkc1YjZnNVZQYTgvZ2phNi9iZStUNlYvczRQR1dSQmtNRDNtWkIwQVJD?=
 =?utf-8?B?YWdZTHFuTWkyTjE3T1BPODg5czZhV2FIY2tmVVd2bitmVUNnY2xmeVBqWVNC?=
 =?utf-8?B?RlkxZ2JGVFRkNW0zZnpxVmRTNW5FSXk3aHcxQ2ZSMVI4ZTY2c2hkTHV1QTRV?=
 =?utf-8?B?R2g4QXJPTGJNNDM3Q3BoeE1OQnpWald3SHIzQlYvc0RjQU9rLzRHTVp6WVdq?=
 =?utf-8?B?RFJKYXVNb1hLdXFEVmkyYjBxUUdqc0Z2TUM5RjlkOElsS050aXFlV010Wm0r?=
 =?utf-8?B?ei9FU1Fkdmc0THdzYnNBTWVEdiswbDl5R2hhdlRWZWV2SUE1Q2szOUNqVUhw?=
 =?utf-8?B?NnhBYlJvR045ZC9DeEZtSlorTTJPZXNHYUpNeHN2MXZtSk1hTUh4aWdVWFZE?=
 =?utf-8?B?SUpkelp6K2RBMGt4bDhYbDdVZzFUN05jSE1tK3d5U2ZLbXFmKzVRY094NHdR?=
 =?utf-8?B?RnJoMUkzNU9XS2hxMjc2SkpOSndyVEZCa01GaE10TE42T2xhNWxZNHBSNUVt?=
 =?utf-8?B?dlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bbe604e-f17d-44d6-0eb8-08dc6ed3ff3f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 20:26:38.1055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h6rgXekA7DRwOEX75JaIXmyJPUAq178my+hbiyqX3DPEFoWTkXChfEPfhacMHx2y0uNhxFClOMr91VFKq1Y3D7yzu+/V3ibUehH1mORDlT4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5902
X-OriginatorOrg: intel.com

Hi Babu,

On 5/6/2024 10:18 AM, Moger, Babu wrote:
> On 5/3/24 18:24, Reinette Chatre wrote:
>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>
>>> a. Check if ABMC support is available
>>> 	#mount -t resctrl resctrl /sys/fs/resctrl/
>>>
>>> 	#cat /sys/fs/resctrl/info/L3_MON/mbm_assign
>>> 	[abmc] 
>>> 	legacy_mbm
>>>
>>> 	Linux kernel detected ABMC feature and it is enabled.
>>
>> Please note that this adds the "abmc" feature to the resctrl
>> *filesystem* that supports more architectures than just AMD. Calling the
>> resctrl filesystem feature "abmc" means that (a) AMD needs to be ok with
>> other architectures calling their features that are
>> similar-but-maybe-not-identical-to-AMD-ABMC "abmc", or (b) this needs
>> a new generic name.
> 
> It should not a problem if other architecture calling abmc for similar
> feature. But generic name is always better if there is a suggestion.

"should not a problem" does not instill confidence that AMD is
actually ok with this.

Reinette