Received-SPF: pass (google.com: domain of linux-kernel+bounces-172150-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7baef7a173dc4d1ecf8b0dafde565b1a.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <3a3c4279-a254-48d0-91ad-70b7f1e3eb77@linaro.org>
References: <20240427-topic-8450sdc2-v1-1-631cbb59e0e5@linaro.org> <2337ba58adb3fb127710bead9b8665a9.sboyd@kernel.org> <11bd7146-30cd-4b71-b2ca-d76875763731@linaro.org> <6ba2967c6c9d24e3f1c9b76496176010.sboyd@kernel.org> <3a3c4279-a254-48d0-91ad-70b7f1e3eb77@linaro.org>
Subject: Re: [PATCH] clk: qcom: gcc-sm8450: set OPS_PARENT_ENABLE on gcc_sdcc2_apps_clk_src
From: Stephen Boyd <sboyd@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Vinod Koul <vkoul@kernel.org>
Date: Tue, 07 May 2024 13:28:40 -0700
User-Agent: alot/0.10

Quoting Konrad Dybcio (2024-05-07 06:51:04)
>=20
> without PARENT_OPS_ENABLE:
>=20
> [    3.326891] sdhci_msm 8804000.mmc: Got CD GPIO
> [    3.336839] scsi host0: ufshcd
> [    3.337105] gcc_sdcc2_apps_clk_src is DISABLED @ set_rate
> [    3.346339] ------------[ cut here ]------------
> [    3.351093] gcc_sdcc2_apps_clk_src: rcg didn't update its configuratio=
n.
> [    3.351114] WARNING: CPU: 1 PID: 11 at drivers/clk/qcom/clk-rcg2.c:133=
 update_config+0xc8/0xd8
>=20
> [...]
>=20
> [    3.610523] gcc_sdcc2_apps_clk_src is ENABLED @ set_rate
>=20
>=20
> with PARENT_OPS_ENABLE:
>=20
> [    3.331419] sdhci_msm 8804000.mmc: Got CD GPIO
> [    3.336569] gcc_sdcc2_apps_clk_src is DISABLED @ set_rate
> [    3.344795] scsi host0: ufshcd
> [    3.355122] qcrypto 1dfa000.crypto: Adding to iommu group 5
> [    3.363567] remoteproc remoteproc0: 2400000.remoteproc is available
> [    3.364729] gcc_sdcc2_apps_clk_src is ENABLED @ set_rate
>=20
> after testing it both ways, I realized it wasn't supposed to make a
> difference in this regard, but I suppose I can paste both results anyway..
>=20

Can you share your patch that prints the message? What bit are you
checking in the hardware to determine if the RCG is enabled? Do you also
print the enable count in software?