Received-SPF: pass (google.com: domain of linux-kernel+bounces-172151-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <4bcb0c46-458a-4ce9-a184-d3054a6ee26e@intel.com>
Date: Tue, 7 May 2024 13:32:08 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 05/17] x86/resctrl: Introduce the interface to
 display the assignment state
To: <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <e50e1e55c2ef4f5e1609960e573b30a125a59e5c.1711674410.git.babu.moger@amd.com>
 <9fd1c700-fa24-4290-aa77-a6eda9758ace@intel.com>
 <086a6c59-f617-4714-b91a-2b1deae8e33e@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <086a6c59-f617-4714-b91a-2b1deae8e33e@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1FiT0VPVlROQ05RSUNJbUEvUHVrUnJHSmlhcDJZV1NwMTh5dTgyT1hnVkdt?=
 =?utf-8?B?KytyeXhQdTdqbTVTWFBoYmRmbXJVaVliS0VVSHluczFRbm9wNFJwcFRNQVNq?=
 =?utf-8?B?ZStmaXVyb3BEZisxbHd0QUtOUW9YaENMVVg1cWxnUUpqb2VZaGE5bHFDYnFX?=
 =?utf-8?B?ajl2cnBDd084NE5XSVdFN2JUOW9JSlkwSlhqVlRZc1h6TFZiM1dWQVhsR0lI?=
 =?utf-8?B?VHUyM0NLemw0UFdTaS9VV3NTZ3FmMzVYdzRCK1Z2YktYWHZPUE1vNk1KK0x1?=
 =?utf-8?B?UDVrd3dibCtGYmlHNjdCUUJYVi9US0lVU1JxWk12WkpTMXNiTUQxZ09pdE1L?=
 =?utf-8?B?YjFwaUh1SU9SeFF2SjR4QmRUTUpVbmpVZzcxMU1mUDR4b0NtUzFSc2taNUdz?=
 =?utf-8?B?SU5URERJL05DSUd6RW9aS3BHQVJmMHg4N1ZwMGlab0ZJYjk4cmt0K1k3dmcr?=
 =?utf-8?B?d0xNcGNGQUl4UDNZTE5EQitOWDFUSUxoK29QS2RONWNKcXpxM0cwb2F1dGR2?=
 =?utf-8?B?dGVPVkVJTWZYZVFXcWxEcnpnZnhsYTZzQnoranlPL2VUajZwOVVrTDFJOXBq?=
 =?utf-8?B?cjBGOUpOZkpGWklaYzBKNVZORlY3WmZQTEZzYUpFeG40MXU2ek1uZUpsNVJJ?=
 =?utf-8?B?cCtQS1hSUW1WV3E0MGI3Z1J5bFdQZUpCQ2Z5UHFuRWZzMnRGMVRudFNqSlBT?=
 =?utf-8?B?QWlQa0tGMnFRMnNwQWRZakVrTmdjL09seTZVZWJLcWZldFV2NEZpT1A5QWVQ?=
 =?utf-8?B?VHM0VDNsUU9nK3l2dDFBRlovYVgzM2ZUSUlLUmI5UFpIYjM0dEsyeFVpOXBN?=
 =?utf-8?B?RWJmcjNRNUl2eDhhaUowNzcrSkRTTUFKck8wRCs4UFpic3RaU2RuQ0w1RzJG?=
 =?utf-8?B?Tmd3THBXeGZ1VVZvM0gzZGh1ZElMVTlqRkJ4ek16emQxWlh6VUxnNDVGVWF6?=
 =?utf-8?B?S3kyUG5UTmEwNjd1SEN1b1I3YlM0U3JkQVZnVU0rTy9LMlhvMFVxTVo5My9C?=
 =?utf-8?B?RS9ZUjFtOFVYMll0cjRUTjhSdk5NUWo4SFN3VXdQczAxSS8vQUVabUlFcCtp?=
 =?utf-8?B?SU1hWFJtSWMzVDArNXBnTlp6Ri9qcXorOTVWTW9KNU1FSi9OMWVGYzFvUjBp?=
 =?utf-8?B?Uis5M05ENHZMc2p6VTJxY09GNGJjN3pidTZ5ZnJEanpBQ0xNcEZ2L1pvUTg5?=
 =?utf-8?B?MkVvSTVNclVmM21ZTysyR3dsbjdTYU5OMFRycG5jN3NLeEJBMjhVUkJTdTlp?=
 =?utf-8?B?aVE5VkNmQXgzTHNRNXVCUnkyaCtVQkI0bkdtdTRQV2lCcmtjY3hteWxxazlW?=
 =?utf-8?B?VW1Xc3FGdnpCR0JqekFIaGZ2dTRoZmF1OExrWmlxSUVINlVXSjJjVC9QM2pU?=
 =?utf-8?B?R1FUNHYwblNhakIzNno1R0Z5MnpQdk4yS0RkUHBuRGFKQ01hd1laVk9qMExs?=
 =?utf-8?B?SUlQa3lKeGFlVGo3ZUhFdHlxcVpaTTNoM3pwY0NoQmtHb1g0aGZoN0gveXRX?=
 =?utf-8?B?YjZraURXbTZ3eW5jZEVGelpWVWVZb3NZdWhnSnNtZ0lUK2NEcE96S05QeW5v?=
 =?utf-8?B?NytNOW9RWnhmMGpoRU5ZVTFPc2FwT3hRNG10VFNnSy82clN2WnBlUUVEajN1?=
 =?utf-8?B?RDhzN1dHTnBxVEwxUG5pU2V3QmRVekV4ODR3aldMNU1zNVRESGsvUENaUzcr?=
 =?utf-8?B?OG9taXcxYzlnVVl4SFRKUnZXWlFOWmxHQ0tDUmdLNS93WVZRbWxnTlpwNTlO?=
 =?utf-8?B?MGZIK21jNWZQaURiNFk3azA5K25Pa01rT2F6TmNoRmlZU3NXdmMxTWFTSmEw?=
 =?utf-8?B?QlRiMmMzUDRtUWhzaGpBbmYySmRBQ1RpN3dHcWFQNEN0anRkTXdxWWZmK21o?=
 =?utf-8?B?VHBjSGYwQW54NFpDa3RYRWR3ZFVQTHk0ZWF2TmZmSmZtekNKeGpGWFdhdkM5?=
 =?utf-8?B?TXJFQXVYakx1ZVI5VXkzSDV4Yzd4WkxYS1JibysrQWE1bXU3NEp0T2QrV0NK?=
 =?utf-8?B?ckJ1Ny9RK1dXQlNSUzBUL1FsMW53cHV4ckk2ajd2VzJJdGVJSjJYU2dmbjRz?=
 =?utf-8?B?K2E2Z3ZNWEJLc2Nab0VYNTE1cmx6b0Mrdk9tYytsNmtWdStBbjlhQ3dOb2NQ?=
 =?utf-8?B?MWJHRmVvOGtPN1VrbEw1VzkxNTc2ZkViZWxHWEpuUTVnRFdaN3FCcWNuQzNk?=
 =?utf-8?B?YVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4577021e-c460-4e88-6d9a-08dc6ed4c654
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 20:32:12.0576
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EsJ16WjVtj7plVqvx2nqzoL/Xsd5xTGFqm6fYH4G4pMajNvgILnS7QpQe7PasBNyjqxkZDhKTi9dcOrXmJ37B1tqtSEth/qYDNr4UeKciTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4618
X-OriginatorOrg: intel.com

Hi Babu,

On 5/7/2024 9:28 AM, Moger, Babu wrote:
> On 5/3/24 18:28, Reinette Chatre wrote:
>> On 3/28/2024 6:06 PM, Babu Moger wrote:

>>> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
>>> index 735b449039c1..48d1957ea5a3 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
>>> @@ -1058,8 +1058,10 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
>>>  						 RFTYPE_MON_INFO | RFTYPE_RES_CACHE);
>>>  		}
>>>  
>>> -		if (resctrl_arch_has_abmc(r))
>>> +		if (resctrl_arch_has_abmc(r)) {
>>>  			r->mbm_assign_capable = ABMC_ASSIGN;
>>> +			resctrl_file_fflags_init("mbm_assign", RFTYPE_MON_INFO);
>>
>> I think this will need some more thought when considering the fs/arch split.
>> The architecture can be expected to set r->mbm_assign_capable as above but
>> having the architecture meddle with the fs flags does not seem like the right
>> thing to do. I think that RFTYPE_MON_INFO may not be accessible to arch code
>> anyway.
> 
> It is accessible to both arch and fs code per latest code.
> https://lore.kernel.org/lkml/20240426150904.8854-33-Dave.Martin@arm.com/

v2 of MPAM was posted without completing discussion of v1 nor addressing
all feedback.

Please read discussions surrounding #3 and #30 of v1. Note in particular suggestion
in [1] to keep RF flags internal to FS code. 

If MPAM chooses to submit new versions without completing discussions then
I have no problem letting ABMC proceed to build on what is resctrl at this time
and adding this to the pile of things MPAM needs to address during fs/arch split.

Reinette

[1] https://lore.kernel.org/lkml/b2595743-c7dc-4946-884f-ff159bc4865e@intel.com/