Received-SPF: pass (google.com: domain of linux-kernel+bounces-172146-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <3f4d2c09-3158-477a-ba9b-f8f809d1999b@intel.com>
Date: Tue, 7 May 2024 13:27:32 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 04/17] x86/resctrl: Introduce
 resctrl_file_fflags_init
To: <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <363c14eeeac99eb0453ac3429f9e7bd446b2acdb.1711674410.git.babu.moger@amd.com>
 <55fa3189-b5da-494f-8ec2-7f0ab4b8d33e@intel.com>
 <119fbe0f-9688-4382-9263-220f69caa718@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <119fbe0f-9688-4382-9263-220f69caa718@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0xlb2ZvZzhPb3hzY2QxMU9aKzVtekVucG5wdlYxd2p0b2NOQTNGU3BFV3NY?=
 =?utf-8?B?UU43bDZOdWZyVDV0STNlU2R5ZjZiQWdJVkNVQm1OQUw0MHhVQzNEL0l2SDJr?=
 =?utf-8?B?NlVGNjV5RU1SL1M0M2RJTHpxUE43UFVnSXVzSzFId0JNTDVqK01zQlBEbW5a?=
 =?utf-8?B?bWJjekY2QXdmbEFNUlluR0VjU1VRY3hkQVk3WEU1N05QZzB2T2RaWm5Idkpj?=
 =?utf-8?B?azFtdUIyQjFWRjZmNTlOZzhvakxVZjJnbXMxRFV5UkRsc2FNa1V1bnladGtK?=
 =?utf-8?B?MXRoZ1crUHlEMlZ6OVVrMDM3UU8xTSs4V3FQOWNhTTV5akpQOFkxWXI0c3M1?=
 =?utf-8?B?R1BZUit2bWhTdCt2ZVA0RzFjMTZHaTBuQmU5QlpxV1lwTFgvTVoreHZMZmFG?=
 =?utf-8?B?NFY4L2d2SUVNM2lCSnhNbXllZmNaYk9NY3F5VW1iMUY0Q0F1VjlxNXBkQmo0?=
 =?utf-8?B?SEUxWHVRMldSN2RlTnZudGRPNXBDbVZuWFFSV1l3dk5QYWFpTU9LeTBUUnU0?=
 =?utf-8?B?VzN0VUlLalVNMWg0NWlCSTVxcjduZFlKRW5qQUkrN0FYd3lIcHJ1RDZEVEd1?=
 =?utf-8?B?UFMyMU9QWEFoblR2Vnk1NGs4OVhvaHBzdzhvczQ3N2Y4a3c3NnIwaks5dlNN?=
 =?utf-8?B?WW9ISXhaRzgzWkdleFQ5N1dHQkQ1cFBOanpYTm1xWU9zMjdOcVZYdTU5T2xE?=
 =?utf-8?B?b3diZzlmNUZtaEVWQjlYTjRDNVRIYTVkVWdVaDJ3Rnh5ZTR2eFRqUG54elo3?=
 =?utf-8?B?bUxNZHk5eUNQK3U0dW9pUEdYTU5HMlJQMjRQOCsrdXBQRXd4aGQ2UkYrUW9n?=
 =?utf-8?B?M2xmbUdkaVd1bjU1dXpIT29QTUl1WWdERkFFWDc2c09RalRCMENSOEhpMXJV?=
 =?utf-8?B?RmhBbnoweUdYYVQrRks4SnJmTUNkRFZ6WCtMYzBrdVpaY3d1Qk9DRHNtKzRv?=
 =?utf-8?B?RVluN0l1dHFDc0g1N3hFZWx6L1lxVWNKL0FnZkk2WDA0Tm1GeHM0c2pPSkFn?=
 =?utf-8?B?dTFlQnhDamlZOTZ2L3BNeHA4OG5vSGo5RDBLM0FhOHo3dXNvZ0hNQWNsS0Nh?=
 =?utf-8?B?OTJSd2pwTFhvNVBHcG5xUEJQUzVJUTljY0VKL2x2dHRxdUtnT2RMWTh3SGtI?=
 =?utf-8?B?V0FuelNNR3VXeTNoSzJOSXhMNWV6Ny9VZVhzNEpMN29KaEU0Q2JlZDJYZkky?=
 =?utf-8?B?cFVKQitiWnMrbXpvd3JqTTAyQVE1dzIzUFBBMDl3M0tRNjJ1cGM0UnRTS2lp?=
 =?utf-8?B?MllXcGZyazh4MTkrcTcyMWY1WTcyaDNWQjRLV0V6ZmR5VFFZOVdSSGZ5akFs?=
 =?utf-8?B?bG1GYmFyTjVkRmYwQmcwbGNHLzJPeEJ4T01jZ3hsQnhUMmxjZDhFYStuaXVt?=
 =?utf-8?B?Tk53cnp3Si9ZTmlmaTV4ZVg1ZnBhbHlhOVBGcjZhNFQxWXg3RlY4NEZOOHZ5?=
 =?utf-8?B?WWg5SER5TElxV09UNkhuWS9OaFZmZTRjYmtyZzFkZzdKKy9OSTlNY0I5bGJW?=
 =?utf-8?B?aEtFUlRmeHFsYkhkb3Bkb3lQd0tCbGNxVVFMV3pZUWRhWG12TjM4aVV0emFv?=
 =?utf-8?B?enlqTWVaMGpiRkYxMDd4MzMzMk1JSTdLNHE0eitlQXFvMXlhVnhWUWhtN3FF?=
 =?utf-8?B?NEFYM0Y3M0VKNWRHUkJINHVFTzZNbW00SklBcWh5Nzl5TVRRMWpwN3RZakV0?=
 =?utf-8?B?cldHamxlZSt6andsSlUwVkhrbUw4ZnVzMTJUQmdwSEdBMHlMRkRKQnYycnor?=
 =?utf-8?B?WjBhOE15cXlFcFZOK29RNElqRStWbFZaNWVGaTlJWVhROUpZYkRNdXAvU0di?=
 =?utf-8?B?RTQvUHpvMlZVV2Fjd29VYitObk1zNm9HM1RmOFUvM3l0cExPR0k4dWJpUXhl?=
 =?utf-8?B?SkRLRkw2dTFCZUd4MGhneEZlWnRkVXFMUUZwZ1ZkYzRZbmRjOCtkaXZSWEt0?=
 =?utf-8?B?ekxzenhsTURyVnFuLzAzWFcvWUJBZTR3Vkl5eDczRjZmeWVqYXJoS1VnYWJ5?=
 =?utf-8?B?TmozbFlrY3NFc1c5OURHSXAzTlBTMFZHL05UTTdpbGw3TUgxLzFHOERybVlZ?=
 =?utf-8?B?SjBaMjA2MEdITUpaekw4cDRFbTNJTUtqcmpvQU53S0U4TVN2aE5VYlRxWlpl?=
 =?utf-8?B?c1NmUjVjUWpxWkFKRVNCb3NpbjQ2NWQ0Tmg2eEhhSTV5SDZnM2pLdndsaUs1?=
 =?utf-8?B?Smc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a11a20a7-7e47-46f9-485c-08dc6ed42182
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 20:27:35.5343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mEuGn3MNLsobRJWTX2biNUkka3BRzTWe06fLvszTCPkRxGKuWrUPH7A4BnjbM/QEtjpgQAgeQ8D/qF7lm3CVwF4BnFXCYWMMfNCLU7hVVRE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4952
X-OriginatorOrg: intel.com

Hi Babu,

On 5/6/2024 1:23 PM, Moger, Babu wrote:
> On 5/3/24 18:26, Reinette Chatre wrote:
>> Hi Babu,
>>
>> In shortlog, please use () to indicate function:
>> resctrl_file_fflags_init().
>>
>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>> Consolidate multiple fflags initialization into one function.
>>>
>>> Remove thread_throttle_mode_init, mbm_config_rftype_init and
>>> consolidate them into resctrl_file_fflags_init.
>>
>> This changelog has no context and only describes what the code does,
>> which can be learned from reading the patch. Could you please
>> update changelog with context and motivation for this change?
> How about this?
> 
> Consolidate multiple fflags initialization into one function.
> 
> The functions thread_throttle_mode_init() and mbm_config_rftype_init()
> both initialize fflags for resctrl files. This can be simplified into one
> function passing the file name and flags to be initialized. It also helps
> code simplification of new flags initialized for ABMC feature.

I am not sure what you intend here. Is this the entire intended changelog?
I expected it to reflect x86 requirements as per
Documentation/process/maintainer-tip.rst. Under "Changelog":

"It's also useful to structure the changelog into several paragraphs and not
lump everything together into a single one. A good structure is to explain
the context, the problem and the solution in separate paragraphs and this
order."

Reinette