Received-SPF: pass (google.com: domain of linux-kernel+bounces-172158-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <b3e320ecb16320f88d7db566be51b1e9.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <b1fd9806-3e33-488a-a5a9-a156a2c735d2@kernel.org>
References: <20240504120624.6574-1-krzysztof.kozlowski@linaro.org> <8bf65df598680f0785c3d6db70acfb9a.sboyd@kernel.org> <b1fd9806-3e33-488a-a5a9-a156a2c735d2@kernel.org>
Subject: Re: [GIT PULL] clk: samsung: drivers for v6.10
From: Stephen Boyd <sboyd@kernel.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>, linux-clk@vger.kernel.org, Sylwester Nawrocki <snawrocki@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Peter Griffin <peter.griffin@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
To: Krzysztof Kozlowski <krzk@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Michael Turquette <mturquette@baylibre.com>
Date: Tue, 07 May 2024 13:43:21 -0700
User-Agent: alot/0.10

Quoting Krzysztof Kozlowski (2024-05-06 22:54:10)
> On 07/05/2024 01:44, Stephen Boyd wrote:
> > Quoting Krzysztof Kozlowski (2024-05-04 05:06:22)
> >> The following changes since commit 4cece764965020c22cff7665b18a0120063=
59095:
> >>
> >>   Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
> >>
> >> are available in the Git repository at:
> >>
> >>   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/=
samsung-clk-6.10
> >=20
> > I'm getting compile warnings. Is there a pending fix? Also, why is GS101
>=20
> I don't see any of these warnings. Neither local (W=3D1), nor on my CI,
> nor reported by LKP (which reported build successes for this branch).
> How can I reproduce it?

I ran this command

 make W=3D1 ARCH=3Darm CROSS_COMPILE=3Darm-linux-gnueabi- drivers/clk/samsu=
ng/clk-gs101.o

and I see the warnings. They're actually upgraded to errors.

>=20
>=20
> > describing clk parents with strings instead of using clk_parent_data?
>=20
> GS101 uses existing Samsuung clock framework, so that's how it is done
> there. There is nothing odd here, comparing to other Samsung clocks.

Ok. Is anyone working on migrating Samsung clk drivers to the non-string
way?

>=20
> >=20
> > In file included from drivers/clk/samsung/clk-gs101.c:16:
> > drivers/clk/samsung/clk-gs101.c:2616:7: error: =E2=80=98mout_hsi2_mmc_c=
ard_p=E2=80=99
> > defined but not used [-Werror=3Dunused-const-variable=3D]
> >  2616 | PNAME(mout_hsi2_mmc_card_p)     =3D { "fout_shared2_pll", "fout=
_shared3_pll",
>=20
> I see indeed some unused variables and I will drop them but your
> warnings are not reproducible.

Weird! I use gcc-12.2 if that helps. I've been meaning to upgrade but I
also don't see much urgency.

I'll wait for the next PR.