Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp116638lqo; Tue, 7 May 2024 14:08:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVdvd3PyYO9cmIVzDOWul/mkwFejCk/DUEO2nUg8K3RAMOhCEwGbVyZpQcUmm2R+PClwUDfwDjFjKTzedMFLBkOpFQ/WoNZN5h8d68NWQ== X-Google-Smtp-Source: AGHT+IEdHGd9IDcAQgNEfaHa4aVhn/GYhKAsIuVBcVS2VclzX1xDRZUOihSFqeA8mYdUM8Tx5o+i X-Received: by 2002:a17:90a:3d01:b0:2b5:f6d0:98cb with SMTP id 98e67ed59e1d1-2b616ae02d6mr709630a91.40.1715116134305; Tue, 07 May 2024 14:08:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715116134; cv=pass; d=google.com; s=arc-20160816; b=kr2txle7JLDYmODYT44sPoKTDUckWpIMfCx9Q4i6tBOudFgD7B8DyxvhZLMwGnqJl1 W3dEIDo5M+/b1gyLA2d6WNWPA2r0P35l5k0q/TP6pxz/7NPgxorxdc9Jl/S91/vCtiJc 0CttMoihNthjAWsZldWJJcuHkzLSV3e8BUTCIAiVnyKKwYxhviyCvf+rrfqXr6gqeKvq P0aK7DcNmEB8NDCaW7Ixerx3jXJ6pGL5y4+xQ+b73wVrlBPzXalxpi+++PcUQmHCEOZw JTM37Wh4a3U4ULRGb2q4z4E+2PTTjVlB41FeaKe17UDCkagmVykzCMqlZQgJ6uzX5F8r muWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=e3GVZN6gpxA06ywE5H/KsUzgknr/DPy7D639QoFn5Dg=; fh=YO8xDFyJOPCXP3cPud8+w7GNPEaqzidDfcgPtVLcJvo=; b=Qjx1Dt0RK3wlTzWYbvfuUJLryP1FAaEF4ZYiay+OYLZOMyPARRbn2JBX7u1/v5q9bJ A1f+1Cq8Glm79/HRzBbaUBwpSw6w/G3RWkkVi+v2a3Qc1ddFm55dQ+A42qxC4YaHEeJ8 LYvdtf28OASXJcwP8g6TixadzCqkdyvoLuZLPZURXgklUb+Vn8V9dCb/dtfQ20Zavlv2 cYnbHfo4wtb07A70Oo18gXEB0vBWx6B47B8U+6rgCFcVmQlJODcQky/cFr8FEkJYv2z4 Detjy7ISPSv4z93oJlQLugfpPG6KFEObBdwA3tUkOdZOgpctTJymg4pZpoQpVye/wA3H 488Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BSSswj7H; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172195-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172195-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h4-20020a17090ac38400b002a54416d027si11328999pjt.86.2024.05.07.14.08.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 14:08:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-172195-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BSSswj7H; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172195-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172195-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9B04A285B7A for ; Tue, 7 May 2024 21:08:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EBB62155A34; Tue, 7 May 2024 21:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BSSswj7H" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17DD314B957; Tue, 7 May 2024 21:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715116093; cv=none; b=GNxTxoBYAxQyq2CgEIxVv1dPCD6T397NUWzF7BrLbZPeA7i711Ubh7Au+EPVgv3TW6y8zUwj0KzTml4o8jY6R9LJYQ8LUQuXeYrJq95EkVBH1zn1DSgMU3ucfQY+nmE1b0vEcUzPVXap2WDOI6YwqUV8AhtRNAfR0Ijbv9O9/Tk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715116093; c=relaxed/simple; bh=7IIOVK26N76rgSrHKjrQT7SwQ7fJjZNCfd/ugJsoLdA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gz2o7DKQC61vp7Ny1eY/jkQS1gaD59hXKrB5II03GCNgS8Ofau+wiyFr2c6jym3nLaiVG3xlycqpT+BC4qdhQWwZgx8PcHsL634RElErpKAUy0HEOD9RUOlo5jz3sN6Hfwl2yRRS5nYEPlqOsp0TQwVa6Jv7u4LakqKoOtYD/aw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BSSswj7H; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEB02C4AF67; Tue, 7 May 2024 21:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715116093; bh=7IIOVK26N76rgSrHKjrQT7SwQ7fJjZNCfd/ugJsoLdA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BSSswj7HRYYcYd9Hbir/XBDSOGWszF5G1Moi09rkR32vJlx4ytRwt40ZDDFjO0gRj ap9k/Zzm52/sQgCKgdnnZ+z0uHZHMLIlnDuFIQYM1XzacRbM1pqNAaPjNJhIOR8y6c X6cYN3eIVMa/rJukq4xoI1ag5TGgPlEQRR7vNsG/ogTQtUw57P5H1NQs1WT2w/aRsF BK6G/q5jEeRXftLvCcDg+G4RVST07Ni9TWcl8EHBHBH7Vj4metpDQrCA41yGaAbiy/ gB5Mf4R3cHdnB5jykIdINnU0cFCV2aNUzCbPEdvtOBNr+E3m1XxyyYzFFDZtOFBLcv zprDrG5WhkSkA== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Vamshi Gajjela , linux-kernel@vger.kernel.org, patches@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH 04/12] spmi: hisi-spmi-controller: Do not override device identifier Date: Tue, 7 May 2024 14:07:41 -0700 Message-ID: <20240507210809.3479953-5-sboyd@kernel.org> X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog In-Reply-To: <20240507210809.3479953-1-sboyd@kernel.org> References: <20240507210809.3479953-1-sboyd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Vamshi Gajjela 'nr' member of struct spmi_controller, which serves as an identifier for the controller/bus. This value is a dynamic ID assigned in spmi_controller_alloc, and overriding it from the driver results in an ida_free error "ida_free called for id=xx which is not allocated". Signed-off-by: Vamshi Gajjela Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20240228185116.1269-1-vamshigajjela@google.com Signed-off-by: Stephen Boyd --- drivers/spmi/hisi-spmi-controller.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c index 674a350cc676..fa068b34b040 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -300,7 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev) spin_lock_init(&spmi_controller->lock); - ctrl->nr = spmi_controller->channel; ctrl->dev.parent = pdev->dev.parent; ctrl->dev.of_node = of_node_get(pdev->dev.of_node); -- https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git