Received-SPF: pass (google.com: domain of linux-kernel+bounces-172233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <53d7ad338f4d3d8f5c6b29c5bb8f9088.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <e93acd4c-20f7-4b46-bb9c-84fac451c894@app.fastmail.com>
References: <CA+G9fYuZd_ur56H8fwDSvUywopvn_b7ogprGkjEatQ7EPTLwYQ@mail.gmail.com> <11be44d3-0f32-49c6-b4ae-ba97a9f97763@app.fastmail.com> <820ddc2ec70780ae1ecd3af864dc8bd6.sboyd@kernel.org> <e93acd4c-20f7-4b46-bb9c-84fac451c894@app.fastmail.com>
Subject: Re: clkdev: report over-sized strings when creating clkdev entries
From: Stephen Boyd <sboyd@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>, Anders Roxell <anders.roxell@linaro.org>, Dan Carpenter <dan.carpenter@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Marek Szyprowski <m.szyprowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Naresh Kamboju <naresh.kamboju@linaro.org>, linux-clk <linux-clk@vger.kernel.org>, lkft-triage@lists.linaro.org, open list <linux-kernel@vger.kernel.org>
Date: Tue, 07 May 2024 14:55:58 -0700
User-Agent: alot/0.10

Quoting Arnd Bergmann (2024-05-07 13:52:59)
> On Tue, May 7, 2024, at 22:26, Stephen Boyd wrote:
> > Quoting Arnd Bergmann (2024-05-07 00:44:15)
> >> On Tue, May 7, 2024, at 09:20, Naresh Kamboju wrote:
> >> > The WinLink E850-96 board boot failed with Linux next-20240506 but t=
here
> >> > is no kernel crash log on the serial [1].
> >> >
> >> > Anders bisection results pointing to this commit,
> >> > # first bad commit:
> >> >   [4d11c62ca8d77cb1f79054844b598e0f4e92dabe]
> >> >   clkdev: report over-sized strings when creating clkdev entrie
> >> >
> >> > After reverting the above patch the boot test passed [2].
> >> >
> >> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >> >
> >
> > There are two fixes on the list: [1] and [2]. Perhaps one of those
> > resolves this?
> >
> > [1] https://lore.kernel.org/r/20240507065317.3214186-1-m.szyprowski@sam=
sung.com
> > [2] https://lore.kernel.org/r/20240507064434.3213933-1-m.szyprowski@sam=
sung.com
>=20
> My guess is that either one avoids the crash, but we actually
> want both of them since the problem is a combination of the two
> issues.
>=20
> I think we also need this one on top, to have a va_end() for
> each return() statement:

Makes sense. Hopefully Russell can fold that fix in as well, or you can
send it to the patch tracker.