Received-SPF: pass (google.com: domain of linux-kernel+bounces-172238-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a2f7b0d6-97d8-4093-be93-6e9d3e0e0597@intel.com>
Date: Wed, 8 May 2024 09:59:46 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 023/130] KVM: TDX: Initialize the TDX module when
 loading the KVM intel kernel module
To: Sean Christopherson <seanjc@google.com>
CC: "Zhang, Tina" <tina.zhang@intel.com>, "Yuan, Hang" <hang.yuan@intel.com>,
	"Chen, Bo2" <chen.bo@intel.com>, "sagis@google.com" <sagis@google.com>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Aktas, Erdem"
	<erdemaktas@google.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>, "Yamahata, Isaku"
	<isaku.yamahata@intel.com>, "isaku.yamahata@linux.intel.com"
	<isaku.yamahata@linux.intel.com>
References: <Zh7KrSwJXu-odQpN@google.com>
 <900fc6f75b3704780ac16c90ace23b2f465bb689.camel@intel.com>
 <Zh_exbWc90khzmYm@google.com>
 <2383a1e9-ba2b-470f-8807-5f5f2528c7ad@intel.com>
 <ZiBc13qU6P3OBn7w@google.com>
 <5ffd4052-4735-449a-9bee-f42563add778@intel.com>
 <ZiEulnEr4TiYQxsB@google.com>
 <22b19d11-056c-402b-ac19-a389000d6339@intel.com>
 <ZiKoqMk-wZKdiar9@google.com>
 <0ddb198c9a8ae72519c3f7847089d84a8de4821f.camel@intel.com>
 <ZjpVslp5M0JJbPrB@google.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <ZjpVslp5M0JJbPrB@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NElUd3c2NTR6KzBiWXh3SWxBYStjSlJKNWtJWXFFZXkvSzRFUGpWMmZra2xJ?=
 =?utf-8?B?SHh0MXI3M3BhNXNlWGpjWU42RklCWFB3WEhaOWRWd2tLVXRnNzc0eVJsVlRM?=
 =?utf-8?B?TmFablZ6NlhsU0NBeGVzalVrOGFoZjVZc1lxMVpzYVdnVmhacm05a2VNeERR?=
 =?utf-8?B?a1JHYSttQ0MwM1BRUFE3RDhtUWFGSlJaY2JuOXhuKzYvdTg3R3dWb2ljbjVI?=
 =?utf-8?B?YjhHT3JuektlR3RIWUpkMkZtUTkxS3pWdGhUU2N1L2V0am1CcXBVMWJVWGYr?=
 =?utf-8?B?Y0luRXViYWdzMVhKMWpza05LK1k0WnpNSWVNQzQ3ZHdjdXVpZHlJMEpucXhk?=
 =?utf-8?B?MlpoOGRJZ25NLzZadXRYVWFRWXBZVkdjVUpVUWNVcjY2RndDei9GcG42Mnl1?=
 =?utf-8?B?TmhScDNhMDQvUEw1ZXhuUjVUNm5sUndGbWdtM0NpYjFrSTdZU1RQVXFZTHRa?=
 =?utf-8?B?RXl0ZzJwVzhBUEJsMHNXZTFteFFiT09yY09GN0ZzUHRKbTdDWEpSOGk3ektS?=
 =?utf-8?B?MDEzWHpZTUhyOHZiVGY3STVDREx5RGdweXRtVE5wYitqNkh5bkVrVWdRbzVv?=
 =?utf-8?B?WnRiUDVZamlrK09NTlQvSjZEOVBOdnRoZnVScDUvM2RjdDVJUTI1OTl1SytN?=
 =?utf-8?B?TmEvV2ZBUVBieisvMHlxcnhZcGx2amwzMk4zYVptOC9nMHRtZnJ3U09FQ2xy?=
 =?utf-8?B?Q3lSVTUxTjVKbmtHNVpWVTdKUWRSUkFQVUVCUlIvenNVOC9VOXhNem93Qnhr?=
 =?utf-8?B?UG9yQm94UzR1YnJGRzBVOTFmZ1FpTEs2TVYrc3Q2VzNpdTE3OFpiRmhaS0cy?=
 =?utf-8?B?bXdlR3Zud1R5YVBqcFJHdVUzSUtYWVVBUGZrWXJYd1NoNDJFQlY2SnVGclhX?=
 =?utf-8?B?Q2xzbHpoTXVMWVQ0bGtlTWZkcXhJNXZKaWJ6Qk80RXZiOVc0aUJLMDhJNEs1?=
 =?utf-8?B?ZmJXbDVJR04zR1pxVVU0Q0tKWkVMaFU4TjNYQzBFTkZyUnZWdmpFYU5pMWx1?=
 =?utf-8?B?aGFUc3IrMWovYkZqQ1haTERQODdFcjJuUVJFenZXWEJvQTJ5cHRxUk9UTHZK?=
 =?utf-8?B?K3VYVFRCYmJQbUpYVDlYTitVVzdBSkpvMnBhVEtLZXlWcEhvQURQWmlXZzVa?=
 =?utf-8?B?eUtVbkQ3bXQwL3Rla3ArNGVaSFY1cCsxbXdDWWZzN1ZVUjI5K3N1QVVTWEc5?=
 =?utf-8?B?cENZaEd4L2sydmtKbCt4TStJSUoyVkE4Vk5XQ1BZWWFyaG05K3JSNjk0cDJx?=
 =?utf-8?B?VUxRNGNxSzU2M0t4amczUnhwT1ZDaWl2c2kyd29XYzFNdmpVcElGV3dJRkNL?=
 =?utf-8?B?RXZOSU5EZHN4ZC9odDI0Z3JpSDJxOFBqNlNib1IzRW9FMUdRRGlQQlgxOER3?=
 =?utf-8?B?N1BCMjBqeTUva1JBZ29Td3BqQm5CcjBEZ1FkTjNjaW5iSjdTZE5xZVZrTmFm?=
 =?utf-8?B?ZjhqWUZ5eDdpZE0zZHl4eEM3aWwveTl4QlNVZG9pS0dTN3g0SFRvVmV1L2pJ?=
 =?utf-8?B?U0ZBY01SNExydFE2RnM4dWtFRnlhKyt5WG1GdkRYYkVNaTJ0UTF2RTNBOGRh?=
 =?utf-8?B?Uk9sdkhEbjltNko4bW1ZR29jTUdXQ2ZENXc1M3NNbzFPdVM1UkF4VGQwcElC?=
 =?utf-8?B?WS9XR1MxZFVsWXN0dFJDMVJzdXpmZEdnYUdsZWxUbFNjZVlVQjBVNkNmQWkx?=
 =?utf-8?B?NjNIVDhiVjNqMzRwV3JQS2pVRTExd0g3cnMwN3kySDBDbU1HMUxOQUo0azh3?=
 =?utf-8?B?OVpQZG13Y205bnJPTVJUcjNtbW9UaVpTTDNkNzdGc0xFYnREZmFEU3FtTDBH?=
 =?utf-8?B?dWxpRy82eWo4Qlgzak1NMFBhanpJT0ZuS25XRzVFdWJGWGpna3BSRkJvOWVT?=
 =?utf-8?B?c1VGT2pUVE5LN0wyazJwSVJzQktzemxBcWVsenZwQlNyUlk3Y0lVeHhTbUVR?=
 =?utf-8?B?bXdseWRVWXJrS3VwQ0NsMkFrN0Rkd3l4cHdDNTBjSnBxc1Z0MVBrMXBMaTQ2?=
 =?utf-8?B?UGZuc0szUVB3a00xN2hFek0yUVpKd3NMbDEyaW1idWxoZlNoMkdzOW9IQnVm?=
 =?utf-8?B?ZjJhOG5lZlBsN3lnWmtvbUdDM2dEd2c2bkhBYUJ6THhnTXJSSGExN1F3STJp?=
 =?utf-8?Q?ZLBVa4O/7VL7692jo/aRAl0NE?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f7fb06a8-805c-45f7-089e-08dc6ee1076d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 21:59:55.3048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z80P8P8EZkkv8I0hLyh8vNOOfdCT/MtZBsELHws3KRv27pxu/1p1NwBHr6OVSFHebJRwO3Tqyo/JLztkBkTVEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8763
X-OriginatorOrg: intel.com


On 8/05/2024 4:24 am, Sean Christopherson wrote:
> On Tue, May 07, 2024, Kai Huang wrote:
>>>> So I think we have consensus to go with the approach that shows in your
>>>> second diff -- that is to always enable virtualization during module loading
>>>> for all other ARCHs other than x86, for which we only always enables
>>>> virtualization during module loading for TDX.
>>>
>>> Assuming the other arch maintainers are ok with that approach.  If waiting until
>>> a VM is created is desirable for other architectures, then we'll need to figure
>>> out a plan b.  E.g. KVM arm64 doesn't support being built as a module, so enabling
>>> hardware during initialization would mean virtualization is enabled for any kernel
>>> that is built with CONFIG_KVM=y.
>>>
>>> Actually, duh.  There's absolutely no reason to force other architectures to
>>> choose when to enable virtualization.  As evidenced by the massaging to have x86
>>> keep enabling virtualization on-demand for !TDX, the cleanups don't come from
>>> enabling virtualization during module load, they come from registering cpuup and
>>> syscore ops when virtualization is enabled.
>>>
>>> I.e. we can keep kvm_usage_count in common code, and just do exactly what I
>>> proposed for kvm_x86_enable_virtualization().
>>>
>>> I have patches to do this, and initial testing suggests they aren't wildly
>>> broken.  I'll post them soon-ish, assuming nothing pops up in testing.  They are
>>> clean enough that they can land in advance of TDX, e.g. in kvm-coco-queue even
>>> before other architectures verify I didn't break them.
>>>
>>
>> Hi Sean,
>>
>> Just want to check with you what is your plan on this?
>>
>> Please feel free to let me know if there's anything that I can help.
> 
> Ah shoot, I posted patches[*] but managed to forget to Cc any of the TDX folks.
> Sorry :-/
> 
> [*] https://lore.kernel.org/all/20240425233951.3344485-1-seanjc@google.com

Oh I missed that :-( Thanks for the info!