Received-SPF: pass (google.com: domain of linux-kernel+bounces-172259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9d9c2912-e965-435d-b0d9-7e6071c24ab3@quicinc.com>
Date: Tue, 7 May 2024 15:54:06 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] nilfs2: fix nilfs_btree_commit_convert_and_insert()
 kernel-doc
Content-Language: en-US
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
CC: <linux-nilfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240507-nilfs_btree_convert_and_insert-kdoc-v1-1-bab3514eb753@quicinc.com>
 <CAKFNMomG+GuKJ53WmdWFONtimhbanKU-B_ZTdt5sEFxcuYxJ3w@mail.gmail.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <CAKFNMomG+GuKJ53WmdWFONtimhbanKU-B_ZTdt5sEFxcuYxJ3w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On 5/7/2024 3:45 PM, Ryusuke Konishi wrote:
> On Wed, May 8, 2024 at 7:23 AM Jeff Johnson wrote:
>>
>> Fix the following reported by make W=1:
>>
>> fs/nilfs2/btree.c:1871: warning: Function parameter or struct member 'btree' not described in 'nilfs_btree_convert_and_insert'
>> fs/nilfs2/btree.c:1871: warning: Excess function parameter 'bmap' description in 'nilfs_btree_convert_and_insert'
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>  fs/nilfs2/btree.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
>> index 65659fa0372e..8299839b5129 100644
>> --- a/fs/nilfs2/btree.c
>> +++ b/fs/nilfs2/btree.c
>> @@ -1858,7 +1858,7 @@ nilfs_btree_commit_convert_and_insert(struct nilfs_bmap *btree,
>>
>>  /**
>>   * nilfs_btree_convert_and_insert -
>> - * @bmap:
>> + * @btree: bmap struct of btree
>>   * @key:
>>   * @ptr:
>>   * @keys:
>>
>> ---
>> base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
>> change-id: 20240507-nilfs_btree_convert_and_insert-kdoc-7753c4a6e7c3
>>
> 
> Hi Jeff, thank you for posting.
> 
> However, a fix for this kernel-doc warnings is already queued in the
> mm tree (to be merged in the next merge window).
> 
> Please refer to the patch below:
> 
> https://lkml.kernel.org/r/20240410075629.3441-3-konishi.ryusuke@gmail.com
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-nonmm-stable&id=3da9b9650acc3a2a0c3d3f4542b93d4abe9da1de
> 
> 
> Thanks,
> Ryusuke Konishi

Awesome that others are helping to clean these :)

Guess I should check lore before fixing so that I don't replicate work!

/jeff